generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 271
Open
Labels
area/runtimeIssues or PRs as related to controller runtime, common reconciliation logic, etcIssues or PRs as related to controller runtime, common reconciliation logic, etckind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
Description
Describe the bug
ACK runtime fails to patch resource status on certain reconciler errors.
When the controller fails to patch the aws resource status, users are forced to debug the logs and parse over many resources to figure out what went wrong.
Steps to reproduce
Resource status will not be patched if:
- CARM: issue when provided role ARN is invalid https://github.com/aws-controllers-k8s/runtime/blob/main/pkg/runtime/reconciler.go#L251
- Region or AccountID drifted: https://github.com/aws-controllers-k8s/runtime/blob/main/pkg/runtime/reconciler.go#L285
resourceReconciler.reconcilereturns a nillatestresource- This can happen during resource addoption by annotation
- some AWS api errors https://github.com/aws-controllers-k8s/iam-controller/blob/main/pkg/resource/role/sdk.go#L70-L88
- etc.
Expected outcome
On all the steps defined above, we want the ACK controllers to patch the status with the appropriate condition
Metadata
Metadata
Assignees
Labels
area/runtimeIssues or PRs as related to controller runtime, common reconciliation logic, etcIssues or PRs as related to controller runtime, common reconciliation logic, etckind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.