Fix Internet Gateway terminal codes (#68)

Issue #, if available: [1362](aws-controllers-k8s/community#1362)

Description of changes: 

- Removed `InvalidVpcId.Malformed` error from terminal codes for **Internet Gateway** resource.
- Removed Integration tests for the `InvalidVpcId.Malformed` terminal code.

Initially, I thought `InvalidVpcId.Malformed` should be included in the terminal codes. Later, observed that Internet Gateway resource being created after adding the integration tests for the malformed vpc id terminal code. This is expected as per our code because initially the resource will be created with no vpc attachment and later if we pass VPC ID, it will be attached to the resource. After discussions and local testing I observed that if you add malformed VPC ID it will create a resource and if you try to update the VPC ID to a valid one, it will create a new resource and leave the initial one in dangling state that cannot be deleted, so we decided not to include malformed VPC ID  for Internet Gateway resource.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: LikithaVemulapalli

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2022-08-02T21:22:57Z"
+  build_date: "2022-08-08T17:04:17Z"
   build_hash: 87477ae8ca8ac6ddb8c565bbd910cc7e30f55ed0
   go_version: go1.18.3
   version: v0.19.3
 api_directory_checksum: 8c35bdcab21768638dfaa277896e05fdd8a11969
 api_version: v1alpha1
 aws_sdk_go_version: v1.42.0
 generator_config_info:
-  file_checksum: adb5f55a4d7edff7d658a208d5ae3bf6d86f3172
+  file_checksum: da927f39a013c7d5ed82db3df0daf4cd22c605d3
   original_file_name: generator.yaml
 last_modification:
   reason: API generation

apis/v1alpha1/generator.yaml

@@ -236,9 +236,6 @@ resources:
       sdk_read_many_post_build_request:
         template_path: hooks/elastic_ip_address/sdk_read_many_post_build_request.go.tpl
   InternetGateway:
-    exceptions:
-      terminal_codes:
-      - InvalidVpcId.Malformed
     fields:
       Tags:
         from:

generator.yaml

@@ -236,9 +236,6 @@ resources:
       sdk_read_many_post_build_request:
         template_path: hooks/elastic_ip_address/sdk_read_many_post_build_request.go.tpl
   InternetGateway:
-    exceptions:
-      terminal_codes:
-      - InvalidVpcId.Malformed
     fields:
       Tags:
         from:

pkg/resource/internet_gateway/sdk.go

@@ -181,36 +181,4 @@ def test_vpc_association(self, ec2_client, empty_vpc):
         time.sleep(DELETE_WAIT_AFTER_SECONDS)
 
         # Check Internet Gateway no longer exists in AWS
-        ec2_validator.assert_internet_gateway(resource_id, exists=False)
-
-    def test_terminal_condition_malformed_vpc(self):
-        test_resource_values = REPLACEMENT_VALUES.copy()
-        resource_name = random_suffix_name("ig-ack-fail-1", 24)
-        test_resource_values["INTERNET_GATEWAY_NAME"] = resource_name
-        test_resource_values["VPC_ID"] = "MalformedVpcId"
-
-        # Load Internet Gateway CR
-        resource_data = load_ec2_resource(
-            "internet_gateway_vpc_attachment",
-            additional_replacements=test_resource_values,
-        )
-        logging.debug(resource_data)
-
-        # Create k8s resource
-        ref = k8s.CustomResourceReference(
-            CRD_GROUP, CRD_VERSION, RESOURCE_PLURAL,
-            resource_name, namespace="default",
-        )
-        k8s.create_custom_resource(ref, resource_data)
-        cr = k8s.wait_resource_consumed_by_controller(ref)
-
-        assert cr is not None
-        assert k8s.get_resource_exists(ref)
-
-        expected_msg = 'InvalidVpcId.Malformed: Invalid id: "MalformedVpcId"'
-        terminal_condition = k8s.get_resource_condition(ref, "ACK.Terminal")
-        # Example condition message:
-        # An error occurred (InvalidVpcId.Malformed) when calling the AttachInternetGateway operation:
-        # Invalid id: "MalformedVpcId" 
-        # (expecting "vpc-...")
-        assert expected_msg in terminal_condition['message']
+        ec2_validator.assert_internet_gateway(resource_id, exists=False)