Update functionality for Subnet settings (#101)

Issue #, if available: aws-controllers-k8s/community#1203

Description of changes: Updates `Subnet.Spec` fields, hooks, templates, and tests to align with `Subnet > Edit subnet settings` console functionality

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: brycahta

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2022-09-30T18:33:33Z"
-  build_hash: 6e2ffbc3b16a30ac59be6719918c601c2c864064
+  build_date: "2022-10-05T16:31:59Z"
+  build_hash: 5ee0ac052c54f008dff50f6f5ebb73f2cf3a0bd7
   go_version: go1.18.1
-  version: v0.20.1-3-g6e2ffbc
-api_directory_checksum: 127aa0f51fbcdde596b8f42f93bcdf3b6dee8488
+  version: v0.20.1-4-g5ee0ac0
+api_directory_checksum: 1c3549b0567c7f33a4a331c980a5c460154c32e0
 api_version: v1alpha1
 aws_sdk_go_version: v1.44.93
 generator_config_info:
-  file_checksum: 100888fa9c8d854c46c386442c6e7e06e34940cf
+  file_checksum: 8797fe03195c58e4386f043a7a3d76d0c33c69e6
   original_file_name: generator.yaml
 last_modification:
   reason: API generation

apis/v1alpha1/generator.yaml

@@ -410,6 +410,26 @@ resources:
       custom_method_name: customUpdateSecurityGroup
   Subnet:
     fields:
+      # code-generator infers fields into
+      # Status based on whether or not the fields
+      # can be edited in the Create input shape.
+      # However, these fields can now be edited after
+      # after implementing custom hook code; therefore,
+      # relocate fields from Status to Spec.
+      AssignIpv6AddressOnCreation:
+        type: bool
+      CustomerOwnedIpv4Pool:
+        type: string
+      EnableDns64:
+        type: bool
+      EnableResourceNameDnsARecord:
+        type: bool
+      EnableResourceNameDnsAAAARecord:
+        type: bool
+      HostnameType:
+        type: string
+      MapPublicIpOnLaunch:
+        type: bool
       RouteTables:
         custom_field:
           list_of: String
@@ -427,6 +447,7 @@ resources:
     exceptions:
       terminal_codes:
         - InvalidParameterValue
+        - InvalidCustomerOwnedIpv4PoolID.Malformed
     hooks:
       sdk_create_post_build_request:
         template_path: hooks/subnet/sdk_create_post_build_request.go.tpl

apis/v1alpha1/subnet.go

@@ -36,6 +36,8 @@ spec:
             description: "SubnetSpec defines the desired state of Subnet. \n Describes
               a subnet."
             properties:
+              assignIPv6AddressOnCreation:
+                type: boolean
               availabilityZone:
                 description: "The Availability Zone or Local Zone for the subnet.
                   \n Default: Amazon Web Services selects one for you. If you create
@@ -58,6 +60,16 @@ spec:
                   we modify it to 100.68.0.0/18. \n This parameter is not supported
                   for an IPv6 only subnet."
                 type: string
+              customerOwnedIPv4Pool:
+                type: string
+              enableDNS64:
+                type: boolean
+              enableResourceNameDNSAAAARecord:
+                type: boolean
+              enableResourceNameDNSARecord:
+                type: boolean
+              hostnameType:
+                type: string
               ipv6CIDRBlock:
                 description: "The IPv6 network range for the subnet, in CIDR notation.
                   The subnet size must use a /64 prefix length. \n This parameter
@@ -66,6 +78,8 @@ spec:
               ipv6Native:
                 description: Indicates whether to create an IPv6 only subnet.
                 type: boolean
+              mapPublicIPOnLaunch:
+                type: boolean
               outpostARN:
                 description: The Amazon Resource Name (ARN) of the Outpost. If you
                   specify an Outpost ARN, you must also specify the Availability Zone
@@ -152,11 +166,6 @@ spec:
                 - ownerAccountID
                 - region
                 type: object
-              assignIPv6AddressOnCreation:
-                description: Indicates whether a network interface created in this
-                  subnet (including a network interface created by RunInstances) receives
-                  an IPv6 address.
-                type: boolean
               availableIPAddressCount:
                 description: The number of unused private IPv4 addresses in the subnet.
                   The IPv4 addresses for any stopped instances are considered unavailable.
@@ -195,20 +204,11 @@ spec:
                   - type
                   type: object
                 type: array
-              customerOwnedIPv4Pool:
-                description: The customer-owned IPv4 address pool associated with
-                  the subnet.
-                type: string
               defaultForAZ:
                 description: Indicates whether this is the default subnet for the
                   Availability Zone.
                 type: boolean
-              enableDNS64:
-                description: Indicates whether DNS queries made to the Amazon-provided
-                  DNS Resolver in this subnet should return synthetic IPv6 addresses
-                  for IPv4-only destinations.
-                type: boolean
-              enableLniAtDeviceIndex:
+              enableLNIAtDeviceIndex:
                 description: Indicates the device position for local network interfaces
                   in this subnet. For example, 1 indicates local network interfaces
                   in this subnet are the secondary network interface (eth1).
@@ -240,10 +240,6 @@ spec:
                   subnet (including a network interface created by RunInstances) receives
                   a customer-owned IPv4 address.
                 type: boolean
-              mapPublicIPOnLaunch:
-                description: Indicates whether instances launched in this subnet receive
-                  a public IPv4 address.
-                type: boolean
               ownerID:
                 description: The ID of the Amazon Web Services account that owns the
                   subnet.

apis/v1alpha1/types.go

@@ -410,6 +410,26 @@ resources:
       custom_method_name: customUpdateSecurityGroup
   Subnet:
     fields:
+      # code-generator infers fields into
+      # Status based on whether or not the fields
+      # can be edited in the Create input shape.
+      # However, these fields can now be edited after
+      # after implementing custom hook code; therefore,
+      # relocate fields from Status to Spec.
+      AssignIpv6AddressOnCreation:
+        type: bool
+      CustomerOwnedIpv4Pool:
+        type: string
+      EnableDns64:
+        type: bool
+      EnableResourceNameDnsARecord:
+        type: bool
+      EnableResourceNameDnsAAAARecord:
+        type: bool
+      HostnameType:
+        type: string
+      MapPublicIpOnLaunch:
+        type: bool
       RouteTables:
         custom_field:
           list_of: String
@@ -427,6 +447,7 @@ resources:
     exceptions:
       terminal_codes:
         - InvalidParameterValue
+        - InvalidCustomerOwnedIpv4PoolID.Malformed
     hooks:
       sdk_create_post_build_request:
         template_path: hooks/subnet/sdk_create_post_build_request.go.tpl