fix: only force syncing a VPC endpoint when in pending state (#198)

Context: #191 (comment)

A synced VPC endpoint should only be forced to re-sync when it's in `pending` state. For other states like `pendingAcceptance`, `rejected`, `failed`, `expired`, it could be the final state of the endpoint and the sync should be considered completed.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: wjf3121

pkg/resource/vpc_endpoint/hooks.go

@@ -35,12 +35,12 @@ const (
 	StatusFailed            = "failed"
 )
 
-func vpcEndpointAvailable(r *resource) bool {
+func vpcEndpointPending(r *resource) bool {
 	if r.ko.Status.State == nil {
 		return false
 	}
 	cs := *r.ko.Status.State
-	return cs == StatusAvailable
+	return cs == StatusPending
 }
 
 // addIDToDeleteRequest adds resource's Vpc Endpoint ID to DeleteRequest.

pkg/resource/vpc_endpoint/sdk.go

@@ -1,8 +1,6 @@
 
-	if !vpcEndpointAvailable(&resource{ko}) {
+	if vpcEndpointPending(&resource{ko}) {
 		// Setting resource synced condition to false will trigger a requeue of
 		// the resource. No need to return a requeue error here.
 		ackcondition.SetSynced(&resource{ko}, corev1.ConditionFalse, nil, nil)
-	} else {
-		ackcondition.SetSynced(&resource{ko}, corev1.ConditionTrue, nil, nil)
 	}