Skip to content

Commit b161bb6

Browse files
authored
Ignore comparing Tags in generated Delta (#113)
Issue #, if available: N/A Description of changes: This `compare: is_ignored` config is needed alongside the `delta_pre_compare: compareTags` otherwise the generated `Delta` may still return a false difference due to Tag order By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 334b246 commit b161bb6

File tree

14 files changed

+46
-35
lines changed

14 files changed

+46
-35
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
ack_generate_info:
2-
build_date: "2022-10-13T18:47:02Z"
2+
build_date: "2022-10-13T20:17:24Z"
33
build_hash: 5ee0ac052c54f008dff50f6f5ebb73f2cf3a0bd7
44
go_version: go1.18.1
55
version: v0.20.1-4-g5ee0ac0
66
api_directory_checksum: b3a2878ca8a156389214b900257c4d572ad4e3a5
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.44.93
99
generator_config_info:
10-
file_checksum: 0260a4e58e3e1667fc456baff448cbabc2da4bf6
10+
file_checksum: cc2c6590c6e77a6125d5eec82ff5f693109d4f99
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation

apis/v1alpha1/generator.yaml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,8 @@ resources:
184184
from:
185185
operation: CreateTags
186186
path: Tags
187+
compare:
188+
is_ignored: True
187189
hooks:
188190
delta_pre_compare:
189191
code: compareTags(delta, a, b)
@@ -212,6 +214,8 @@ resources:
212214
from:
213215
operation: CreateTags
214216
path: Tags
217+
compare:
218+
is_ignored: True
215219
hooks:
216220
delta_pre_compare:
217221
code: compareTags(delta, a, b)
@@ -244,6 +248,8 @@ resources:
244248
from:
245249
operation: CreateTags
246250
path: Tags
251+
compare:
252+
is_ignored: True
247253
list_operation:
248254
match_fields:
249255
- AllocationId
@@ -268,6 +274,8 @@ resources:
268274
from:
269275
operation: CreateTags
270276
path: Tags
277+
compare:
278+
is_ignored: True
271279
VPC:
272280
from:
273281
operation: AttachInternetGateway
@@ -321,6 +329,8 @@ resources:
321329
from:
322330
operation: CreateTags
323331
path: Tags
332+
compare:
333+
is_ignored: True
324334
synced:
325335
when:
326336
- path: Status.State
@@ -362,6 +372,8 @@ resources:
362372
from:
363373
operation: CreateTags
364374
path: Tags
375+
compare:
376+
is_ignored: True
365377
VpcId:
366378
references:
367379
resource: VPC
@@ -418,6 +430,8 @@ resources:
418430
from:
419431
operation: CreateTags
420432
path: Tags
433+
compare:
434+
is_ignored: True
421435
VpcId:
422436
is_required: true
423437
references:
@@ -491,6 +505,8 @@ resources:
491505
from:
492506
operation: CreateTags
493507
path: Tags
508+
compare:
509+
is_ignored: True
494510
VpcId:
495511
references:
496512
resource: VPC
@@ -518,6 +534,8 @@ resources:
518534
from:
519535
operation: CreateTags
520536
path: Tags
537+
compare:
538+
is_ignored: True
521539
State:
522540
print:
523541
path: Status.state
@@ -565,6 +583,8 @@ resources:
565583
from:
566584
operation: CreateTags
567585
path: Tags
586+
compare:
587+
is_ignored: True
568588
VpcID:
569589
print:
570590
path: Status.vpcID
@@ -588,6 +608,8 @@ resources:
588608
from:
589609
operation: CreateTags
590610
path: Tags
611+
compare:
612+
is_ignored: True
591613
VpcId:
592614
references:
593615
resource: VPC

generator.yaml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,8 @@ resources:
184184
from:
185185
operation: CreateTags
186186
path: Tags
187+
compare:
188+
is_ignored: True
187189
hooks:
188190
delta_pre_compare:
189191
code: compareTags(delta, a, b)
@@ -212,6 +214,8 @@ resources:
212214
from:
213215
operation: CreateTags
214216
path: Tags
217+
compare:
218+
is_ignored: True
215219
hooks:
216220
delta_pre_compare:
217221
code: compareTags(delta, a, b)
@@ -244,6 +248,8 @@ resources:
244248
from:
245249
operation: CreateTags
246250
path: Tags
251+
compare:
252+
is_ignored: True
247253
list_operation:
248254
match_fields:
249255
- AllocationId
@@ -268,6 +274,8 @@ resources:
268274
from:
269275
operation: CreateTags
270276
path: Tags
277+
compare:
278+
is_ignored: True
271279
VPC:
272280
from:
273281
operation: AttachInternetGateway
@@ -321,6 +329,8 @@ resources:
321329
from:
322330
operation: CreateTags
323331
path: Tags
332+
compare:
333+
is_ignored: True
324334
synced:
325335
when:
326336
- path: Status.State
@@ -362,6 +372,8 @@ resources:
362372
from:
363373
operation: CreateTags
364374
path: Tags
375+
compare:
376+
is_ignored: True
365377
VpcId:
366378
references:
367379
resource: VPC
@@ -418,6 +430,8 @@ resources:
418430
from:
419431
operation: CreateTags
420432
path: Tags
433+
compare:
434+
is_ignored: True
421435
VpcId:
422436
is_required: true
423437
references:
@@ -491,6 +505,8 @@ resources:
491505
from:
492506
operation: CreateTags
493507
path: Tags
508+
compare:
509+
is_ignored: True
494510
VpcId:
495511
references:
496512
resource: VPC
@@ -518,6 +534,8 @@ resources:
518534
from:
519535
operation: CreateTags
520536
path: Tags
537+
compare:
538+
is_ignored: True
521539
State:
522540
print:
523541
path: Status.state
@@ -565,6 +583,8 @@ resources:
565583
from:
566584
operation: CreateTags
567585
path: Tags
586+
compare:
587+
is_ignored: True
568588
VpcID:
569589
print:
570590
path: Status.vpcID
@@ -588,6 +608,8 @@ resources:
588608
from:
589609
operation: CreateTags
590610
path: Tags
611+
compare:
612+
is_ignored: True
591613
VpcId:
592614
references:
593615
resource: VPC

pkg/resource/dhcp_options/delta.go

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/resource/elastic_ip_address/delta.go

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/resource/instance/delta.go

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/resource/internet_gateway/delta.go

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/resource/nat_gateway/delta.go

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/resource/route_table/delta.go

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/resource/security_group/delta.go

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)