From 79b03b0c8bfd8596e4e665fb1f92a16a2fc599ab Mon Sep 17 00:00:00 2001 From: Jose Ledesma Date: Tue, 2 Sep 2025 15:33:32 +0200 Subject: [PATCH] fix: set proper desiredSize when increasing minSize --- pkg/resource/nodegroup/hook.go | 3 +++ pkg/resource/nodegroup/hook_test.go | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/pkg/resource/nodegroup/hook.go b/pkg/resource/nodegroup/hook.go index 4a018f4f..911d199c 100644 --- a/pkg/resource/nodegroup/hook.go +++ b/pkg/resource/nodegroup/hook.go @@ -548,6 +548,9 @@ func (rm *resourceManager) newUpdateScalingConfigPayload( ) temp := int32(*latest.ko.Spec.ScalingConfig.DesiredSize) sc.DesiredSize = &temp + if *sc.MinSize > *sc.DesiredSize { + *sc.DesiredSize = *sc.MinSize + } } return sc, nil } diff --git a/pkg/resource/nodegroup/hook_test.go b/pkg/resource/nodegroup/hook_test.go index 6222ca66..785d702e 100644 --- a/pkg/resource/nodegroup/hook_test.go +++ b/pkg/resource/nodegroup/hook_test.go @@ -346,7 +346,7 @@ func Test_resourceManager_newUpdateScalingConfigPayload_ManagedByExternalAutosca desired: newNodegroupScalingConfigManagedByExternalAutoscaler(20, 15, 20), latest: newNodegroupScalingConfigManagedByExternalAutoscaler(10, 10, 10), }, - want: newUpdateScalingConfigPayload(10, 15, 20), + want: newUpdateScalingConfigPayload(20, 15, 20), wantErr: false, }, { @@ -355,7 +355,7 @@ func Test_resourceManager_newUpdateScalingConfigPayload_ManagedByExternalAutosca desired: newNodegroupScalingConfigManagedByExternalAutoscaler(10, 15, 20), latest: newNodegroupScalingConfigManagedByExternalAutoscaler(10, 10, 10), }, - want: newUpdateScalingConfigPayload(10, 15, 20), + want: newUpdateScalingConfigPayload(20, 15, 20), wantErr: false, }, {