Keep the desired code.s3* fields part of the spec (#43)

Fixes aws-controllers-k8s/community#1402

The AWS Lambda API doesn't return the original submitted `s3Bucket`,
`s3Key`, and `s3ObjectVersion` when a function is successfully created.
Instead, it returns different values (In `Getfunction` call) in a
different response field (`Code.Location`). This is causing the
generated code in ACK to set the `spec.Code.s3*` fields to nil values.

To keep the experience in ACK lambda-controller consistent in the
Kubernetes-land, we must keep the original submitted `code.S3*` fields 
part of the function's spec.

This patch removes the part that is setting the `spec.Code.s3*` to nil
and allows the controllers to keep the original values part of the spec.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Amine Hilaly <[email protected]>

Author: a-hilaly

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2022-08-14T02:48:40Z"
+  build_date: "2022-08-11T19:32:42Z"
   build_hash: 87477ae8ca8ac6ddb8c565bbd910cc7e30f55ed0
   go_version: go1.18.1
   version: v0.19.3
 api_directory_checksum: 3c3c74f14b359bf55495aabc720fddbe21254966
 api_version: v1alpha1
 aws_sdk_go_version: v1.44.60
 generator_config_info:
-  file_checksum: 9e2e36e894eb563184f2e40efe8198ec65c3c387
+  file_checksum: 6eb0aca0b19db6cf5fcb510de34fc3a7f5a74cac
   original_file_name: generator.yaml
 last_modification:
   reason: API generation

apis/v1alpha1/generator.yaml

@@ -18,6 +18,9 @@ resources:
       Code:
         compare:
           is_ignored: true
+        set:
+          - ignore: true
+            operation: ReadOne
       Layers:
         set:
           - method: Create

generator.yaml

@@ -18,6 +18,9 @@ resources:
       Code:
         compare:
           is_ignored: true
+        set:
+          - ignore: true
+            operation: ReadOne
       Layers:
         set:
           - method: Create

pkg/resource/function/sdk.go

@@ -1,3 +1,11 @@
+	if resp.Code != nil {
+		// We need to keep the desired .Code s3Bucket s3Key and s3ObjectVersion 
+		// part of the function's spec. So instead of setting Spec.Code to nil
+		// we only set ImageURI
+		if resp.Code.ImageUri != nil {
+			ko.Spec.Code.ImageURI = resp.Code.ImageUri
+		}
+	}
 	if resp.Configuration.CodeSha256 != nil {
 		ko.Status.CodeSHA256 = resp.Configuration.CodeSha256
 	} else {

templates/hooks/function/sdk_read_one_post_set_output.go.tpl

@@ -120,6 +120,11 @@ def test_smoke(self, lambda_client):
 
         lambda_validator = LambdaValidator(lambda_client)
 
+        # Assert that the original code.s3Bucket and code.s3Key is still part of
+        # the function's CR
+        assert cr["spec"]["code"]["s3Bucket"] == resources.FunctionsBucket.name
+        assert cr["spec"]["code"]["s3Key"] == LAMBDA_FUNCTION_FILE_ZIP
+
         # Check Lambda function exists
         assert lambda_validator.function_exists(resource_name)