Fix PreferredBackupWindow not updating (#226)

Issue #, if available: [2512](aws-controllers-k8s/community#2512)

Description of changes:
- Fix type in delta check in newCustomUpdateRequestPayload()
- Add test verifying PreferredBackupkWindow is correctly included in update input
- Add .vscode to .gitignore

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: knottnt

.gitignore

@@ -2,6 +2,7 @@
 *.swp
 *~
 .idea
+.vscode
 /docs/site
 bin
 build

go.mod

@@ -15,6 +15,7 @@ require (
 	github.com/go-logr/logr v1.4.2
 	github.com/samber/lo v1.37.0
 	github.com/spf13/pflag v1.0.5
+	github.com/stretchr/testify v1.9.0
 	k8s.io/api v0.32.1
 	k8s.io/apimachinery v0.32.1
 	k8s.io/client-go v0.32.1
@@ -63,6 +64,7 @@ require (
 	github.com/modern-go/reflect2 v1.0.2 // indirect
 	github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
 	github.com/pkg/errors v0.9.1 // indirect
+	github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
 	github.com/prometheus/client_golang v1.19.1 // indirect
 	github.com/prometheus/client_model v0.6.1 // indirect
 	github.com/prometheus/common v0.55.0 // indirect

pkg/resource/db_cluster/custom_update.go

@@ -572,7 +572,7 @@ func (rm *resourceManager) newCustomUpdateRequestPayload(
 	if desired.ko.Spec.Port != nil && delta.DifferentAt("Spec.Port") {
 		res.Port = aws.Int32(int32(*desired.ko.Spec.Port))
 	}
-	if desired.ko.Spec.PreferredBackupWindow != nil && delta.DifferentAt("Spec.PreferredBackupkWindow") {
+	if desired.ko.Spec.PreferredBackupWindow != nil && delta.DifferentAt("Spec.PreferredBackupWindow") {
 		res.PreferredBackupWindow = desired.ko.Spec.PreferredBackupWindow
 	}
 	if desired.ko.Spec.PreferredMaintenanceWindow != nil && delta.DifferentAt("Spec.PreferredMaintenanceWindow") {

pkg/resource/db_cluster/custom_update_test.go

@@ -0,0 +1,106 @@
+// Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License"). You may
+// not use this file except in compliance with the License. A copy of the
+// License is located at
+//
+//     http://aws.amazon.com/apache2.0/
+//
+// or in the "license" file accompanying this file. This file is distributed
+// on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+// express or implied. See the License for the specific language governing
+// permissions and limitations under the License.
+
+package db_cluster
+
+import (
+	"context"
+	"testing"
+
+	ackcompare "github.com/aws-controllers-k8s/runtime/pkg/compare"
+	"github.com/aws/aws-sdk-go-v2/aws"
+	"github.com/stretchr/testify/assert"
+
+	svcapitypes "github.com/aws-controllers-k8s/rds-controller/apis/v1alpha1"
+)
+
+func TestNewCustomUpdateRequestPayload_PreferredBackupWindow(t *testing.T) {
+	// Test case to verify that PreferredBackupWindow is included in the ModifyDBCluster API call
+	// when Spec.PreferredBackupWindow is in the delta
+
+	// Setup
+	rm := &resourceManager{}
+	ctx := context.Background()
+
+	// Create desired resource with PreferredBackupWindow set
+	desired := &resource{
+		ko: &svcapitypes.DBCluster{
+			Spec: svcapitypes.DBClusterSpec{
+				DBClusterIdentifier:   aws.String("test-cluster"),
+				PreferredBackupWindow: aws.String("07:00-09:00"),
+			},
+		},
+	}
+
+	// Create latest resource with different PreferredBackupWindow
+	latest := &resource{
+		ko: &svcapitypes.DBCluster{
+			Spec: svcapitypes.DBClusterSpec{
+				DBClusterIdentifier:   aws.String("test-cluster"),
+				PreferredBackupWindow: aws.String("05:00-07:00"),
+			},
+		},
+	}
+
+	// Create delta with PreferredBackupWindow difference
+	delta := ackcompare.NewDelta()
+	delta.Add("Spec.PreferredBackupWindow", latest.ko.Spec.PreferredBackupWindow, desired.ko.Spec.PreferredBackupWindow)
+
+	// Call the function under test
+	input, err := rm.newCustomUpdateRequestPayload(ctx, desired, latest, delta)
+
+	// Assertions
+	assert.NoError(t, err)
+	assert.NotNil(t, input)
+	assert.Equal(t, *desired.ko.Spec.PreferredBackupWindow, *input.PreferredBackupWindow)
+}
+
+func TestNewCustomUpdateRequestPayload_PreferredBackupWindowNotInDelta(t *testing.T) {
+	// Test case to verify that PreferredBackupWindow is NOT included in the ModifyDBCluster API call
+	// when Spec.PreferredBackupWindow is NOT in the delta
+
+	// Setup
+	rm := &resourceManager{}
+	ctx := context.Background()
+
+	// Create desired resource with PreferredBackupWindow set
+	desired := &resource{
+		ko: &svcapitypes.DBCluster{
+			Spec: svcapitypes.DBClusterSpec{
+				DBClusterIdentifier:   aws.String("test-cluster"),
+				PreferredBackupWindow: aws.String("07:00-09:00"),
+			},
+		},
+	}
+
+	// Create latest resource with same PreferredBackupWindow
+	latest := &resource{
+		ko: &svcapitypes.DBCluster{
+			Spec: svcapitypes.DBClusterSpec{
+				DBClusterIdentifier:   aws.String("test-cluster"),
+				PreferredBackupWindow: aws.String("07:00-09:00"),
+			},
+		},
+	}
+
+	// Create delta without PreferredBackupWindow difference
+	delta := ackcompare.NewDelta()
+
+	// Call the function under test
+	input, err := rm.newCustomUpdateRequestPayload(ctx, desired, latest, delta)
+
+	// Assertions
+	assert.NoError(t, err)
+	assert.NotNil(t, input)
+	assert.Nil(t, input.PreferredBackupWindow)
+}