Skip to content

Commit 0cf63b7

Browse files
authored
Remove DBSecurityGroup CRD from rds-controller (#80)
Issue #, if available: [issue-1290](aws-controllers-k8s/community#1290) Description of changes: Since now all new RDS db instances are VPC instances, there is no need to still leave CRD DBSecurityGroup open. Now RDS db instances are using VPC security group. (According to https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_CreateDBSecurityGroup.html ) Remove DBSecurityGroup CRD from rds-controller. Also remove the db_security_group e2e test. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 85009ce commit 0cf63b7

32 files changed

+694
-2948
lines changed
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
ack_generate_info:
2-
build_date: "2022-05-27T18:41:36Z"
2+
build_date: "2022-06-02T18:10:06Z"
33
build_hash: 6acf40fe3e3cfd97b799ef7cbf1e89e01c3db8f7
44
go_version: go1.18.2
55
version: v0.18.4-15-g6acf40f
6-
api_directory_checksum: 68d22d197b3187ea9f81567aca22f0a95ceaf00a
6+
api_directory_checksum: f8a740e73423e911df6a1b5fbcb9fbbb03cd9899
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.42.0
99
generator_config_info:
10-
file_checksum: 89eb9928dcfbe0af48b80281c4fbe934cd7ddb23
10+
file_checksum: c9f1d6ca4596ac8e84312495f50a8b901843744f
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation

apis/v1alpha1/db_instance.go

Lines changed: 0 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/v1alpha1/db_security_group.go

Lines changed: 0 additions & 100 deletions
This file was deleted.

apis/v1alpha1/generator.yaml

Lines changed: 3 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,15 @@ ignore:
1111
#- DBParameterGroup
1212
- DBProxy
1313
- DBProxyEndpoint
14-
#- DBSecurityGroup
14+
- DBSecurityGroup
1515
- DBSnapshot
1616
#- DBSubnetGroup
1717
- EventSubscription
1818
#- GlobalCluster
1919
- OptionGroup
2020
field_paths:
21+
- CreateDBInstanceInput.DBSecurityGroups
22+
- DBInstance.DBSecurityGroups
2123
operations:
2224
ModifyDBCluster:
2325
override_values:
@@ -154,7 +156,6 @@ resources:
154156
- InvalidParameter
155157
- InvalidParameterValue
156158
- InvalidParameterCombination
157-
- DBSecurityGroupNotFound
158159
- DBSubnetGroupNotFoundFault
159160
- DBParameterGroupNotFound
160161
fields:
@@ -163,19 +164,6 @@ resources:
163164
is_immutable: true
164165
DBInstanceIdentifier:
165166
is_primary_key: true
166-
# Because the Create input and Create/Update/ReadOne output shapes for
167-
# the DBSecurityGroups field have different Go types, we are instructing
168-
# the code generator to set the Spec.DBSecurityGroups field (which is a
169-
# []string field) to the set of DBSecurityGroups..DBSecurityGroupName
170-
# values in the ReadOne method's Output shape.
171-
DBSecurityGroups:
172-
set:
173-
- method: Update
174-
from: DBSecurityGroupName
175-
- method: Create
176-
from: DBSecurityGroupName
177-
- method: ReadOne
178-
from: DBSecurityGroupName
179167
MasterUserPassword:
180168
is_secret: true
181169
KmsKeyId:
@@ -237,22 +225,6 @@ resources:
237225
from:
238226
operation: ModifyDBParameterGroup
239227
path: Parameters
240-
DBSecurityGroup:
241-
renames:
242-
operations:
243-
DescribeDBSecurityGroups:
244-
input_fields:
245-
DBSecurityGroupName: Name
246-
CreateDBSecurityGroup:
247-
input_fields:
248-
DBSecurityGroupName: Name
249-
DBSecurityGroupDescription: Description
250-
DeleteDBSecurityGroup:
251-
input_fields:
252-
DBSecurityGroupName: Name
253-
fields:
254-
Name:
255-
is_primary_key: true
256228
DBSubnetGroup:
257229
renames:
258230
operations:

apis/v1alpha1/types.go

Lines changed: 12 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)