fix: ignore setting sdkUpdate output into DBInstance spec (#221)

Issue [#2086](aws-controllers-k8s/community#2086), [#2123](aws-controllers-k8s/community#2123)

Description of changes:
When we make a ModifyDBInstance call, the output returned is outdated. 
Currently we've been relying on `pendingModifiedValues` to return the 
desired field values, but based on the logs, pendingModifiedValues is not 
a reliable source.

These changes ignore the sdkUpdate output spec completely, and only patch the status.

One more change here is adding support of late initializing PerformanceInsightsKMSKeyID and PerformanceInsightsRetentionPeriod fields only when PerformanceInsights is enabled.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: michaelhtm

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2025-07-22T22:12:13Z"
+  build_date: "2025-07-23T17:40:52Z"
   build_hash: b2dc0f44e0b08f041de14c3944a5cc005ba97c8f
-  go_version: go1.24.5
+  go_version: go1.24.4
   version: v0.50.0
 api_directory_checksum: 52968d74358773de28be65be320d1bfb9c91e0bf
 api_version: v1alpha1
 aws_sdk_go_version: v1.32.6
 generator_config_info:
-  file_checksum: ced2b68c703e2daf7b04da8f84f6ad6c95114fb9
+  file_checksum: c2e5556f70b93834cadb221ec373fa29d6c1692b
   original_file_name: generator.yaml
 last_modification:
   reason: API generation

apis/v1alpha1/generator.yaml

@@ -308,8 +308,8 @@ resources:
         template_path: hooks/db_instance/sdk_update_pre_build_request.go.tpl
       sdk_update_post_build_request:
         template_path: hooks/db_instance/sdk_update_post_build_request.go.tpl
-      sdk_update_post_set_output:
-        template_path: hooks/db_instance/sdk_update_post_set_output.go.tpl
+      sdk_update_pre_set_output:
+        template_path: hooks/db_instance/sdk_update_pre_set_output.go.tpl
       sdk_delete_pre_build_request:
         template_path: hooks/db_instance/sdk_delete_pre_build_request.go.tpl
       sdk_delete_post_build_request:
@@ -332,7 +332,7 @@ resources:
           name: "STATUS"
       MasterUserPassword:
         is_secret: true
-      KmsKeyId:
+      KMSKeyId:
         references:
           resource: Key
           service_name: kms
@@ -395,6 +395,12 @@ resources:
         from:
           operation: CreateDBInstanceReadReplica
           path: PreSignedUrl
+      PerformanceInsightsKMSKeyID:
+        late_initialize:
+          skip_incomplete_check: {}
+      PerformanceInsightsRetentionPeriod:
+        late_initialize:
+          skip_incomplete_check: {}
       Tags:
         compare:
           # We have a custom comparison function...

generator.yaml

@@ -308,8 +308,8 @@ resources:
         template_path: hooks/db_instance/sdk_update_pre_build_request.go.tpl
       sdk_update_post_build_request:
         template_path: hooks/db_instance/sdk_update_post_build_request.go.tpl
-      sdk_update_post_set_output:
-        template_path: hooks/db_instance/sdk_update_post_set_output.go.tpl
+      sdk_update_pre_set_output:
+        template_path: hooks/db_instance/sdk_update_pre_set_output.go.tpl
       sdk_delete_pre_build_request:
         template_path: hooks/db_instance/sdk_delete_pre_build_request.go.tpl
       sdk_delete_post_build_request:
@@ -332,7 +332,7 @@ resources:
           name: "STATUS"
       MasterUserPassword:
         is_secret: true
-      KmsKeyId:
+      KMSKeyId:
         references:
           resource: Key
           service_name: kms
@@ -395,6 +395,12 @@ resources:
         from:
           operation: CreateDBInstanceReadReplica
           path: PreSignedUrl
+      PerformanceInsightsKMSKeyID:
+        late_initialize:
+          skip_incomplete_check: {}
+      PerformanceInsightsRetentionPeriod:
+        late_initialize:
+          skip_incomplete_check: {}
       Tags:
         compare:
           # We have a custom comparison function...

pkg/resource/db_instance/delta.go

@@ -19,14 +19,9 @@
 		*b.ko.Spec.NetworkType == ServiceDefaultNetworkType {
 		a.ko.Spec.NetworkType = b.ko.Spec.NetworkType
 	}
-	if a.ko.Spec.PerformanceInsightsRetentionPeriod == nil &&
-		b.ko.Spec.PerformanceInsightsRetentionPeriod != nil &&
-		*b.ko.Spec.PerformanceInsightsRetentionPeriod == ServiceDefaultInsightsRetentionPeriod {
-		a.ko.Spec.PerformanceInsightsRetentionPeriod = b.ko.Spec.PerformanceInsightsRetentionPeriod
-	}
-	if a.ko.Spec.PerformanceInsightsKMSKeyID == nil &&
-		b.ko.Spec.PerformanceInsightsKMSKeyID != nil {
-		a.ko.Spec.PerformanceInsightsKMSKeyID = b.ko.Spec.PerformanceInsightsKMSKeyID
+	if a.ko.Spec.PerformanceInsightsEnabled == nil &&
+		b.ko.Spec.PerformanceInsightsEnabled != nil {
+		a.ko.Spec.PerformanceInsightsEnabled = func() *bool {a := false; return &a }()
 	}
 
 	// RDS will choose preferred engine minor version if only