Copy the parameter groups from status into spec (#141)

Issue aws-controllers-k8s/community#1744, if available:

**Description of changes:**
Copying the the parameter group fields from the status into the spec so that the controller can correctly determine that there is a difference between the latest and desired. This affects both type `DBCluster` and `DBInstance`.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: mustafasencer

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2023-03-13T17:16:37Z"
+  build_date: "2023-03-22T13:24:48Z"
   build_hash: 338374e45678067e238b3991b8c15a4dd0b65c8e
   go_version: go1.19.1
-  version: v0.24.3-2-g338374e
-api_directory_checksum: 902e18c1b127f207d065ac0dcc81db3443da4765
+  version: v0.24.3-2-g338374e-dirty
+api_directory_checksum: 249bb23477dbb69a88064ea191a078f41f4966d0
 api_version: v1alpha1
 aws_sdk_go_version: v1.44.93
 generator_config_info:
-  file_checksum: fff3f61faf773d9fc572f9ba2aabe69805b0f642
+  file_checksum: b25db005880b617bda699d2a80b7a6bba0144ba4
   original_file_name: generator.yaml
 last_modification:
   reason: API generation

helm/crds/services.k8s.aws_adoptedresources.yaml

@@ -145,7 +145,10 @@ spec:
                             blockOwnerDeletion:
                               description: If true, AND if the owner has the "foregroundDeletion"
                                 finalizer, then the owner cannot be deleted from the
-                                key-value store until this reference is removed. Defaults
+                                key-value store until this reference is removed. See
+                                https://kubernetes.io/docs/concepts/architecture/garbage-collection/#foreground-deletion
+                                for how the garbage collector interacts with this
+                                field and enforces the foreground deletion. Defaults
                                 to false. To set this field, a user needs "delete"
                                 permission of the owner, otherwise 422 (Unprocessable
                                 Entity) will be returned.

pkg/resource/db_cluster/custom_update.go

@@ -40,6 +40,7 @@ func (rm *resourceManager) customUpdate(
 	rlog := ackrtlog.FromContext(ctx)
 	exit := rlog.Trace("rm.customUpdate")
 	defer exit(err)
+
 	if clusterDeleting(latest) {
 		msg := "DB cluster is currently being deleted"
 		ackcondition.SetSynced(desired, corev1.ConditionFalse, &msg, nil)
@@ -70,6 +71,7 @@ func (rm *resourceManager) customUpdate(
 	var resp *svcsdk.ModifyDBClusterOutput
 	_ = resp
 	resp, err = rm.sdkapi.ModifyDBClusterWithContext(ctx, input)
+
 	rm.metrics.RecordAPICall("UPDATE", "ModifyDBCluster", err)
 	if err != nil {
 		return nil, err

pkg/resource/db_cluster/sdk.go

@@ -56,7 +56,7 @@ func NewErrUnmodifiableParameter(name string) error {
 // the parameters to remove
 func GetParametersDifference(
 	to, from Parameters,
-	) (added, unchanged, removed Parameters) {
+) (added, unchanged, removed Parameters) {
 	// we need to convert the tag tuples to a comparable interface type
 	fromPairs := lo.ToPairs(from)
 	toPairs := lo.ToPairs(to)

pkg/resource/db_instance/sdk.go

@@ -25,3 +25,8 @@
 		}
 		ko.Spec.VPCSecurityGroupIDs = sgIDs
 	}
+	if r.ko.Spec.DBClusterParameterGroupName != nil {
+		// If the desired resource has db cluster parameter group name specified then update the spec of the latest 
+		// resource with the value from the status.
+		ko.Spec.DBClusterParameterGroupName = ko.Status.DBClusterParameterGroup
+	}

pkg/util/parameters.go

@@ -23,3 +23,10 @@
 		}
 		ko.Spec.VPCSecurityGroupIDs = sgIDs
 	}
+	if r.ko.Spec.DBParameterGroupName != nil {
+		// If the desired resource has db parameter group name specified then update the spec of the latest 
+		// resource with the value from the status.
+		if len(ko.Status.DBParameterGroups) > 0 {
+			ko.Spec.DBParameterGroupName = ko.Status.DBParameterGroups[0].DBParameterGroupName
+		}
+	}