Skip to content

Commit 712a5b9

Browse files
authored
Remove DBParameterGroupNotFound and DBSubnetGroupNotFoundFault from terminal exception (#88)
Remove DBParameterGroupNotFound and DBSubnetGroupNotFoundFault from terminal exception Issue #, if available: aws-controllers-k8s/community#1257 Description of changes: Since `DBParameterGroup` and `DBSubnetGroup` are resource can be created by controller, controller should retry create `dbinstance/dbcluster` when these resource are created and available in k8s. Remove them from terminal code so controller can keep retrying. Tested by create instance with new db subnet group/param group, and validated controller keep retrying creating and create successfully when new subnet group/param group created in k8s. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 458748d commit 712a5b9

File tree

5 files changed

+3
-21
lines changed

5 files changed

+3
-21
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
ack_generate_info:
2-
build_date: "2022-06-13T22:52:20Z"
2+
build_date: "2022-06-15T18:55:14Z"
33
build_hash: 6acf40fe3e3cfd97b799ef7cbf1e89e01c3db8f7
44
go_version: go1.18.2
55
version: v0.18.4-15-g6acf40f
66
api_directory_checksum: 4bdcfc19ab3ec6ae11525e6eb3a201e4a25b00fa
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.42.0
99
generator_config_info:
10-
file_checksum: a014f16db9e990ad756052e50cbce7d0d9b84c0b
10+
file_checksum: 3ff30261a7e6e7df5e498e37acf114f3c121173a
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation

apis/v1alpha1/generator.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -90,16 +90,12 @@ resources:
9090
exceptions:
9191
terminal_codes:
9292
- DBClusterQuotaExceededFault
93-
- DBParameterGroupNotFound
94-
- DBSubnetGroupNotFoundFault
9593
- DBSubnetGroupDoesNotCoverEnoughAZs
96-
- DomainNotFoundFault
9794
- InsufficientStorageClusterCapacity
9895
- InvalidParameter
9996
- InvalidParameterValue
10097
- InvalidParameterCombination
10198
- InvalidSubnet
102-
- KMSKeyNotAccessibleFault
10399
- StorageQuotaExceeded
104100
fields:
105101
DBClusterIdentifier:
@@ -166,8 +162,6 @@ resources:
166162
- InvalidParameter
167163
- InvalidParameterValue
168164
- InvalidParameterCombination
169-
- DBSubnetGroupNotFoundFault
170-
- DBParameterGroupNotFound
171165
fields:
172166
AvailabilityZone:
173167
late_initialize: {}

generator.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -90,16 +90,12 @@ resources:
9090
exceptions:
9191
terminal_codes:
9292
- DBClusterQuotaExceededFault
93-
- DBParameterGroupNotFound
94-
- DBSubnetGroupNotFoundFault
9593
- DBSubnetGroupDoesNotCoverEnoughAZs
96-
- DomainNotFoundFault
9794
- InsufficientStorageClusterCapacity
9895
- InvalidParameter
9996
- InvalidParameterValue
10097
- InvalidParameterCombination
10198
- InvalidSubnet
102-
- KMSKeyNotAccessibleFault
10399
- StorageQuotaExceeded
104100
fields:
105101
DBClusterIdentifier:
@@ -166,8 +162,6 @@ resources:
166162
- InvalidParameter
167163
- InvalidParameterValue
168164
- InvalidParameterCombination
169-
- DBSubnetGroupNotFoundFault
170-
- DBParameterGroupNotFound
171165
fields:
172166
AvailabilityZone:
173167
late_initialize: {}

pkg/resource/db_cluster/sdk.go

Lines changed: 0 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/resource/db_instance/sdk.go

Lines changed: 1 addition & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)