Rename EnablePerformanceInsights to PerformanceInsightsEnabled for CreateDBInstance and ModifyDBInstance api (#77)

Fixes aws-controllers-k8s/community#1251

Rename EnablePerformanceInsights to PerformanceInsightsEnabled for RDS API CreateDBInstance and ModifyDBInstance to avoid conflict with DecribeDBInstance PerformanceInsightsEnabled status

Description of changes:

Rename EnablePerformanceInsights to PerformanceInsightsEnabled for RDS API CreateDBInstance and ModifyDBInstance to avoid conflict with DecribeDBInstance PerformanceInsightsEnabled status

1. make the change in generator.yaml file to rename EnablePerformanceInsights to PerformanceInsightsEnabled
2. run existing rds controller test and passed 

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: brucegucode

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2022-05-11T16:29:30Z"
-  build_hash: c6efa6ac643edb21219e0763541b2558718b5fe6
-  go_version: go1.18.1
-  version: v0.18.4-10-gc6efa6a
-api_directory_checksum: e7bbd21f4f975f9cf1e1e804ebd450e8e310023d
+  build_date: "2022-05-18T21:18:00Z"
+  build_hash: c651d2bb60694df1f7a5dad823258472a1a6fc8a
+  go_version: go1.18.2
+  version: v0.18.4-12-gc651d2b
+api_directory_checksum: 932f41dc8e3c84de66ba73cde9eecc2b94c847f3
 api_version: v1alpha1
 aws_sdk_go_version: v1.42.0
 generator_config_info:
-  file_checksum: 977d8d553f526f7d5b76d8ea9d82e5798de16e39
+  file_checksum: 6f5ece4103c904b1e0417e817cdc437743a85fb3
   original_file_name: generator.yaml
 last_modification:
   reason: API generation

apis/v1alpha1/db_instance.go

@@ -178,6 +178,14 @@ resources:
           resource: Key
           service_name: kms
           path: Status.ACKResourceMetadata.ARN
+    renames:
+      operations:
+        CreateDBInstance:
+          input_fields:
+            EnablePerformanceInsights: PerformanceInsightsEnabled
+        ModifyDBInstance:
+          input_fields:
+            EnablePerformanceInsights: PerformanceInsightsEnabled
   GlobalCluster:
     exceptions:
       terminal_codes:

apis/v1alpha1/generator.yaml

@@ -284,13 +284,6 @@ spec:
                   for MySQL and PostgreSQL (https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/UsingWithRDS.IAMDBAuth.html)
                   in the Amazon RDS User Guide."
                 type: boolean
-              enablePerformanceInsights:
-                description: "A value that indicates whether to enable Performance
-                  Insights for the DB instance. For more information, see Using Amazon
-                  Performance Insights (https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_PerfInsights.html)
-                  in the Amazon Relational Database Service User Guide. \n This setting
-                  doesn't apply to RDS Custom."
-                type: boolean
               engine:
                 description: "The name of the database engine to be used for this
                   instance. \n Not every database engine is available for every Amazon
@@ -468,6 +461,13 @@ spec:
                   from a DB instance after it is associated with a DB instance. \n
                   This setting doesn't apply to RDS Custom."
                 type: string
+              performanceInsightsEnabled:
+                description: "A value that indicates whether to enable Performance
+                  Insights for the DB instance. For more information, see Using Amazon
+                  Performance Insights (https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_PerfInsights.html)
+                  in the Amazon Relational Database Service User Guide. \n This setting
+                  doesn't apply to RDS Custom."
+                type: boolean
               performanceInsightsKMSKeyID:
                 description: "The Amazon Web Services KMS key identifier for encryption
                   of Performance Insights data. \n The Amazon Web Services KMS key
@@ -1035,10 +1035,6 @@ spec:
                   storageType:
                     type: string
                 type: object
-              performanceInsightsEnabled:
-                description: True if Performance Insights is enabled for the DB instance,
-                  and otherwise false.
-                type: boolean
               readReplicaDBClusterIdentifiers:
                 description: "Contains one or more identifiers of Aurora DB clusters
                   to which the RDS DB instance is replicated as a read replica. For

apis/v1alpha1/zz_generated.deepcopy.go

@@ -178,6 +178,14 @@ resources:
           resource: Key
           service_name: kms
           path: Status.ACKResourceMetadata.ARN
+    renames:
+      operations:
+        CreateDBInstance:
+          input_fields:
+            EnablePerformanceInsights: PerformanceInsightsEnabled
+        ModifyDBInstance:
+          input_fields:
+            EnablePerformanceInsights: PerformanceInsightsEnabled
   GlobalCluster:
     exceptions:
       terminal_codes:

config/crd/bases/rds.services.k8s.aws_dbinstances.yaml

@@ -284,13 +284,6 @@ spec:
                   for MySQL and PostgreSQL (https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/UsingWithRDS.IAMDBAuth.html)
                   in the Amazon RDS User Guide."
                 type: boolean
-              enablePerformanceInsights:
-                description: "A value that indicates whether to enable Performance
-                  Insights for the DB instance. For more information, see Using Amazon
-                  Performance Insights (https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_PerfInsights.html)
-                  in the Amazon Relational Database Service User Guide. \n This setting
-                  doesn't apply to RDS Custom."
-                type: boolean
               engine:
                 description: "The name of the database engine to be used for this
                   instance. \n Not every database engine is available for every Amazon
@@ -468,6 +461,13 @@ spec:
                   from a DB instance after it is associated with a DB instance. \n
                   This setting doesn't apply to RDS Custom."
                 type: string
+              performanceInsightsEnabled:
+                description: "A value that indicates whether to enable Performance
+                  Insights for the DB instance. For more information, see Using Amazon
+                  Performance Insights (https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_PerfInsights.html)
+                  in the Amazon Relational Database Service User Guide. \n This setting
+                  doesn't apply to RDS Custom."
+                type: boolean
               performanceInsightsKMSKeyID:
                 description: "The Amazon Web Services KMS key identifier for encryption
                   of Performance Insights data. \n The Amazon Web Services KMS key
@@ -1035,10 +1035,6 @@ spec:
                   storageType:
                     type: string
                 type: object
-              performanceInsightsEnabled:
-                description: True if Performance Insights is enabled for the DB instance,
-                  and otherwise false.
-                type: boolean
               readReplicaDBClusterIdentifiers:
                 description: "Contains one or more identifiers of Aurora DB clusters
                   to which the RDS DB instance is replicated as a read replica. For