support overriding parameter values on param group

Adds code to allow a user to specify a set of parameter override values
for a DB parameter group.

The `Spec.ParameterOverrides` is a `map[string]*string` containing the
parameter names and values for parameters in a DB parameter group that
the user wishes to override from their defaults.

The `Status.ParameterOverrideStatuses` field is a slice of `Parameter`
structs that contains more "status-y" information about those overridden
parameters.

Still yet to work out is how I'm going to keep track of which parameters
for which DB engine family can have ApplyMethod=intermediate and which
ones must have ApplyMethod=pending-reboot.

Signed-off-by: Jay Pipes <[email protected]>

Author: jaypipes

apis/v1alpha1/ack-generate-metadata.yaml

@@ -3,11 +3,11 @@ ack_generate_info:
   build_hash: fe61d04673fd4d9848d5f726b01e0689a16d3733
   go_version: go1.18.2
   version: v0.19.3-1-gfe61d04
-api_directory_checksum: 6a967cc8a62d521d4f4816dbccc48f81d0cb271d
+api_directory_checksum: 420612ef2bc7cf0b19ebe41c44626560e060c4a1
 api_version: v1alpha1
 aws_sdk_go_version: v1.44.27
 generator_config_info:
-  file_checksum: 48d8a87d42545d99ddabf9bea4ab180e08ab79b7
+  file_checksum: 90a2d0d868a32e6474738ad70a557035f490780a
   original_file_name: generator.yaml
 last_modification:
   reason: API generation

apis/v1alpha1/db_parameter_group.go

@@ -322,14 +322,27 @@ resources:
     fields:
       Name:
         is_primary_key: true
-      Parameters:
-        from:
-          operation: ModifyDBParameterGroup
-          path: Parameters
+      # These are ONLY user-defined parameter overrides for the DB parameter
+      # group. This does not contain default or system parameters.
+      ParameterOverrides:
+        custom_field:
+          # The type is a map[string]string where the map keys are the
+          # parameter name and the values are the parameter value. We
+          # automatically determine the "apply method" for parameters so all
+          # the user needs to do is specify the parameter name and value they
+          # want to override...
+          map_of: String
       Tags:
         compare:
           # We have a custom comparison function...
           is_ignored: true
+      # These are the "statuses" for the user-defined parameter overrides in
+      # Spec.ParameterOverrides
+      ParameterOverrideStatuses:
+        from:
+          operation: DescribeDBParameters
+          path: Parameters
+        is_read_only: true
   DBSubnetGroup:
     renames:
       operations:

apis/v1alpha1/generator.yaml

@@ -67,56 +67,10 @@ spec:
                   character must be a letter \n    * Can't end with a hyphen or contain
                   two consecutive hyphens \n This value is stored as a lowercase string."
                 type: string
-              parameters:
-                description: "An array of parameter names, values, and the application
-                  methods for the parameter update. At least one parameter name, value,
-                  and application method must be supplied; later arguments are optional.
-                  A maximum of 20 parameters can be modified in a single request.
-                  \n Valid Values (for the application method): immediate | pending-reboot
-                  \n You can use the immediate value with dynamic parameters only.
-                  You can use the pending-reboot value for both dynamic and static
-                  parameters. \n When the application method is immediate, changes
-                  to dynamic parameters are applied immediately to the DB instances
-                  associated with the parameter group. \n When the application method
-                  is pending-reboot, changes to dynamic and static parameters are
-                  applied after a reboot without failover to the DB instances associated
-                  with the parameter group. \n You can't use pending-reboot with dynamic
-                  parameters on RDS for SQL Server DB instances. Use immediate. \n
-                  For more information on modifying DB parameters, see Working with
-                  DB parameter groups (https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_WorkingWithParamGroups.html)
-                  in the Amazon RDS User Guide."
-                items:
-                  description: "This data type is used as a request parameter in the
-                    ModifyDBParameterGroup and ResetDBParameterGroup actions. \n This
-                    data type is used as a response element in the DescribeEngineDefaultParameters
-                    and DescribeDBParameters actions."
-                  properties:
-                    allowedValues:
-                      type: string
-                    applyMethod:
-                      type: string
-                    applyType:
-                      type: string
-                    dataType:
-                      type: string
-                    description:
-                      type: string
-                    isModifiable:
-                      type: boolean
-                    minimumEngineVersion:
-                      type: string
-                    parameterName:
-                      type: string
-                    parameterValue:
-                      type: string
-                    source:
-                      type: string
-                    supportedEngineModes:
-                      items:
-                        type: string
-                      type: array
-                  type: object
-                type: array
+              parameterOverrides:
+                additionalProperties:
+                  type: string
+                type: object
               tags:
                 description: Tags to assign to the DB parameter group.
                 items:
@@ -198,6 +152,40 @@ spec:
                   - type
                   type: object
                 type: array
+              parameterOverrideStatuses:
+                description: A list of Parameter values.
+                items:
+                  description: "This data type is used as a request parameter in the
+                    ModifyDBParameterGroup and ResetDBParameterGroup actions. \n This
+                    data type is used as a response element in the DescribeEngineDefaultParameters
+                    and DescribeDBParameters actions."
+                  properties:
+                    allowedValues:
+                      type: string
+                    applyMethod:
+                      type: string
+                    applyType:
+                      type: string
+                    dataType:
+                      type: string
+                    description:
+                      type: string
+                    isModifiable:
+                      type: boolean
+                    minimumEngineVersion:
+                      type: string
+                    parameterName:
+                      type: string
+                    parameterValue:
+                      type: string
+                    source:
+                      type: string
+                    supportedEngineModes:
+                      items:
+                        type: string
+                      type: array
+                  type: object
+                type: array
             type: object
         type: object
     served: true

apis/v1alpha1/zz_generated.deepcopy.go

@@ -322,14 +322,27 @@ resources:
     fields:
       Name:
         is_primary_key: true
-      Parameters:
-        from:
-          operation: ModifyDBParameterGroup
-          path: Parameters
+      # These are ONLY user-defined parameter overrides for the DB parameter
+      # group. This does not contain default or system parameters.
+      ParameterOverrides:
+        custom_field:
+          # The type is a map[string]string where the map keys are the
+          # parameter name and the values are the parameter value. We
+          # automatically determine the "apply method" for parameters so all
+          # the user needs to do is specify the parameter name and value they
+          # want to override...
+          map_of: String
       Tags:
         compare:
           # We have a custom comparison function...
           is_ignored: true
+      # These are the "statuses" for the user-defined parameter overrides in
+      # Spec.ParameterOverrides
+      ParameterOverrideStatuses:
+        from:
+          operation: DescribeDBParameters
+          path: Parameters
+        is_read_only: true
   DBSubnetGroup:
     renames:
       operations:

config/crd/bases/rds.services.k8s.aws_dbparametergroups.yaml

@@ -67,56 +67,10 @@ spec:
                   character must be a letter \n    * Can't end with a hyphen or contain
                   two consecutive hyphens \n This value is stored as a lowercase string."
                 type: string
-              parameters:
-                description: "An array of parameter names, values, and the application
-                  methods for the parameter update. At least one parameter name, value,
-                  and application method must be supplied; later arguments are optional.
-                  A maximum of 20 parameters can be modified in a single request.
-                  \n Valid Values (for the application method): immediate | pending-reboot
-                  \n You can use the immediate value with dynamic parameters only.
-                  You can use the pending-reboot value for both dynamic and static
-                  parameters. \n When the application method is immediate, changes
-                  to dynamic parameters are applied immediately to the DB instances
-                  associated with the parameter group. \n When the application method
-                  is pending-reboot, changes to dynamic and static parameters are
-                  applied after a reboot without failover to the DB instances associated
-                  with the parameter group. \n You can't use pending-reboot with dynamic
-                  parameters on RDS for SQL Server DB instances. Use immediate. \n
-                  For more information on modifying DB parameters, see Working with
-                  DB parameter groups (https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_WorkingWithParamGroups.html)
-                  in the Amazon RDS User Guide."
-                items:
-                  description: "This data type is used as a request parameter in the
-                    ModifyDBParameterGroup and ResetDBParameterGroup actions. \n This
-                    data type is used as a response element in the DescribeEngineDefaultParameters
-                    and DescribeDBParameters actions."
-                  properties:
-                    allowedValues:
-                      type: string
-                    applyMethod:
-                      type: string
-                    applyType:
-                      type: string
-                    dataType:
-                      type: string
-                    description:
-                      type: string
-                    isModifiable:
-                      type: boolean
-                    minimumEngineVersion:
-                      type: string
-                    parameterName:
-                      type: string
-                    parameterValue:
-                      type: string
-                    source:
-                      type: string
-                    supportedEngineModes:
-                      items:
-                        type: string
-                      type: array
-                  type: object
-                type: array
+              parameterOverrides:
+                additionalProperties:
+                  type: string
+                type: object
               tags:
                 description: Tags to assign to the DB parameter group.
                 items:
@@ -198,6 +152,40 @@ spec:
                   - type
                   type: object
                 type: array
+              parameterOverrideStatuses:
+                description: A list of Parameter values.
+                items:
+                  description: "This data type is used as a request parameter in the
+                    ModifyDBParameterGroup and ResetDBParameterGroup actions. \n This
+                    data type is used as a response element in the DescribeEngineDefaultParameters
+                    and DescribeDBParameters actions."
+                  properties:
+                    allowedValues:
+                      type: string
+                    applyMethod:
+                      type: string
+                    applyType:
+                      type: string
+                    dataType:
+                      type: string
+                    description:
+                      type: string
+                    isModifiable:
+                      type: boolean
+                    minimumEngineVersion:
+                      type: string
+                    parameterName:
+                      type: string
+                    parameterValue:
+                      type: string
+                    source:
+                      type: string
+                    supportedEngineModes:
+                      items:
+                        type: string
+                      type: array
+                  type: object
+                type: array
             type: object
         type: object
     served: true