Skip to content

Commit e51e591

Browse files
authored
Add support for DatabaseInsightsMode (#235)
Issue #, if available: [2511](aws-controllers-k8s/community#2511) Description of changes: - Remove DBCluster.DatabaseInsightsMode from ignored fields - Remove DBInstance.DatabaseInsightsMode from ignored fields - Update DBCluster customUpdate to support setting DatabaseInsightsMode, PerformanceInsightsEnabled, PerformanceInsightsRetentionPeriods, and PerformanceInsightsKMSKeyID - Add test to verify custom DBCluster update logic By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 3a347d3 commit e51e591

18 files changed

+981
-796
lines changed
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
ack_generate_info:
2-
build_date: "2025-08-15T00:19:32Z"
3-
build_hash: b6df33f8c7f55b234555c0b578b8de43c74771a8
4-
go_version: go1.24.6
5-
version: v0.51.0
6-
api_directory_checksum: 52968d74358773de28be65be320d1bfb9c91e0bf
2+
build_date: "2025-08-22T23:47:01Z"
3+
build_hash: 1045a5e99038b11b0630ca2f2f69c3bae4bedba6
4+
go_version: go1.25.0
5+
version: v0.51.0-1-g1045a5e
6+
api_directory_checksum: 90b0d1adcc91f4a1b1f1b436e3ac0c30d9271678
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.32.6
99
generator_config_info:
10-
file_checksum: c2e5556f70b93834cadb221ec373fa29d6c1692b
10+
file_checksum: ecb60f0fe79237eb820e68d823e6da2bf0829140
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation

apis/v1alpha1/db_cluster.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/v1alpha1/db_instance.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/v1alpha1/generator.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ ignore:
2424
field_paths:
2525
- CreateDBClusterInput.CACertificateIdentifier
2626
- CreateDBClusterInput.ClusterScalabilityType
27-
- CreateDBClusterInput.DatabaseInsightsMode
2827
- CreateDBClusterInput.EngineLifecycleSupport
2928
- CreateDBClusterInput.EnableLimitlessDatabase
3029
- CreateDBClusterInput.EnableLocalWriteForwarding
@@ -37,20 +36,17 @@ ignore:
3736
- CreateDBClusterOutput.DBCluster.AwsBackupRecoveryPointArn
3837
- CreateDBClusterOutput.DBCluster.CertificateDetails
3938
- CreateDBClusterOutput.DBCluster.ClusterScalabilityType
40-
- CreateDBClusterOutput.DBCluster.DatabaseInsightsMode
4139
- CreateDBClusterOutput.DBCluster.EngineLifecycleSupport
4240
- CreateDBInstanceInput.DBSecurityGroups
4341
- CreateDBInstanceInput.DomainAuthSecretArn
4442
- CreateDBInstanceInput.DomainDnsIps
4543
- CreateDBInstanceInput.MultiTenant
4644
- CreateDBInstanceInput.DedicatedLogVolume
47-
- CreateDBInstanceInput.DatabaseInsightsMode
4845
- CreateDBInstanceInput.DBSystemId
4946
- CreateDBInstanceInput.DomainFqdn
5047
- CreateDBInstanceInput.DomainOu
5148
- CreateDBInstanceInput.EngineLifecycleSupport
5249
- CreateDBInstanceOutput.DBInstance.PercentProgress
53-
- CreateDBInstanceOutput.DBInstance.DatabaseInsightsMode
5450
- CreateDBInstanceOutput.DBInstance.DedicatedLogVolume
5551
- CreateDBInstanceOutput.DBInstance.EngineLifecycleSupport
5652
- CreateDBInstanceOutput.DBInstance.IsStorageConfigUpgradeAvailable

apis/v1alpha1/types.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/v1alpha1/zz_generated.deepcopy.go

Lines changed: 20 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/rds.services.k8s.aws_dbclusters.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,10 @@ spec:
135135
136136
Valid for Cluster Type: Aurora DB clusters and Multi-AZ DB clusters
137137
type: boolean
138+
databaseInsightsMode:
139+
description: Specifies the mode of Database Insights to enable for
140+
the cluster.
141+
type: string
138142
databaseName:
139143
description: |-
140144
The name for your database of up to 64 alphanumeric characters. A database

config/crd/bases/rds.services.k8s.aws_dbinstances.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -271,6 +271,10 @@ spec:
271271
and your VPC (https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/custom-setup-orcl.html#custom-setup-orcl.iam-vpc)
272272
in the Amazon RDS User Guide.
273273
type: string
274+
databaseInsightsMode:
275+
description: Specifies the mode of Database Insights to enable for
276+
the instance.
277+
type: string
274278
dbClusterIdentifier:
275279
description: |-
276280
The identifier of the DB cluster that this DB instance will belong to.

generator.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ ignore:
2424
field_paths:
2525
- CreateDBClusterInput.CACertificateIdentifier
2626
- CreateDBClusterInput.ClusterScalabilityType
27-
- CreateDBClusterInput.DatabaseInsightsMode
2827
- CreateDBClusterInput.EngineLifecycleSupport
2928
- CreateDBClusterInput.EnableLimitlessDatabase
3029
- CreateDBClusterInput.EnableLocalWriteForwarding
@@ -37,20 +36,17 @@ ignore:
3736
- CreateDBClusterOutput.DBCluster.AwsBackupRecoveryPointArn
3837
- CreateDBClusterOutput.DBCluster.CertificateDetails
3938
- CreateDBClusterOutput.DBCluster.ClusterScalabilityType
40-
- CreateDBClusterOutput.DBCluster.DatabaseInsightsMode
4139
- CreateDBClusterOutput.DBCluster.EngineLifecycleSupport
4240
- CreateDBInstanceInput.DBSecurityGroups
4341
- CreateDBInstanceInput.DomainAuthSecretArn
4442
- CreateDBInstanceInput.DomainDnsIps
4543
- CreateDBInstanceInput.MultiTenant
4644
- CreateDBInstanceInput.DedicatedLogVolume
47-
- CreateDBInstanceInput.DatabaseInsightsMode
4845
- CreateDBInstanceInput.DBSystemId
4946
- CreateDBInstanceInput.DomainFqdn
5047
- CreateDBInstanceInput.DomainOu
5148
- CreateDBInstanceInput.EngineLifecycleSupport
5249
- CreateDBInstanceOutput.DBInstance.PercentProgress
53-
- CreateDBInstanceOutput.DBInstance.DatabaseInsightsMode
5450
- CreateDBInstanceOutput.DBInstance.DedicatedLogVolume
5551
- CreateDBInstanceOutput.DBInstance.EngineLifecycleSupport
5652
- CreateDBInstanceOutput.DBInstance.IsStorageConfigUpgradeAvailable

helm/crds/rds.services.k8s.aws_dbclusters.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,10 @@ spec:
135135
136136
Valid for Cluster Type: Aurora DB clusters and Multi-AZ DB clusters
137137
type: boolean
138+
databaseInsightsMode:
139+
description: Specifies the mode of Database Insights to enable for
140+
the cluster.
141+
type: string
138142
databaseName:
139143
description: |-
140144
The name for your database of up to 64 alphanumeric characters. A database

0 commit comments

Comments
 (0)