Merge pull request #106 from jaypipes/tags

support tag updates for DBInstance

Author: jaypipes

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2022-08-02T17:57:11Z"
+  build_date: "2022-08-04T21:32:49Z"
   build_hash: fe61d04673fd4d9848d5f726b01e0689a16d3733
-  go_version: go1.18.2
+  go_version: go1.18.1
   version: v0.19.3-1-gfe61d04
-api_directory_checksum: 8ada3ef8efbea428641119f90c05dbfb65069def
+api_directory_checksum: 6a967cc8a62d521d4f4816dbccc48f81d0cb271d
 api_version: v1alpha1
 aws_sdk_go_version: v1.44.27
 generator_config_info:
-  file_checksum: 6b1659191eae1755bf1d223f90add0c6665e9eed
+  file_checksum: dc22b2b5295201b27341f95c1cec0b0dcead98b3
   original_file_name: generator.yaml
 last_modification:
   reason: API generation

apis/v1alpha1/db_instance.go

@@ -20,6 +20,8 @@ ignore:
   field_paths:
     - CreateDBInstanceInput.DBSecurityGroups
     - DBInstance.DBSecurityGroups
+    # We handle Spec.Tags separately...
+    - "DescribeDBInstancesOutput.DBInstances.DBInstance.TagList"
 operations:
   ModifyDBCluster:
     override_values:
@@ -128,6 +130,10 @@ resources:
         from:
           operation: RestoreDBClusterFromSnapshot
           path: SnapshotIdentifier
+      Tags:
+        compare:
+          # We have a custom comparison function...
+          is_ignored: true
     renames:
       operations:
         CreateDBCluster:
@@ -171,6 +177,10 @@ resources:
         from:
           operation: ModifyDBClusterParameterGroup
           path: Parameters
+      Tags:
+        compare:
+          # We have a custom comparison function...
+          is_ignored: true
   DBInstance:
     hooks:
       sdk_create_pre_build_request:
@@ -259,6 +269,10 @@ resources:
         from:
           operation: CreateDBInstanceReadReplica
           path: PreSignedUrl
+      Tags:
+        compare:
+          # We have a custom comparison function...
+          is_ignored: true
     renames:
       operations:
         CreateDBInstance:
@@ -312,6 +326,10 @@ resources:
         from:
           operation: ModifyDBParameterGroup
           path: Parameters
+      Tags:
+        compare:
+          # We have a custom comparison function...
+          is_ignored: true
   DBSubnetGroup:
     renames:
       operations:
@@ -346,6 +364,10 @@ resources:
     fields:
       Name:
         is_primary_key: true
+      Tags:
+        compare:
+          # We have a custom comparison function...
+          is_ignored: true
   DBProxy:
     exceptions:
       terminal_codes:

apis/v1alpha1/generator.yaml

@@ -1255,17 +1255,6 @@ spec:
                       type: string
                   type: object
                 type: array
-              tagList:
-                items:
-                  description: Metadata assigned to an Amazon RDS resource consisting
-                    of a key-value pair.
-                  properties:
-                    key:
-                      type: string
-                    value:
-                      type: string
-                  type: object
-                type: array
               vpcSecurityGroups:
                 description: Provides a list of VPC security group elements that the
                   DB instance belongs to.

apis/v1alpha1/types.go

@@ -20,6 +20,8 @@ ignore:
   field_paths:
     - CreateDBInstanceInput.DBSecurityGroups
     - DBInstance.DBSecurityGroups
+    # We handle Spec.Tags separately...
+    - "DescribeDBInstancesOutput.DBInstances.DBInstance.TagList"
 operations:
   ModifyDBCluster:
     override_values:
@@ -128,6 +130,10 @@ resources:
         from:
           operation: RestoreDBClusterFromSnapshot
           path: SnapshotIdentifier
+      Tags:
+        compare:
+          # We have a custom comparison function...
+          is_ignored: true
     renames:
       operations:
         CreateDBCluster:
@@ -171,6 +177,10 @@ resources:
         from:
           operation: ModifyDBClusterParameterGroup
           path: Parameters
+      Tags:
+        compare:
+          # We have a custom comparison function...
+          is_ignored: true
   DBInstance:
     hooks:
       sdk_create_pre_build_request:
@@ -259,6 +269,10 @@ resources:
         from:
           operation: CreateDBInstanceReadReplica
           path: PreSignedUrl
+      Tags:
+        compare:
+          # We have a custom comparison function...
+          is_ignored: true
     renames:
       operations:
         CreateDBInstance:
@@ -312,6 +326,10 @@ resources:
         from:
           operation: ModifyDBParameterGroup
           path: Parameters
+      Tags:
+        compare:
+          # We have a custom comparison function...
+          is_ignored: true
   DBSubnetGroup:
     renames:
       operations:
@@ -346,6 +364,10 @@ resources:
     fields:
       Name:
         is_primary_key: true
+      Tags:
+        compare:
+          # We have a custom comparison function...
+          is_ignored: true
   DBProxy:
     exceptions:
       terminal_codes:

apis/v1alpha1/zz_generated.deepcopy.go

@@ -1255,17 +1255,6 @@ spec:
                       type: string
                   type: object
                 type: array
-              tagList:
-                items:
-                  description: Metadata assigned to an Amazon RDS resource consisting
-                    of a key-value pair.
-                  properties:
-                    key:
-                      type: string
-                    value:
-                      type: string
-                  type: object
-                type: array
               vpcSecurityGroups:
                 description: Provides a list of VPC security group elements that the
                   DB instance belongs to.