remove unused AWSResourceDescriptor.UpdateCRStatus

Originally, I'd planned to use the AWSResourceDescriptor.UpdateCRStatus
interface method to allow different resources to override the way they
set conditions and such. However, other places like the generator
config's use of terminal conditions, generic hook points and custom
override places became the canonical ways of extending this behaviour.

So, the AWSResourceDescriptor.UpdateCRStatus interface method is just an
anachronism at this point and needs to be removed since it's just noise
and always just returns true.

Author: jaypipes

mocks/pkg/types/aws_resource_descriptor.go

@@ -369,13 +369,6 @@ func (r *resourceReconciler) patchResourceStatus(
 	exit := rlog.Trace("r.patchResourceStatus")
 	defer exit(err)
 
-	changedStatus, err := r.rd.UpdateCRStatus(latest)
-	if err != nil {
-		return err
-	}
-	if !changedStatus {
-		return nil
-	}
 	rlog.Enter("kc.Patch (status)")
 	// It is necessary to use `DeepCopyObject` versions of `latest` when calling
 	// `Patch` as this method overrides all values as merged from `desired`.

pkg/runtime/reconciler.go

@@ -103,7 +103,6 @@ func TestReconcilerUpdate(t *testing.T) {
 		delta,
 	).Once()
 	rd.On("Delta", desired, latest).Return(ackcompare.NewDelta())
-	rd.On("UpdateCRStatus", latest).Return(true, nil)
 	rd.On("IsManaged", desired).Return(true)
 
 	rm := &ackmocks.AWSResourceManager{}
@@ -221,7 +220,6 @@ func TestReconcilerUpdate_PatchMetadataAndSpec_DiffInMetadata(t *testing.T) {
 		delta,
 	).Once()
 	rd.On("Delta", desired, latest).Return(ackcompare.NewDelta())
-	rd.On("UpdateCRStatus", latest).Return(true, nil)
 	rd.On("IsManaged", desired).Return(true)
 
 	rm := &ackmocks.AWSResourceManager{}
@@ -338,7 +336,6 @@ func TestReconcilerUpdate_PatchMetadataAndSpec_DiffInSpec(t *testing.T) {
 	rd.On("Delta", desired, latest).Return(
 		delta,
 	)
-	rd.On("UpdateCRStatus", latest).Return(true, nil)
 	rd.On("IsManaged", desired).Return(true)
 
 	rm := &ackmocks.AWSResourceManager{}

pkg/runtime/reconciler_test.go

@@ -37,10 +37,6 @@ type AWSResourceDescriptor interface {
 	// Delta returns an `ackcompare.Delta` object containing the difference between
 	// one `AWSResource` and another.
 	Delta(a, b AWSResource) *ackcompare.Delta
-	// UpdateCRStatus accepts an AWSResource object and changes the Status
-	// sub-object of the AWSResource's Kubernetes custom resource (CR) and
-	// returns whether any changes were made
-	UpdateCRStatus(AWSResource) (bool, error)
 	// IsManaged returns true if the supplied AWSResource is under the
 	// management of an ACK service controller. What this means in practice is
 	// that the underlying custom resource (CR) in the AWSResource has had a