Skip to content

Commit 3d52b06

Browse files
authored
Delete --bind-port flag (#28)
Small rework of the `config` package that deleted `--bind-port` NOTE: `Port` and `Host` options that are used to create a new controller-runtime manager instance are used for the webhook server. see https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/manager/manager.go#L211-L216 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 00651cf commit 3d52b06

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

pkg/config/config.go

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import (
2424
)
2525

2626
const (
27-
flagBindPort = "bind-port"
2827
flagEnableLeaderElection = "enable-leader-election"
2928
flagMetricAddr = "metrics-addr"
3029
flagEnableDevLogging = "enable-development-logging"
@@ -40,7 +39,6 @@ const (
4039

4140
// Config contains configuration otpions for ACK service controllers
4241
type Config struct {
43-
BindPort int
4442
MetricsAddr string
4543
EnableLeaderElection bool
4644
EnableDevelopmentLogging bool
@@ -56,11 +54,6 @@ type Config struct {
5654

5755
// BindFlags defines CLI/runtime configuration options
5856
func (cfg *Config) BindFlags() {
59-
flag.IntVar(
60-
&cfg.BindPort, flagBindPort,
61-
9443,
62-
"The port the service controller binds to.",
63-
)
6457
flag.StringVar(
6558
&cfg.MetricsAddr, flagMetricAddr,
6659
"0.0.0.0:8080",
@@ -69,11 +62,11 @@ func (cfg *Config) BindFlags() {
6962
flag.BoolVar(
7063
&cfg.EnableWebhookServer, flagEnableWebhookServer,
7164
false,
72-
"Enable webhook server for controller manager. ",
65+
"Enable webhook server for controller manager.",
7366
)
7467
flag.StringVar(
7568
&cfg.WebhookServerAddr, flagWebhookServerAddr,
76-
"0.0.0.0:443",
69+
"0.0.0.0:9433",
7770
"The address the webhook endpoint binds to.",
7871
)
7972
flag.BoolVar(

0 commit comments

Comments
 (0)