Patch metadata and spec when handling errors (#92)

Description of changes:
If any update hook code tried to return a requeue error, the reconciler would short circuit and never patch the metadata and spec. As a result, fields returned by the API server were never being persisted back into the K8s API - which in turn lead to the delta finding differences every loop. This is the root cause for aws-controllers-k8s/community#1251. 

This pull request adds patching into the `HandleReconcileError` method, which sits at the end of the call stack where we handle the re-queuing errors. Therefore, even if an error is returned, as long as the error is not terminal, the spec will be patched.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: RedbackThomson

pkg/runtime/reconciler.go

@@ -832,6 +832,8 @@ func (r *resourceReconciler) HandleReconcileError(
 	err error,
 ) (ctrlrt.Result, error) {
 	if ackcompare.IsNotNil(latest) {
+		// Create a copy so we don't override the spec
+		latestCopy := latest.DeepCopy()
 		// The reconciliation loop may have returned an error, but if latest is
 		// not nil, there may be some changes available in the CR's Status
 		// struct (example: Conditions), and we want to make sure we save those
@@ -845,13 +847,18 @@ func (r *resourceReconciler) HandleReconcileError(
 		//
 		// TODO(jaypipes): We ignore error handling here but I don't know if
 		// there is a more robust way to handle failures in the patch operation
-		_ = r.patchResourceStatus(ctx, desired, latest)
+		_ = r.patchResourceStatus(ctx, desired, latestCopy)
 	}
 	if err == nil || err == ackerr.Terminal {
 		return ctrlrt.Result{}, nil
 	}
 	rlog := ackrtlog.FromContext(ctx)
 
+	// Ensure that we are patching any changes to the annotations/metadata and
+	// the Spec that may have been set by the resource manager's successful
+	// Create call above.
+	_ = r.patchResourceMetadataAndSpec(ctx, desired, latest)
+
 	var requeueNeededAfter *requeue.RequeueNeededAfter
 	if errors.As(err, &requeueNeededAfter) {
 		after := requeueNeededAfter.Duration()