Skip to content

Commit f4df629

Browse files
Add support for Lifecycle, Notification and Replication Bucket fields (#44)
Description of changes: These are the remaining fields that do not require custom types - they map one-to-one with `Bucket`. I have tested these manually, using the test resource files. I will wait for #43 before writing automated tests, for these. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent c670ee6 commit f4df629

File tree

15 files changed

+3847
-135
lines changed

15 files changed

+3847
-135
lines changed
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
ack_generate_info:
2-
build_date: "2021-08-18T23:04:06Z"
3-
build_hash: 821a0daf362fdda8148046310c3eb478b96366ac
2+
build_date: "2021-08-26T22:35:21Z"
3+
build_hash: 7ce2d042a4b94dab4e8d36f4b682071ab5ef148d
44
go_version: go1.15.6 linux/amd64
55
version: v0.12.0
6-
api_directory_checksum: bcc0d3701806837cbed403db3bf81fe31d28a484
6+
api_directory_checksum: dfcc21d3fc7fcd228ae29942f020128e7a3bdb8e
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.37.10
99
generator_config_info:
10-
file_checksum: 307d0ff1c9f95cd1aa1e41b0a22b4a68fdba7a86
10+
file_checksum: 3adc9b830bb3e9ea446ea5ee85ee03f21edc65fd
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation
14-
timestamp: 2021-08-18 23:04:11.43787211 +0000 UTC
14+
timestamp: 2021-08-26 22:35:29.003531544 +0000 UTC

apis/v1alpha1/bucket.go

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/v1alpha1/generator.yaml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@ resources:
3838
# from:
3939
# operation: PutBucketInventoryConfiguration
4040
# path: InventoryConfiguration # Double check about ID
41-
# LifecycleConfiguration:
42-
# from:
43-
# operation: PutBucketLifecycleConfiguration
44-
# path: LifecycleConfiguration # Double check weird types
41+
Lifecycle:
42+
from:
43+
operation: PutBucketLifecycleConfiguration
44+
path: LifecycleConfiguration
4545
Logging:
4646
from:
4747
operation: PutBucketLogging
@@ -50,22 +50,22 @@ resources:
5050
# from:
5151
# operation: PutBucketMetricsConfiguration
5252
# path: MetricsConfiguration # Double check about ID
53-
# NotificationConfiguration:
54-
# from:
55-
# operation: PutBucketNotificationConfiguration
56-
# path: NotificationConfiguration # Double check the importing
53+
Notification:
54+
from:
55+
operation: PutBucketNotificationConfiguration
56+
path: NotificationConfiguration
5757
OwnershipControls:
5858
from:
5959
operation: PutBucketOwnershipControls
6060
path: OwnershipControls
6161
Policy:
6262
from:
6363
operation: PutBucketPolicy
64-
path: Policy # Double check about ConfirmRemoveSelfBucketAccess
65-
# Replication:
66-
# from:
67-
# operation: PutBucketReplication
68-
# path: ReplicationConfiguration # Double check about Token
64+
path: Policy
65+
Replication:
66+
from:
67+
operation: PutBucketReplication
68+
path: ReplicationConfiguration
6969
RequestPayment:
7070
from:
7171
operation: PutBucketRequestPayment

0 commit comments

Comments
 (0)