Feature - Directory Bucket Support (S3 Express) #187

Itai-Melamed · 2025-10-23T09:59:52Z

Description of changes:
Implemented support for DirectoryBuckets Creation by removing ignore of DirectoryBucket Fields.

CreateBucketConfiguration.Bucket
CreateBucketConfiguration.Location

Overrided some of the operations that don't support directory buckets with the equivalent S3 Express operations.
(in - pkg/resource/bucket/hook.go)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…e ACK code

…kets

ack-prow · 2025-10-23T09:59:58Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Itai-Melamed
Once this PR has been reviewed and has the lgtm label, please assign michaelhtm for approval by writing /assign @michaelhtm in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ack-prow · 2025-10-23T10:00:04Z

Hi @Itai-Melamed. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knottnt · 2025-10-23T16:40:20Z

/ok-to-test

knottnt · 2025-10-23T17:06:42Z

/test s3-kind-e2e

knottnt

@Itai-Melamed Thanks for the contribution!

Left a few comments. In addition to this we'll also need to add some e2e tests to validate that we can create, update, and delete a directory bucket similar to the other test found in the test/e2e directory.

knottnt · 2025-10-23T16:25:25Z

apis/v1alpha1/ack-generate-metadata.yaml

+  build_date: "2025-10-23T09:42:09Z"
+  build_hash: eaabefb6bd7b2be8a1baf4478f22b3310e6921c8
+  go_version: go1.25.3
+  version: v0.52.0-6-geaabefb-dirty


Did you need to modify the ackgenerate tool to make these changes? If not could you rebuild the controller with an unmodified version.

I'm not sure what caused this change, I assumed the ack-generate tool updated some metadata and didn't think much of it. I don't think it is crucial to the implementation.

Could you maybe elaborate on how to know what the actual values should be?

knottnt · 2025-10-23T16:48:29Z

pkg/resource/bucket/hook.go

+// isDirectoryBucketName checks if a bucket name follows the directory bucket naming pattern.
+// Directory buckets must end with "--x-s3" suffix and follow the format:
+// bucket-base-name--zone-id--x-s3
+func isDirectoryBucketName(bucketName string) bool {


The logic looks good, but could you add some unit tests for this function.

knottnt · 2025-10-23T17:43:38Z

pkg/resource/bucket/hook.go

 	ctx context.Context,
 	r *resource,
 ) error {
+	// Check if this is a directory bucket to skip unsupported operations


We don't want to silently ignore values in the spec field. If a user provides an invalid combination of values in their spec we want them to get feedback that the controller isn't able apply the desired state. Often this just involves calling the API and surfacing the returned validation error.

That makes sense. I modified it to use a validation function that returns error if the type of bucket and properties provided are incompatible

knottnt · 2025-10-23T20:08:49Z

apis/v1alpha1/generator.yaml

-    - CreateBucketInput.CreateBucketConfiguration.Bucket
    - LoggingEnabled.TargetObjectKeyFormat
+operations:
+  ListDirectoryBuckets:


With customFindBucket being used is this still needed?

Don't think it is. it was probably here since a previous iteration when the SDK automatically assumed ListBucket as the list operation which is not supported for directory buckets.

knottnt · 2025-10-24T18:10:00Z

pkg/resource/bucket/hook.go

+) error {
+	rlog := ackrtlog.FromContext(ctx)
+
+	s3controlClient := s3control.NewFromConfig(rm.clientcfg)


We may need to make some changes to the underlying runtime to make sure this is assuming the correct IAM role when using CARM or future IAMSelector functionality.

knottnt · 2025-10-27T17:01:24Z

pkg/resource/bucket/hook.go

+) error {
+	rlog := ackrtlog.FromContext(ctx)
+
+	s3controlClient := s3control.NewFromConfig(rm.clientcfg)


We don't normally work with multiple sdk clients within an individual ACK controller. Looking at how we setup the client config in our core runtime this should have the correct role credentials, but we'll want to do some extra testing to verify that this works as expected when using CARM or non-default regions.

…cket is used instead)

Itai-Melamed · 2025-10-29T15:57:57Z

/retest

ack-prow · 2025-10-30T17:36:53Z

@Itai-Melamed: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
s3-kind-e2e	`0ba503e`	link	true	`/test s3-kind-e2e`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Itai-Melamed added 3 commits October 22, 2025 14:09

Remove Ignored Fields, modify locationConstraint override and generat…

6e7373d

…e ACK code

fix "type_" scheme override

060d4ba

modify management operations that are not supported for Directory buc…

be57139

…kets

ack-prow bot requested review from jlbutler and rushmash91 October 23, 2025 09:59

ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 23, 2025

Itai-Melamed closed this Oct 23, 2025

support tagging operations

41b0082

Itai-Melamed reopened this Oct 23, 2025

ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 23, 2025

knottnt reviewed Oct 27, 2025

View reviewed changes

Itai-Melamed added 5 commits October 29, 2025 17:08

fix attribution file mismatch check

eb542a7

better validation for invalid Directory Bucket configuration

80c851e

remove unnecessary operation override in generator.yaml (customFindBu…

03dc43d

…cket is used instead)

regenerate code using s3-controller

b1dde85

Add unit test for IsDirectoryBucketName function

0ba503e

Feature - Directory Bucket Support (S3 Express) #187

Are you sure you want to change the base?

Feature - Directory Bucket Support (S3 Express) #187

Conversation

Itai-Melamed commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ack-prow bot commented Oct 23, 2025

Uh oh!

ack-prow bot commented Oct 23, 2025

Uh oh!

knottnt commented Oct 23, 2025

Uh oh!

knottnt commented Oct 23, 2025

Uh oh!

knottnt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Itai-Melamed commented Oct 29, 2025

Uh oh!

ack-prow bot commented Oct 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Itai-Melamed commented Oct 23, 2025 •

edited

Loading