Skip to content

Commit 0d56387

Browse files
ryansteakleyryansteakley
authored
Use late-initialize where possible (#100)
Description of changes: Use late-initialize code where it is applicable to replace custom-delta code with late-initialize in the generator.yaml By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent bc674d4 commit 0d56387

File tree

15 files changed

+263
-88
lines changed

15 files changed

+263
-88
lines changed

‎apis/v1alpha1/ack-generate-metadata.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
ack_generate_info:
2-
build_date: "2021-09-01T20:02:38Z"
3-
build_hash: 709a1e110beb1da248c87c7738f97282d90556ba
4-
go_version: go1.16.4 linux/amd64
2+
build_date: "2021-09-07T19:20:32Z"
3+
build_hash: 6f22b7b568e25b4ee007bb1ab5f9338c16daf172
4+
go_version: go1.16.4 darwin/amd64
55
version: v0.13.0
66
api_directory_checksum: 48052ad31bd7f3dbf811d81079f7235446af4cfc
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.38.11
99
generator_config_info:
10-
file_checksum: 0a6535a29c6f76b5ce8a9d15f6de246542a017d8
10+
file_checksum: e04a7b170d8910356101a99973c6649672c43dcc
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation
14-
timestamp: 2021-09-01 20:02:43.411194445 +0000 UTC
14+
timestamp: 2021-09-07 19:20:42.078783 +0000 UTC

‎apis/v1alpha1/generator.yaml

Lines changed: 45 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@ resources:
4343
Tags:
4444
compare:
4545
is_ignored: true
46+
EnableNetworkIsolation:
47+
late_initialize:
48+
min_backoff_seconds: 5
4649
EndpointConfig:
4750
exceptions:
4851
errors:
@@ -179,6 +182,21 @@ resources:
179182
AlgorithmSpecification.MetricDefinitions:
180183
late_initialize:
181184
min_backoff_seconds: 5
185+
EnableInterContainerTrafficEncryption:
186+
late_initialize:
187+
min_backoff_seconds: 5
188+
EnableManagedSpotTraining:
189+
late_initialize:
190+
min_backoff_seconds: 5
191+
EnableNetworkIsolation:
192+
late_initialize:
193+
min_backoff_seconds: 5
194+
AlgorithmSpecification.EnableSageMakerMetricsTimeSeries:
195+
late_initialize:
196+
min_backoff_seconds: 5
197+
OutputDataConfig.KMSKeyID:
198+
late_initialize:
199+
min_backoff_seconds: 5
182200
Tags:
183201
compare:
184202
is_ignored: true
@@ -218,7 +236,7 @@ resources:
218236
priority: 1
219237
from:
220238
operation: DescribeProcessingJob
221-
path: FailureReason
239+
path: FailureReason
222240
Tags:
223241
compare:
224242
is_ignored: true
@@ -259,6 +277,12 @@ resources:
259277
from:
260278
operation: DescribeTransformJob
261279
path: FailureReason
280+
TransformInput.SplitType:
281+
late_initialize:
282+
min_backoff_seconds: 5
283+
TransformInput.CompressionType:
284+
late_initialize:
285+
min_backoff_seconds: 5
262286
Tags:
263287
compare:
264288
is_ignored: true
@@ -311,6 +335,15 @@ resources:
311335
TrainingJobDefinition.AlgorithmSpecification.MetricDefinitions:
312336
late_initialize:
313337
min_backoff_seconds: 5
338+
TrainingJobDefinition.EnableInterContainerTrafficEncryption:
339+
late_initialize:
340+
min_backoff_seconds: 5
341+
TrainingJobDefinition.EnableManagedSpotTraining:
342+
late_initialize:
343+
min_backoff_seconds: 5
344+
TrainingJobDefinition.EnableNetworkIsolation:
345+
late_initialize:
346+
min_backoff_seconds: 5
314347
Tags:
315348
compare:
316349
is_ignored: true
@@ -499,6 +532,8 @@ resources:
499532
from:
500533
operation: DescribeModelPackage
501534
path: ModelApprovalStatus
535+
late_initialize:
536+
min_backoff_seconds: 5
502537
LastModifiedTime:
503538
is_read_only: true
504539
from:
@@ -508,6 +543,9 @@ resources:
508543
from:
509544
operation: UpdateModelPackage
510545
path: ApprovalDescription
546+
CertifyForMarketplace:
547+
late_initialize:
548+
min_backoff_seconds: 5
511549
Tags:
512550
compare:
513551
is_ignored: true
@@ -548,6 +586,12 @@ resources:
548586
from:
549587
operation: DescribeFeatureGroup
550588
path: FeatureGroupStatus
589+
OfflineStoreConfig.DisableGlueTableCreation:
590+
late_initialize:
591+
min_backoff_seconds: 5
592+
OfflineStoreConfig.S3StorageConfig.ResolvedOutputS3URI:
593+
late_initialize:
594+
min_backoff_seconds: 5
551595
Tags:
552596
compare:
553597
is_ignored: true

‎generator.yaml

Lines changed: 45 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@ resources:
4343
Tags:
4444
compare:
4545
is_ignored: true
46+
EnableNetworkIsolation:
47+
late_initialize:
48+
min_backoff_seconds: 5
4649
EndpointConfig:
4750
exceptions:
4851
errors:
@@ -179,6 +182,21 @@ resources:
179182
AlgorithmSpecification.MetricDefinitions:
180183
late_initialize:
181184
min_backoff_seconds: 5
185+
EnableInterContainerTrafficEncryption:
186+
late_initialize:
187+
min_backoff_seconds: 5
188+
EnableManagedSpotTraining:
189+
late_initialize:
190+
min_backoff_seconds: 5
191+
EnableNetworkIsolation:
192+
late_initialize:
193+
min_backoff_seconds: 5
194+
AlgorithmSpecification.EnableSageMakerMetricsTimeSeries:
195+
late_initialize:
196+
min_backoff_seconds: 5
197+
OutputDataConfig.KMSKeyID:
198+
late_initialize:
199+
min_backoff_seconds: 5
182200
Tags:
183201
compare:
184202
is_ignored: true
@@ -218,7 +236,7 @@ resources:
218236
priority: 1
219237
from:
220238
operation: DescribeProcessingJob
221-
path: FailureReason
239+
path: FailureReason
222240
Tags:
223241
compare:
224242
is_ignored: true
@@ -259,6 +277,12 @@ resources:
259277
from:
260278
operation: DescribeTransformJob
261279
path: FailureReason
280+
TransformInput.SplitType:
281+
late_initialize:
282+
min_backoff_seconds: 5
283+
TransformInput.CompressionType:
284+
late_initialize:
285+
min_backoff_seconds: 5
262286
Tags:
263287
compare:
264288
is_ignored: true
@@ -311,6 +335,15 @@ resources:
311335
TrainingJobDefinition.AlgorithmSpecification.MetricDefinitions:
312336
late_initialize:
313337
min_backoff_seconds: 5
338+
TrainingJobDefinition.EnableInterContainerTrafficEncryption:
339+
late_initialize:
340+
min_backoff_seconds: 5
341+
TrainingJobDefinition.EnableManagedSpotTraining:
342+
late_initialize:
343+
min_backoff_seconds: 5
344+
TrainingJobDefinition.EnableNetworkIsolation:
345+
late_initialize:
346+
min_backoff_seconds: 5
314347
Tags:
315348
compare:
316349
is_ignored: true
@@ -499,6 +532,8 @@ resources:
499532
from:
500533
operation: DescribeModelPackage
501534
path: ModelApprovalStatus
535+
late_initialize:
536+
min_backoff_seconds: 5
502537
LastModifiedTime:
503538
is_read_only: true
504539
from:
@@ -508,6 +543,9 @@ resources:
508543
from:
509544
operation: UpdateModelPackage
510545
path: ApprovalDescription
546+
CertifyForMarketplace:
547+
late_initialize:
548+
min_backoff_seconds: 5
511549
Tags:
512550
compare:
513551
is_ignored: true
@@ -548,6 +586,12 @@ resources:
548586
from:
549587
operation: DescribeFeatureGroup
550588
path: FeatureGroupStatus
589+
OfflineStoreConfig.DisableGlueTableCreation:
590+
late_initialize:
591+
min_backoff_seconds: 5
592+
OfflineStoreConfig.S3StorageConfig.ResolvedOutputS3URI:
593+
late_initialize:
594+
min_backoff_seconds: 5
551595
Tags:
552596
compare:
553597
is_ignored: true

‎pkg/resource/feature_group/custom_delta.go

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -22,26 +22,11 @@ func customSetDefaults(
2222
a *resource,
2323
b *resource,
2424
) {
25-
// DisableGlueTableCreation is false by default.
26-
if ackcompare.IsNotNil(a.ko.Spec.OfflineStoreConfig) && ackcompare.IsNotNil(b.ko.Spec.OfflineStoreConfig) {
27-
if ackcompare.IsNil(a.ko.Spec.OfflineStoreConfig.DisableGlueTableCreation) && ackcompare.IsNotNil(b.ko.Spec.OfflineStoreConfig.DisableGlueTableCreation) {
28-
a.ko.Spec.OfflineStoreConfig.DisableGlueTableCreation = b.ko.Spec.OfflineStoreConfig.DisableGlueTableCreation
29-
}
30-
}
3125

3226
// DataCatalogConfig has a timestamped generated default value.
3327
if ackcompare.IsNotNil(a.ko.Spec.OfflineStoreConfig) && ackcompare.IsNotNil(b.ko.Spec.OfflineStoreConfig) {
3428
if ackcompare.IsNil(a.ko.Spec.OfflineStoreConfig.DataCatalogConfig) && ackcompare.IsNotNil(b.ko.Spec.OfflineStoreConfig.DataCatalogConfig) {
3529
a.ko.Spec.OfflineStoreConfig.DataCatalogConfig = b.ko.Spec.OfflineStoreConfig.DataCatalogConfig
3630
}
3731
}
38-
39-
// ResolvedOutputS3URI has a timestamped generated default value.
40-
if ackcompare.IsNotNil(a.ko.Spec.OfflineStoreConfig) && ackcompare.IsNotNil(b.ko.Spec.OfflineStoreConfig) {
41-
if ackcompare.IsNotNil(a.ko.Spec.OfflineStoreConfig.S3StorageConfig) && ackcompare.IsNotNil(b.ko.Spec.OfflineStoreConfig.S3StorageConfig) {
42-
if ackcompare.IsNil(a.ko.Spec.OfflineStoreConfig.S3StorageConfig.ResolvedOutputS3URI) && ackcompare.IsNotNil(b.ko.Spec.OfflineStoreConfig.S3StorageConfig.ResolvedOutputS3URI) {
43-
a.ko.Spec.OfflineStoreConfig.S3StorageConfig.ResolvedOutputS3URI = b.ko.Spec.OfflineStoreConfig.S3StorageConfig.ResolvedOutputS3URI
44-
}
45-
}
46-
}
4732
}

‎pkg/resource/feature_group/manager.go

Lines changed: 29 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎pkg/resource/hyper_parameter_tuning_job/custom_delta.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,5 @@ func customSetDefaults(
3131
}
3232
}
3333
}
34-
35-
if ackcompare.IsNil(a.ko.Spec.TrainingJobDefinition.EnableManagedSpotTraining) && ackcompare.IsNotNil(b.ko.Spec.TrainingJobDefinition.EnableManagedSpotTraining) {
36-
a.ko.Spec.TrainingJobDefinition.EnableManagedSpotTraining = b.ko.Spec.TrainingJobDefinition.EnableManagedSpotTraining
37-
}
38-
39-
if ackcompare.IsNil(a.ko.Spec.TrainingJobDefinition.EnableNetworkIsolation) && ackcompare.IsNotNil(b.ko.Spec.TrainingJobDefinition.EnableNetworkIsolation) {
40-
a.ko.Spec.TrainingJobDefinition.EnableNetworkIsolation = b.ko.Spec.TrainingJobDefinition.EnableNetworkIsolation
41-
}
42-
43-
if ackcompare.IsNil(a.ko.Spec.TrainingJobDefinition.EnableInterContainerTrafficEncryption) && ackcompare.IsNotNil(b.ko.Spec.TrainingJobDefinition.EnableInterContainerTrafficEncryption) {
44-
a.ko.Spec.TrainingJobDefinition.EnableInterContainerTrafficEncryption = b.ko.Spec.TrainingJobDefinition.EnableInterContainerTrafficEncryption
45-
}
4634
}
4735
}

‎pkg/resource/hyper_parameter_tuning_job/manager.go

Lines changed: 31 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)