Skip to content

Commit 294af6d

Browse files
authored
Increase timeout for certain e2e status checks and re-order cleanup (#117)
Description of changes: - Some Canary e2e tests are failing with status mismatch ex: `Inprogress != Completed`, even though the jobs will eventually pass. - Reached out to service teams for investigation in what may be occurring on these jobs. - Some resources are order dependent for deletion ex: Cannot delete an `endpoint` if it has a `monitoringSchedule` applied to it. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 9c89f23 commit 294af6d

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

test/canary/scripts/run_test.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ function print_controller_logs() {
3030
function cleanup {
3131
echo "Cleaning up resources"
3232
set +e
33+
kubectl delete monitoringschedules --all
3334
kubectl delete endpoints.sagemaker --all
3435
kubectl delete endpointconfigs --all
3536
kubectl delete models --all
@@ -41,11 +42,10 @@ function cleanup {
4142
kubectl delete modelbiasjobdefinitions --all
4243
kubectl delete modelexplainabilityjobdefinitions --all
4344
kubectl delete modelqualityjobdefinitions --all
44-
kubectl delete monitoringschedules --all
4545
kubectl delete adoptedresources --all
4646
kubectl delete featuregroups --all
47-
kubectl delete modelpackagegroups --all
4847
kubectl delete modelpackages --all
48+
kubectl delete modelpackagegroups --all
4949
kubectl delete notebookinstances --all
5050
kubectl delete notebookinstancelifecycleconfig --all
5151

test/e2e/tests/test_feature_group.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
FEATURE_GROUP_STATUS_CREATING = "Creating"
3838
FEATURE_GROUP_STATUS_CREATED = "Created"
3939
# longer wait is used because we sometimes see server taking time to create/delete
40-
WAIT_PERIOD_COUNT = 4
40+
WAIT_PERIOD_COUNT = 8
4141
WAIT_PERIOD_LENGTH = 30
4242
STATUS = "status"
4343
RESOURCE_STATUS = "featureGroupStatus"

test/e2e/tests/test_hpo.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def _wait_resource_hpo_status(
9191
self,
9292
reference: k8s.CustomResourceReference,
9393
expected_status: str,
94-
wait_periods: int = 30,
94+
wait_periods: int = 45,
9595
period_length: int = 30,
9696
):
9797
return wait_for_status(
@@ -106,7 +106,7 @@ def _wait_sagemaker_hpo_status(
106106
self,
107107
hpo_job_name,
108108
expected_status: str,
109-
wait_periods: int = 30,
109+
wait_periods: int = 45,
110110
period_length: int = 30,
111111
):
112112
return wait_for_status(

0 commit comments

Comments
 (0)