verify clud

Author: rushmash91

prow/agent-workflows/agents/ack_model_agent/prompt.py

@@ -26,7 +26,7 @@
 
 A. OPERATION ANALYSIS
 - Identify all available operations for the resource
-- Classify operations by type (create, read, update, delete, list, tag operations)
+- Classify operations by type (create, read, update, delete, tag operations)
 - Extract ALL input/output fields for each operation (not just shape names)
 - Document complete field structures including nested objects
 - Determine required vs optional parameters with constraints
@@ -67,14 +67,12 @@
 Create these comprehensive data structures with COMPLETE field analysis:
 
 # Core Operations Inventory
-In case there are multiple operations with the same name, choose the one that is most similar to the other operations. Prefer single resource operations over multiple resource operations unless that leads to a mismatch in the field names.
 operations_catalog = {
-    "create_operations": ["CreateRepository", "PutRepository"],
-    "read_operations": ["GetRepository", "DescribeRepository", "DescribeRepositories"],
-    "update_operations": ["UpdateRepository", "ModifyRepository"],
+    "create_operations": ["CreateRepository"],
+    "read_operations": ["GetRepository"], (prefer "Get" over "Describe")
+    "update_operations": ["UpdateRepository"],
     "delete_operations": ["DeleteRepository"],
-    "tag_operations": ["TagResource", "UntagResource", "GetTagsForResource"],
-    "other_operations": ["GetRepositoryPolicy", "SetRepositoryPolicy"]
+    "tag_operations": ["TagResource", "UntagResource", "GetTagsForResource"]
 }
 
 # Field Catalog with Classifications
@@ -220,12 +218,7 @@
 4. save_error_catalog(error_catalog, service, resource)
 5. save_resource_characteristics(resource_characteristics, service, resource)
 
-5. Report Analysis Summary
-- Operations discovered and classified
-- Field types and characteristics identified  
-- Error conditions cataloged
-- Resource behavior patterns noted
-- Data completeness assessment
+5. Report Analysis Summary - Small Summary of the the resource files
 
 Response Format:
 1. "Analyzing AWS {service} {resource} resource..."

prow/agent-workflows/agents/ack_model_agent/tools.py

@@ -48,13 +48,38 @@ def save_operations_catalog(operations_catalog: Dict[str, List[str]], service: s
     """Save comprehensive catalog of all operations related to the resource.
     
     Args:
-        operations_catalog: Dictionary mapping operation types to lists of operation names
+        operations_catalog: Dictionary with exactly these 5 keys:
+            - create_operations: List of operations that create the resource
+            - read_operations: List of operations that read the resource  
+            - update_operations: List of operations that update the resource
+            - delete_operations: List of operations that delete the resource
+            - tag_operations: List of operations that manage tags on the resource
         service: AWS service name (e.g., 's3', 'dynamodb')
         resource: Resource name (e.g., 'Bucket', 'Table')
         
     Returns:
         str: Confirmation message with file path where catalog was saved
     """
+    # Validate that operations_catalog has exactly the required 5 keys
+    required_keys = {"create_operations", "read_operations", "update_operations", "delete_operations", "tag_operations"}
+    provided_keys = set(operations_catalog.keys())
+    
+    if provided_keys != required_keys:
+        missing_keys = required_keys - provided_keys
+        extra_keys = provided_keys - required_keys
+        error_msg = f"Operations catalog must have exactly these 5 keys: {required_keys}."
+        if missing_keys:
+            error_msg += f" Missing: {missing_keys}."
+        if extra_keys:
+            error_msg += f" Extra: {extra_keys}."
+        return f"Error: {error_msg}"
+    
+    # Validate that first 4 keys have exactly 1 operation each
+    single_operation_keys = {"create_operations", "read_operations", "update_operations", "delete_operations"}
+    for key in single_operation_keys:
+        if len(operations_catalog[key]) != 1:
+            return f"Error: {key} must have exactly 1 operation, got {len(operations_catalog[key])}: {operations_catalog[key]}"
+    
     ensure_ack_directories()
     resource_dir = ensure_service_resource_directories(service, resource)
     cache_file = os.path.join(resource_dir, "operations_catalog.json")

prow/agent-workflows/agents/workflows/ack_resource_workflow.py

@@ -74,7 +74,7 @@ def _load_supported_services(self) -> List[str]:
         """Load the list of supported AWS services from jobs_config.yaml."""
         try:
             # Go up to test-infra root, then to prow/jobs/jobs_config.yaml
-            config_path = Path(__file__).parent.parent.parent.parent / "prow" / "jobs" / "jobs_config.yaml"
+            config_path = Path(__file__).parent.parent.parent.parent / "jobs" / "jobs_config.yaml"
 
             with open(config_path, 'r') as f:
                 config = yaml.safe_load(f)