Remove unnecessary/premature subcomponent build in CompositeComponent geometry (#63)

Author: gpeairs

CHANGELOG.md

@@ -7,6 +7,7 @@ The format of this changelog is based on
 ## Upcoming
 
   - Added `set_periodic!` to `SolidModels` to enable periodic meshes
+  - `CompositeComponent` geometry now preserves subcomponents instead of replacing them with `CoordinateSystem`s, unless `build!` is called explicitly on the composite component's schematic or the parent schematic
   - Minor documentation improvements
 
 ### Fixed

docs/src/examples/qpu17.md

@@ -20,7 +20,7 @@ nothing # hide
 <img src="../qpu17.png"/>
 ```
 
-Note that the timings above are around 90% compilation. If we wanted to tweak some parameters and then run the script again in the same Julia session, then it would take around 10% as long:
+Note that the timings above are around 95% compilation. If we wanted to tweak some parameters and then run the script again in the same Julia session, then it would take around 5% as long:
 
 ```@example 1
 @time "Total" schematic, artwork = DemoQPU17.qpu17_demo(savegds=false)

src/schematics/ExamplePDK/components/Transmons/star_island.jl

@@ -151,3 +151,20 @@ function SchematicDrivenLayout.hooks(isl::ExampleStarIsland)
         z=HandedPointHook(rotate(h, π / 2))
     )
 end
+
+# Define custom exclusion zone/footprint
+function DeviceLayout.halo(
+    isl::ExampleStarIsland,
+    outer_delta,
+    inner_delta=nothing;
+    kwargs...
+)
+    c = to_polygons(footprint(isl))
+    temp_cs = CoordinateSystem{coordinatetype(isl)}(uniquename(name(isl)))
+    place!(temp_cs, c, first(geometry(isl).element_metadata))
+    return halo(temp_cs, outer_delta, inner_delta; kwargs...)
+end
+
+function DeviceLayout.footprint(isl::ExampleStarIsland)
+    return Circle(isl.island_outer_radius + isl.island_ground_gap)
+end

src/schematics/components/composite_components.jl

@@ -95,7 +95,7 @@ function _graph! end
 """
     geometry(cc:AbstractCompositeComponent)
 
-Return the `CoordinateSystem` resulting from `build!(plan(graph(cc)))`.
+Return the `CoordinateSystem` resulting from `plan(graph(cc)).coordinate_system`.
 """
 function geometry(cc::AbstractCompositeComponent)
     return geometry_from_graph(cc)
@@ -112,18 +112,14 @@ function schematic(cc::AbstractCompositeComponent)
     for (k, v) in pairs(floorplan.ref_dict)
         cc._schematic.ref_dict[k] = v
     end
+    cc._schematic.checked[] = true # Skip check
     return cc._schematic
 end
 
 const COMPOSITE_NODE_ID_SEPARATOR = "__"
 
 function geometry_from_graph(cc::AbstractCompositeComponent)
-    floorplan = schematic(cc)
-    if !floorplan.checked[]
-        floorplan.checked[] = true # Skip check
-        build!(floorplan)
-    end
-    return floorplan.coordinate_system
+    return schematic(cc).coordinate_system
 end
 
 compose_hookname(cc::AbstractCompositeComponent, i::Int, h::Symbol) =

src/schematics/schematics.jl

@@ -1325,6 +1325,9 @@ function build!(sch::Schematic, geometry_fn=geometry; strict=:error)
             node_cs = structure(ref)
             # One of the node cs's references will be its Component
             for (i, subref) in pairs(refs(node_cs)) # Just check all of them
+                if structure(subref) isa AbstractCompositeComponent
+                    build!(schematic(structure(subref)))
+                end
                 if structure(subref) isa AbstractComponent
                     try
                         refs(node_cs)[i] =