Skip physical groups with no entities in check_overlap (#71)

Author: simlapointe

src/solidmodels/postrender.jl

@@ -1003,9 +1003,13 @@ Return the overlapping groups as a vector of `(group1, group2, dimension)` `Tupl
 function check_overlap(sm::SolidModel)
     overlapping_groups = Tuple{String, String, Int}[]
     for dim = 1:3
-        for (name1, _) in SolidModels.dimgroupdict(sm, dim)
-            for (name2, _) in SolidModels.dimgroupdict(sm, dim)
+        for (name1, pg1) in SolidModels.dimgroupdict(sm, dim)
+            for (name2, pg2) in SolidModels.dimgroupdict(sm, dim)
                 name1 >= name2 && continue
+                (
+                    isempty(SolidModels.entitytags(pg1)) ||
+                    isempty(SolidModels.entitytags(pg2))
+                ) && continue
                 intersections = intersect_geom!(sm, name1, name2, dim, dim)
                 for intersection in intersections
                     if intersection[1] > dim - 1

test/test_solidmodel.jl

@@ -1058,6 +1058,20 @@ import DeviceLayout.SolidModels.STP_UNIT
     render!(sm, cs)
     @test isempty(SolidModels.check_overlap(sm))
 
+    cs = CoordinateSystem("test", nm)
+    place!(cs, r1, SemanticMeta(Symbol("r1")))
+    place!(cs, r2, SemanticMeta(Symbol("r2")))
+    postrender_ops = [(
+        "r2",
+        SolidModels.difference_geom!,
+        ("r2", "r2", 2, 2),
+        :remove_object => true,
+        :remove_tool => true
+    )]
+    sm = test_sm()
+    render!(sm, cs; postrender_ops=postrender_ops)
+    @test isempty(SolidModels.check_overlap(sm))
+
     # TODO: Composing OptionalStyle
 
     # Explicitly MeshSized Path.