Fixes for Rounded style with ClippedPolygon #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
gpeairs
reviewed
Nov 25, 2025
src/curvilinear.jl
Outdated
| !isnothing(idx) && return idx | ||
| return findmin(norm.(p.p[valid_ind] .- px))[2] | ||
| end] | ||
| # Pick the closest to p0 satisfying tolerance. |
Member
There was a problem hiding this comment.
Is it possible to call cornerindices(p::Vector{<:Point}, p0::Vector{<:Point}; tol) here and then check against or map back to valid indices? I'm nervous about the selection code not being shared.
Contributor
Author
There was a problem hiding this comment.
Good idea. I just attempted it in 611f726 but it's breaking some tests for me locally, don't merge it just yet.
gpeairs
reviewed
Nov 25, 2025
src/curvilinear.jl
Outdated
| return d < tol ? idx : -1 | ||
| end | ||
| )] | ||
| return isempty(valid_ind) ? Int[] : cornerindices(p.p[valid_ind], p0; tol) |
Member
There was a problem hiding this comment.
Should the last part be valid_ind[cornerindices(p.p[valid_ind], p0; tol)]?
…for backwards compatibility
…ethod with selector
hughcars
force-pushed
the
hughcars/rounded-style-selector-dev
branch
from
07bd8f9 to
fa645d5
Compare
Contributor
Author
|
Rebased on top of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115 and introduces
selection_toleranceto resolve #114.