Enhance solidmodel boundary methods #56
Conversation
simlapointe
commented
May 22, 2025
simlapointe
commented
- Enhance the SolidModel get_boundary method to optionally return only boundaries perpendicular to specified directions and only at the min/max position along the specified direction. This is useful if the user wishes to apply different boundary conditions on different exterior boundary faces.
- Introduce the set_periodic method to make the mesh on the specified groups periodic. Currently only supports 2D groups representing parallel axis-aligned surfaces (i.e. can only apply periodicity in the X, Y, or Z direction).
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
gpeairs
left a comment
gpeairs
left a comment
There was a problem hiding this comment.
Looks good, just a couple minor comments!
src/solidmodels/postrender.jl
Outdated
| end | ||
|
|
||
| """ | ||
| set_periodic!(group1::AbstractPhyiscalGroup, group2::AbstractPhyiscalGroup; dim=2) |
src/solidmodels/postrender.jl
Outdated
| end | ||
| end | ||
|
|
||
| function get_physical_group_bounding_box(dim, tags) |
There was a problem hiding this comment.
Just checking, tags should be entity tags, not physical group tags, right? I would just call it get_bounding_box.
There was a problem hiding this comment.
Correct, they should be entity tags. I renamed the function as you suggested.
There was a problem hiding this comment.
Just remembered there's also a function SolidModels.bounds3d with a slightly different interface, oops. There's a docstring but it's not in the HTML docs yet (adding it as part of #58).
There was a problem hiding this comment.
Oh my bad, thanks for catching that. I will remove get_bounding_box and use SolidModels.bounds3d instead. I'll open another PR for the change.
simlapointe
force-pushed
the
simlapointe/sm-boundary-periodic
branch
from
d7573a1 to
2f4d74f
Compare
2 participants
