fix: Add or forward entity interface methods for StyledEntity #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
ybrightye
approved these changes
Jun 6, 2025
ybrightye
left a comment
ybrightye
left a comment
There was a problem hiding this comment.
I've tested the changes locally and everything works as expected. The code looks good and should be approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the GeometryEntityStyle doctring, "Unless implemented by the style,
lowerleftandupperright(and hencebounds) of a styled entity will use the underlying entity's bounds." This wasn't actually true, but now it is. The other GeometryEntity interface methods,footprintandhalo, were not mentioned, but they now also forward to the underlying entity except where specialized on the style.Previously,
to_polygonswas called first, meaningNoRenderled to zero bounds / empty entity list andOptionalStyleapplied its default style (most relevantly for NoRender). These are the correct behaviors, but because they are different from the fallback they are now implemented as specializations to the GeometryEntity interface methods.