Merge pull request #10 from aws-github-ops/emptyFix

fix: submitting an empty array for labels or assignees is now accepted

Author: peterwoodworth

lib/index.js

@@ -28001,11 +28001,15 @@ class GithubApi {
     }
     setIssueAssignees(assignees) {
         return __awaiter(this, void 0, void 0, function* () {
+            if (!assignees.length)
+                return;
             yield this.octokit.issues.addAssignees(Object.assign(Object.assign({}, this.repo), { issue_number: this.issueNumber, assignees }));
         });
     }
     setIssueLabels(labels) {
         return __awaiter(this, void 0, void 0, function* () {
+            if (!labels.length)
+                return;
             yield this.octokit.issues.addLabels(Object.assign(Object.assign({}, this.repo), { issue_number: this.issueNumber, labels }));
         });
     }
@@ -28074,8 +28078,10 @@ function run() {
             console.log("Keywords not included in this issue");
         }
         else {
-            github.setIssueAssignees(winningAreaData.assignees);
-            github.setIssueLabels(winningAreaData.labels);
+            if (winningAreaData.assignees)
+                github.setIssueAssignees(winningAreaData.assignees);
+            if (winningAreaData.labels)
+                github.setIssueLabels(winningAreaData.labels);
             core.setOutput("labeled", true.toString());
             core.setOutput("assigned", true.toString());
         }

src/github.ts

@@ -26,6 +26,7 @@ export class GithubApi {
   }
 
   public async setIssueAssignees(assignees: string[]) {
+    if(!assignees.length) return;
     await this.octokit.issues.addAssignees({
       ...this.repo,
       issue_number: this.issueNumber,
@@ -34,6 +35,7 @@ export class GithubApi {
   }
 
   public async setIssueLabels(labels: string[]) {
+    if(!labels.length) return;
     await this.octokit.issues.addLabels({
       ...this.repo,
       issue_number: this.issueNumber,

src/index.ts

@@ -15,8 +15,8 @@ async function run() {
   if (winningAreaData.area === '') { 
     console.log("Keywords not included in this issue");
   } else {
-    github.setIssueAssignees(winningAreaData.assignees);
-    github.setIssueLabels(winningAreaData.labels);
+    if(winningAreaData.assignees) github.setIssueAssignees(winningAreaData.assignees);
+    if(winningAreaData.labels) github.setIssueLabels(winningAreaData.labels);
     core.setOutput("labeled", true.toString());
     core.setOutput("assigned", true.toString());
   }

src/issue.ts

@@ -1,11 +1,14 @@
 import * as core from "@actions/core";
 import levenshtein from 'js-levenshtein';
 
-export interface IParameter {
+export interface IParameter extends IDefaultArea {
   area: string;
   keywords: string[];
-  labels: string[];
-  assignees: string[];
+}
+
+export interface IDefaultArea {
+  labels?: string[];
+  assignees?: string[];
 }
 
 export class Issue {