Remove leading slash when composing URL paths

aws-gopher · aws-gopher · commit 1b61a4174bdb · 2025-08-20T13:40:20.000-04:00
diff --git a/bearer.go b/bearer.go
@@ -9,9 +9,12 @@ type bearer struct {
 	rt  http.RoundTripper
 }
 
+// HeaderKey is "Unstructured-API-Key", which is the header where Unstructured expects to find the API key.
+const HeaderKey = "Unstructured-API-Key"
+
 // RoundTrip implements the http.RoundTripper interface.
 func (b *bearer) RoundTrip(req *http.Request) (*http.Response, error) {
-	req.Header.Set("Unstructured-API-Key", b.key)
+	req.Header.Set(HeaderKey, b.key)
 
 	// This is implementing the http.RoundTripper interface, errors should be passed through as-is
 	return b.rt.RoundTrip(req) //nolint:wrapcheck
diff --git a/destination_connection_check.go b/destination_connection_check.go
@@ -11,7 +11,7 @@ import (
 func (c *Client) CreateDestinationConnectionCheck(ctx context.Context, id string) (*DagNodeConnectionCheck, error) {
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodPost,
-		c.endpoint.JoinPath("/destinations", id, "connection-check").String(),
+		c.endpoint.JoinPath("destinations", id, "connection-check").String(),
 		nil,
 	)
 	if err != nil {
@@ -31,7 +31,7 @@ func (c *Client) CreateDestinationConnectionCheck(ctx context.Context, id string
 func (c *Client) GetDestinationConnectionCheck(ctx context.Context, id string) (*DagNodeConnectionCheck, error) {
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodGet,
-		c.endpoint.JoinPath("/destinations", id, "connection-check").String(),
+		c.endpoint.JoinPath("destinations", id, "connection-check").String(),
 		nil,
 	)
 	if err != nil {
diff --git a/destination_create.go b/destination_create.go
@@ -33,7 +33,7 @@ func (c *Client) CreateDestination(ctx context.Context, in CreateDestinationRequ
 
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodPost,
-		c.endpoint.JoinPath("/destinations/").String(),
+		c.endpoint.JoinPath("destinations/").String(),
 		bytes.NewReader(body),
 	)
 	if err != nil {
diff --git a/destination_delete.go b/destination_delete.go
@@ -10,7 +10,7 @@ import (
 func (c *Client) DeleteDestination(ctx context.Context, id string) error {
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodDelete,
-		c.endpoint.JoinPath("/destinations", id).String(),
+		c.endpoint.JoinPath("destinations", id).String(),
 		nil,
 	)
 	if err != nil {
diff --git a/destination_get.go b/destination_get.go
@@ -10,7 +10,7 @@ import (
 func (c *Client) GetDestination(ctx context.Context, id string) (*Destination, error) {
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodGet,
-		c.endpoint.JoinPath("/destinations", id).String(),
+		c.endpoint.JoinPath("destinations", id).String(),
 		nil,
 	)
 	if err != nil {
diff --git a/destination_list.go b/destination_list.go
@@ -10,7 +10,7 @@ import (
 func (c *Client) ListDestinations(ctx context.Context, typ string) ([]Destination, error) {
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodGet,
-		c.endpoint.JoinPath("/destinations").String(),
+		c.endpoint.JoinPath("destinations").String(),
 		nil,
 	)
 	if err != nil {
diff --git a/destination_update.go b/destination_update.go
@@ -35,7 +35,7 @@ func (c *Client) UpdateDestination(ctx context.Context, in UpdateDestinationRequ
 
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodPut,
-		c.endpoint.JoinPath("/destinations", in.ID).String(),
+		c.endpoint.JoinPath("destinations", in.ID).String(),
 		bytes.NewReader(body),
 	)
 	if err != nil {
diff --git a/job_cancel.go b/job_cancel.go
@@ -10,7 +10,7 @@ import (
 func (c *Client) CancelJob(ctx context.Context, id string) error {
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodPost,
-		c.endpoint.JoinPath("/jobs", id, "cancel").String(),
+		c.endpoint.JoinPath("jobs", id, "cancel").String(),
 		nil,
 	)
 	if err != nil {
diff --git a/job_details.go b/job_details.go
@@ -11,7 +11,7 @@ import (
 func (c *Client) GetJobDetails(ctx context.Context, id string) (*JobDetails, error) {
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodGet,
-		c.endpoint.JoinPath("/jobs", id, "details").String(),
+		c.endpoint.JoinPath("jobs", id, "details").String(),
 		nil,
 	)
 	if err != nil {
diff --git a/job_download.go b/job_download.go
@@ -18,7 +18,7 @@ type DownloadJobRequest struct {
 func (c *Client) DownloadJob(ctx context.Context, in DownloadJobRequest) (io.ReadCloser, error) {
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodGet,
-		c.endpoint.JoinPath("/jobs", in.JobID, "download").String(),
+		c.endpoint.JoinPath("jobs", in.JobID, "download").String(),
 		nil,
 	)
 	if err != nil {
diff --git a/job_failed_files.go b/job_failed_files.go
@@ -11,7 +11,7 @@ import (
 func (c *Client) GetJobFailedFiles(ctx context.Context, id string) (*JobFailedFiles, error) {
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodGet,
-		c.endpoint.JoinPath("/jobs", id, "failed-files").String(),
+		c.endpoint.JoinPath("jobs", id, "failed-files").String(),
 		nil,
 	)
 	if err != nil {
diff --git a/job_get.go b/job_get.go
@@ -10,7 +10,7 @@ import (
 func (c *Client) GetJob(ctx context.Context, id string) (*Job, error) {
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodGet,
-		c.endpoint.JoinPath("/jobs", id).String(),
+		c.endpoint.JoinPath("jobs", id).String(),
 		nil,
 	)
 	if err != nil {
diff --git a/job_list.go b/job_list.go
@@ -16,7 +16,7 @@ type ListJobsRequest struct {
 func (c *Client) ListJobs(ctx context.Context, in *ListJobsRequest) ([]Job, error) {
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodGet,
-		c.endpoint.JoinPath("/jobs").String(),
+		c.endpoint.JoinPath("jobs", "").String(),
 		nil,
 	)
 	if err != nil {
diff --git a/source_connection_check.go b/source_connection_check.go
@@ -11,7 +11,7 @@ import (
 func (c *Client) CreateSourceConnectionCheck(ctx context.Context, id string) (*DagNodeConnectionCheck, error) {
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodPost,
-		c.endpoint.JoinPath("/sources", id, "connection-check").String(),
+		c.endpoint.JoinPath("sources", id, "connection-check").String(),
 		nil,
 	)
 	if err != nil {
@@ -31,7 +31,7 @@ func (c *Client) CreateSourceConnectionCheck(ctx context.Context, id string) (*D
 func (c *Client) GetSourceConnectionCheck(ctx context.Context, id string) (*DagNodeConnectionCheck, error) {
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodGet,
-		c.endpoint.JoinPath("/sources", id, "connection-check").String(),
+		c.endpoint.JoinPath("sources", id, "connection-check").String(),
 		nil,
 	)
 	if err != nil {
diff --git a/source_create.go b/source_create.go
@@ -47,7 +47,7 @@ func (c *Client) CreateSource(ctx context.Context, in CreateSourceRequest) (*Sou
 
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodPost,
-		c.endpoint.JoinPath("/sources/").String(),
+		c.endpoint.JoinPath("sources/").String(),
 		bytes.NewReader(body),
 	)
 	if err != nil {
diff --git a/source_delete.go b/source_delete.go
@@ -10,7 +10,7 @@ import (
 func (c *Client) DeleteSource(ctx context.Context, id string) error {
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodDelete,
-		c.endpoint.JoinPath("/sources", id).String(),
+		c.endpoint.JoinPath("sources", id).String(),
 		nil,
 	)
 	if err != nil {
diff --git a/source_get.go b/source_get.go
@@ -10,7 +10,7 @@ import (
 func (c *Client) GetSource(ctx context.Context, id string) (*Source, error) {
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodGet,
-		c.endpoint.JoinPath("/sources", id).String(),
+		c.endpoint.JoinPath("sources", id).String(),
 		nil,
 	)
 	if err != nil {
diff --git a/source_list.go b/source_list.go
@@ -10,7 +10,7 @@ import (
 func (c *Client) ListSources(ctx context.Context, typ string) ([]Source, error) {
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodGet,
-		c.endpoint.JoinPath("/sources").String(),
+		c.endpoint.JoinPath("sources").String(),
 		nil,
 	)
 	if err != nil {
diff --git a/source_update.go b/source_update.go
@@ -35,7 +35,7 @@ func (c *Client) UpdateSource(ctx context.Context, in UpdateSourceRequest) (*Sou
 
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodPut,
-		c.endpoint.JoinPath("/sources", in.ID).String(),
+		c.endpoint.JoinPath("sources", in.ID).String(),
 		bytes.NewReader(body),
 	)
 	if err != nil {
diff --git a/test/main.go b/test/main.go
@@ -63,7 +63,12 @@ func NewMux() *Mux {
 			if f != nil && *f != nil {
 				(*f)(w, r)
 			} else {
-				w.WriteHeader(http.StatusMethodNotAllowed)
+				var msg string
+				if r.Pattern != "" {
+					msg = "handler for " + r.Pattern + " is nil"
+				}
+
+				http.Error(w, msg, http.StatusMethodNotAllowed)
 			}
 		}
 	}
diff --git a/workflow_create.go b/workflow_create.go
@@ -28,7 +28,7 @@ func (c *Client) CreateWorkflow(ctx context.Context, in *CreateWorkflowRequest)
 
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodPost,
-		c.endpoint.JoinPath("/workflows/").String(),
+		c.endpoint.JoinPath("workflows/").String(),
 		bytes.NewReader(body),
 	)
 	if err != nil {
diff --git a/workflow_delete.go b/workflow_delete.go
@@ -10,7 +10,7 @@ import (
 func (c *Client) DeleteWorkflow(ctx context.Context, id string) error {
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodDelete,
-		c.endpoint.JoinPath("/workflows", id).String(),
+		c.endpoint.JoinPath("workflows", id).String(),
 		nil,
 	)
 	if err != nil {
diff --git a/workflow_get.go b/workflow_get.go
@@ -10,7 +10,7 @@ import (
 func (c *Client) GetWorkflow(ctx context.Context, id string) (*Workflow, error) {
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodGet,
-		c.endpoint.JoinPath("/workflows", id).String(),
+		c.endpoint.JoinPath("workflows", id).String(),
 		nil,
 	)
 	if err != nil {
diff --git a/workflow_list.go b/workflow_list.go
@@ -30,7 +30,7 @@ type ListWorkflowsRequest struct {
 func (c *Client) ListWorkflows(ctx context.Context, in *ListWorkflowsRequest) ([]Workflow, error) {
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodGet,
-		c.endpoint.JoinPath("/workflows").String(),
+		c.endpoint.JoinPath("workflows").String(),
 		nil,
 	)
 	if err != nil {
diff --git a/workflow_run.go b/workflow_run.go
@@ -42,7 +42,7 @@ func (f *FileBytes) Read(p []byte) (n int, err error) {
 func (c *Client) RunWorkflow(ctx context.Context, in *RunWorkflowRequest) (*Job, error) {
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodPost,
-		c.endpoint.JoinPath("/workflows", in.ID, "run").String(),
+		c.endpoint.JoinPath("workflows", in.ID, "run").String(),
 		nil,
 	)
 	if err != nil {
diff --git a/workflow_update.go b/workflow_update.go
@@ -30,7 +30,7 @@ func (c *Client) UpdateWorkflow(ctx context.Context, in UpdateWorkflowRequest) (
 
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodPut,
-		c.endpoint.JoinPath("/workflows", in.ID).String(),
+		c.endpoint.JoinPath("workflows", in.ID).String(),
 		bytes.NewReader(body),
 	)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ func (c *Client) CreateDestination(ctx context.Context, in CreateDestinationRequ`
`33`	`33`
`34`	`34`	`req, err := http.NewRequestWithContext(ctx,`
`35`	`35`	`http.MethodPost,`
`36`		`- c.endpoint.JoinPath("/destinations/").String(),`
	`36`	`+ c.endpoint.JoinPath("destinations/").String(),`
`37`	`37`	`bytes.NewReader(body),`
`38`	`38`	`)`
`39`	`39`	`if err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ import (`
`10`	`10`	`func (c *Client) DeleteDestination(ctx context.Context, id string) error {`
`11`	`11`	`req, err := http.NewRequestWithContext(ctx,`
`12`	`12`	`http.MethodDelete,`
`13`		`- c.endpoint.JoinPath("/destinations", id).String(),`
	`13`	`+ c.endpoint.JoinPath("destinations", id).String(),`
`14`	`14`	`nil,`
`15`	`15`	`)`
`16`	`16`	`if err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ func (c *Client) UpdateDestination(ctx context.Context, in UpdateDestinationRequ`
`35`	`35`
`36`	`36`	`req, err := http.NewRequestWithContext(ctx,`
`37`	`37`	`http.MethodPut,`
`38`		`- c.endpoint.JoinPath("/destinations", in.ID).String(),`
	`38`	`+ c.endpoint.JoinPath("destinations", in.ID).String(),`
`39`	`39`	`bytes.NewReader(body),`
`40`	`40`	`)`
`41`	`41`	`if err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ import (`
`11`	`11`	`func (c Client) GetJobDetails(ctx context.Context, id string) (JobDetails, error) {`
`12`	`12`	`req, err := http.NewRequestWithContext(ctx,`
`13`	`13`	`http.MethodGet,`
`14`		`- c.endpoint.JoinPath("/jobs", id, "details").String(),`
	`14`	`+ c.endpoint.JoinPath("jobs", id, "details").String(),`
`15`	`15`	`nil,`
`16`	`16`	`)`
`17`	`17`	`if err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ type DownloadJobRequest struct {`
`18`	`18`	`func (c *Client) DownloadJob(ctx context.Context, in DownloadJobRequest) (io.ReadCloser, error) {`
`19`	`19`	`req, err := http.NewRequestWithContext(ctx,`
`20`	`20`	`http.MethodGet,`
`21`		`- c.endpoint.JoinPath("/jobs", in.JobID, "download").String(),`
	`21`	`+ c.endpoint.JoinPath("jobs", in.JobID, "download").String(),`
`22`	`22`	`nil,`
`23`	`23`	`)`
`24`	`24`	`if err != nil {`