Implement operation unit tests to mirror the Python SDK

- Added tests for creating, updating, deleting, and retrieving sources, destinations, workflows, and jobs.
- Implemented API error handling with the new `APIError` type.
- Updated `CreateSource` and `CreateDestination` methods to ensure correct endpoint paths (with trailing slash).
- Updated `CreateWorkflowRequest` to accept a pointer to the request type for consistency.
- Implemented tests with assertions mirroring the Python SDK.

Author: aws-gopher

.golangci.yml

@@ -58,9 +58,14 @@ linters:
       check-type-assertions: false
       exclude-functions:
         - io/ioutil.ReadFile
-        - io.Copy(*bytes.Buffer)
-        - io.Copy(os.Stdout)
+        - io.Copy
         - (io.Closer).Close
+        - (net/http.ResponseWriter).Write
+        - io.Writer.Write
+    gosec:
+      excludes:
+      - G101
+      - G104
 
 # Issues configuration
 issues:

client.go

@@ -3,6 +3,7 @@ package unstructured
 import (
 	"cmp"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io"
 	"net/http"
@@ -123,11 +124,17 @@ func (c *Client) do(req *http.Request, out any) error {
 		if resp.StatusCode == http.StatusUnprocessableEntity {
 			var validationErr HTTPValidationError
 			if err := json.Unmarshal(body, &validationErr); err == nil {
-				return &validationErr
+				return &APIError{
+					Code: resp.StatusCode,
+					Err:  &validationErr,
+				}
 			}
 		}
 
-		return fmt.Errorf("[%s]: %s", resp.Status, string(body))
+		return &APIError{
+			Code: resp.StatusCode,
+			Err:  errors.New(string(body)),
+		}
 	}
 
 	if out != nil {

client_test.go

@@ -0,0 +1,40 @@
+package unstructured
+
+import (
+	"net/http"
+	"net/http/httptest"
+	"testing"
+
+	"github.com/aws-gopher/unstructured-sdk-go/test"
+)
+
+func testclient(t *testing.T) (*Client, *test.Mux) {
+	mux := test.NewMux()
+
+	server := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		val := r.Header.Get("unstructured-api-key")
+		if val == "" {
+			http.Error(w, "Unauthorized: missing header", http.StatusUnauthorized)
+			return
+		}
+
+		if val != test.FakeAPIKey {
+			http.Error(w, "Unauthorized: invalid key", http.StatusUnauthorized)
+			return
+		}
+
+		mux.ServeHTTP(w, r)
+	}))
+	t.Cleanup(server.Close)
+
+	c, err := New(
+		WithClient(server.Client()),
+		WithEndpoint(server.URL),
+		WithKey(test.FakeAPIKey),
+	)
+	if err != nil {
+		t.Fatalf("failed to create client: %v", err)
+	}
+
+	return c, mux
+}

destination_create.go

@@ -33,7 +33,7 @@ func (c *Client) CreateDestination(ctx context.Context, in CreateDestinationRequ
 
 	req, err := http.NewRequestWithContext(ctx,
 		http.MethodPost,
-		c.endpoint.JoinPath("/destinations").String(),
+		c.endpoint.JoinPath("/destinations/").String(),
 		bytes.NewReader(body),
 	)
 	if err != nil {
@@ -54,7 +54,6 @@ func (c *Client) CreateDestination(ctx context.Context, in CreateDestinationRequ
 // It contains the name, type, and configuration for the destination.
 type CreateDestinationRequest struct {
 	Name   string
-	Type   string
 	Config DestinationConfigInput
 }
 

destination_create_test.go

@@ -0,0 +1,60 @@
+package unstructured
+
+import (
+	"errors"
+	"net/http"
+	"strconv"
+	"testing"
+	"time"
+)
+
+func TestCreateDestination(t *testing.T) {
+	t.Parallel()
+
+	client, mux := testclient(t)
+
+	mux.CreateDestination = func(w http.ResponseWriter, _ *http.Request) {
+		response := []byte(`{` +
+			`  "config": {` +
+			`    "remote_url": "s3://mock-s3-connector",` +
+			`    "key": "blah",` +
+			`    "secret": "blah",` +
+			`    "anonymous": false` +
+			`  },` +
+			`  "created_at": "2023-09-15T01:06:53.146Z",` +
+			`  "id": "b25d4161-77a0-4e08-b65e-86f398ce15ad",` +
+			`  "name": "test_destination_name",` +
+			`  "type": "s3"` +
+			`}`)
+
+		w.Header().Set("Content-Type", "application/json")
+		w.Header().Set("Content-Length", strconv.Itoa(len(response)))
+		w.Write(response)
+	}
+
+	destination, err := client.CreateDestination(t.Context(), CreateDestinationRequest{
+		Name: "test_destination_name",
+
+		Config: &S3DestinationConnectorConfigInput{
+			RemoteURL: "s3://mock-s3-connector",
+			Key:       String("blah"),
+			Secret:    String("blah"),
+		},
+	})
+	if err != nil {
+		t.Fatalf("failed to create destination: %v", err)
+	}
+
+	if err := errors.Join(
+		eq("destination.id", destination.ID, "b25d4161-77a0-4e08-b65e-86f398ce15ad"),
+		eq("destination.name", destination.Name, "test_destination_name"),
+		equal("destination.created_at", destination.CreatedAt, time.Date(2023, 9, 15, 1, 6, 53, 146000000, time.UTC)),
+	); err != nil {
+		t.Error(err)
+	}
+
+	cfg, ok := destination.Config.(*S3DestinationConnectorConfig)
+	if !ok {
+		t.Errorf("expected destination config to be %T, got %T", cfg, destination.Config)
+	}
+}

destination_delete_test.go

@@ -0,0 +1,34 @@
+package unstructured
+
+import (
+	"net/http"
+	"strconv"
+	"testing"
+)
+
+func TestDeleteDestination(t *testing.T) {
+	t.Parallel()
+
+	client, mux := testclient(t)
+
+	id := "b25d4161-77a0-4e08-b65e-86f398ce15ad"
+
+	mux.DeleteDestination = func(w http.ResponseWriter, r *http.Request) {
+		if val := r.PathValue("id"); val != id {
+			http.Error(w, "destination ID "+val+" not found", http.StatusNotFound)
+			return
+		}
+
+		response := []byte(`{"detail": "Destination with id ` + id + ` successfully deleted."}`)
+
+		w.Header().Set("Content-Type", "application/json")
+		w.Header().Set("Content-Length", strconv.Itoa(len(response)))
+		w.WriteHeader(http.StatusOK)
+		w.Write(response)
+	}
+
+	err := client.DeleteDestination(t.Context(), "b25d4161-77a0-4e08-b65e-86f398ce15ad")
+	if err != nil {
+		t.Fatalf("failed to delete destination: %v", err)
+	}
+}

destination_get_test.go

@@ -0,0 +1,86 @@
+package unstructured
+
+import (
+	"errors"
+	"net/http"
+	"strconv"
+	"testing"
+	"time"
+)
+
+func TestGetDestination(t *testing.T) {
+	t.Parallel()
+
+	client, mux := testclient(t)
+
+	id := "0c363dec-3c70-45ee-8041-481044a6e1cc"
+	mux.GetDestination = func(w http.ResponseWriter, r *http.Request) {
+		if val := r.PathValue("id"); val != id {
+			http.Error(w, "destination ID "+val+" not found", http.StatusNotFound)
+			return
+		}
+
+		response := []byte(`{` +
+			`  "config": {` +
+			`    "remote_url": "s3://mock-s3-connector",` +
+			`    "anonymous": false,` +
+			`    "key": "**********",` +
+			`    "secret": "**********",` +
+			`    "token": null,` +
+			`    "endpoint_url": null` +
+			`  },` +
+			`  "created_at": "2025-08-22T08:47:29.802Z",` +
+			`  "id": "` + id + `",` +
+			`  "name": "test_destination_name",` +
+			`  "type": "s3"` +
+			`}`)
+
+		w.Header().Set("Content-Type", "application/json")
+		w.Header().Set("Content-Length", strconv.Itoa(len(response)))
+		w.Write(response)
+	}
+
+	destination, err := client.GetDestination(t.Context(), id)
+	if err != nil {
+		t.Fatalf("failed to get destination: %v", err)
+	}
+
+	if err := errors.Join(
+		eq("destination.id", destination.ID, id),
+		eq("destination.name", destination.Name, "test_destination_name"),
+		eq("destination.type", destination.Type, "s3"),
+		equal("destination.created_at", destination.CreatedAt, time.Date(2025, 8, 22, 8, 47, 29, 802000000, time.UTC)),
+	); err != nil {
+		t.Error(err)
+	}
+
+	cfg, ok := destination.Config.(*S3DestinationConnectorConfig)
+	if !ok {
+		t.Errorf("expected destination config to be %T, got %T", cfg, destination.Config)
+	}
+}
+
+func TestGetDestinationNotFound(t *testing.T) {
+	t.Parallel()
+
+	client, mux := testclient(t)
+
+	id := "0c363dec-3c70-45ee-8041-481044a6e1cc"
+	mux.GetDestination = func(w http.ResponseWriter, r *http.Request) {
+		http.Error(w, "destination ID "+r.PathValue("id")+" not found", http.StatusNotFound)
+	}
+
+	_, err := client.GetDestination(t.Context(), id)
+	if err == nil {
+		t.Fatalf("expected error, got nil")
+	}
+
+	var apierr *APIError
+	if !errors.As(err, &apierr) {
+		t.Fatalf("expected error to be an %T, got %T", apierr, err)
+	}
+
+	if apierr.Code != http.StatusNotFound {
+		t.Fatalf("expected error code to be %d, got %d", http.StatusNotFound, apierr.Code)
+	}
+}