Skip to content

Commit b0e03a9

Browse files
committed
Addressing feedback from PR adding some comments
1 parent 4a28e2d commit b0e03a9

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

pet_clinic_billing_service/billing_service/views.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,9 @@ def list(self, request, pk=None):
175175
# Cache miss
176176
span.set_attribute("billing_summary_cache_hit", 0)
177177

178+
# Sleep to simulate high latency when there's a cache miss
178179
time.sleep(2)
180+
179181
billings = Billing.objects.all()
180182

181183
summary = {

pet_clinic_billing_service/create-metric-filters.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ LOG_GROUP_NAME="aws/spans"
55
REGION=${AWS_REGION:-us-east-1}
66
NAMESPACE="CustomBilling"
77

8+
# TODO: [@lnnofal] convert it to CDK and hooked up with other CDK stacks (for EKS)
89
echo "Creating log group if it doesn't exist..."
910
aws logs create-log-group --log-group-name "$LOG_GROUP_NAME" --region "$REGION" 2>/dev/null || echo "Log group already exists or creation failed"
1011

0 commit comments

Comments
 (0)