Skip to content

Commit 2883c2f

Browse files
committed
removing cwagent and updated views
1 parent 3807ca9 commit 2883c2f

File tree

4 files changed

+42
-52
lines changed

4 files changed

+42
-52
lines changed

sample-apps/python/django_frontend_service/frontend_service_app/views.py

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424

2525
# Initialize custom OTEL metrics export pipeline - OTLP approach (OTEL/Span export 1) Agent based
2626
custom_resource = Resource.create({
27-
"service.name": os.getenv("OTEL_SERVICE_NAME", "python-sample-application"),
28-
"deployment.environment.name": os.getenv("DEPLOYMENT_ENV", "test"),
27+
"service.name": "OTEL_SERVICE_NAME",
28+
"deployment.environment.name": "custom_export",
2929
#"test" being overridden by python-sample-application-${var.test_id} in main.tf
3030
})
3131
custom_otlp_exporter = OTLPMetricExporter(
@@ -46,41 +46,38 @@
4646

4747
# Custom Export Pipeline - HTTP Direct
4848
resource = Resource.create({
49-
"service.name": os.getenv("OTEL_SERVICE_NAME", "python-sample-application"),
50-
"deployment.environment.name": os.getenv("DEPLOYMENT_ENV", "test")
51-
})#"test" being overridden by python-sample-application-${var.test_id} in main.tf
49+
"service.name": "OTEL_SERVICE_NAME",
50+
"deployment.environment.name": "agent_export",
51+
})
5252

53-
# OtlpHttpMetricExporter.builder().setEndpoint().build()
53+
# Python version of 'OtlpHttpMetricExporter.builder().setEndpoint().build()'
5454
metricExporter = HTTPMetricExporter(
5555
endpoint="http://localhost:4318/v1/metrics"
5656
)
5757

58-
# PeriodicMetricReader.builder(metricExporter).setInterval(Duration.ofSeconds(10)).build()
58+
# 'Python version of 'PeriodicMetricReader.builder(metricExporter).setInterval(Duration.ofSeconds(10)).build()'
5959
metricReader = PeriodicExportingMetricReader(
6060
exporter=metricExporter,
6161
export_interval_millis=5000
6262
)
6363

64-
# SdkMeterProvider.builder().setResource(resource).registerMetricReader(metricReader).build()
64+
# Python version of 'SdkMeterProvider.builder().setResource(resource).registerMetricReader(metricReader).build()'
6565
meterProvider = MeterProvider(
6666
resource=resource,
6767
metric_readers=[metricReader]
6868
)
6969

70-
# meterProvider.get("myMeter")
71-
meter = meterProvider.get_meter("myMeter")
72-
73-
7470
# Create meter provider with both exporters
7571
custom_meter_provider = MeterProvider(
7672
resource=custom_resource,
7773
metric_readers=[custom_otlp_reader, custom_console_reader]
7874
)
7975

80-
# Initialize span metrics using custom meter provider
76+
# Initialize counters/meters using custom meter provider. Python version of 'meterProvider.get("myMeter")'
8177
custom_meter = custom_meter_provider.get_meter("custom-metrics")
82-
custom_request_counter = custom_meter.create_counter("cloud_watch_counter", description="Total requests")
83-
http_counter = meter.create_counter("http_counter", description="Total requests")
78+
meter = meterProvider.get_meter("myMeter")
79+
custom_export_counter = custom_meter.create_counter("custom_export_counter", description="Total requests")
80+
agent_export_counter = meter.create_counter("agent_export_counter", description="Total requests")
8481

8582
should_send_local_root_client_call = False
8683
lock = threading.Lock()
@@ -117,8 +114,8 @@ def healthcheck(request):
117114

118115
def aws_sdk_call(request):
119116
# Setup Span Attributes And Initialize Counter/Histogram To Recieve Custom Metrics
120-
custom_request_counter.add(1, {"operation.type": "aws_sdk_call"}) # Agent-based export
121-
http_counter.add(1, {"operation.type": "aws_sdk_call"}) # Custom export pipeline
117+
custom_export_counter.add(1, {"operation.type": "custom_export_1"}) # Agent-based export
118+
agent_export_counter.add(1, {"operation.type": "agent_export_1"}) # Custom export pipeline
122119

123120
bucket_name = "e2e-test-bucket-name"
124121

terraform/python/ec2/default/amazon-cloudwatch-custom-agent.json

Lines changed: 0 additions & 20 deletions
This file was deleted.

terraform/python/ec2/default/main.tf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,8 @@ resource "null_resource" "main_service_setup" {
170170
export DJANGO_SETTINGS_MODULE="django_frontend_service.settings"
171171
export OTEL_PYTHON_DISTRO="aws_distro"
172172
export OTEL_PYTHON_CONFIGURATOR="aws_configurator"
173-
export OTEL_METRICS_EXPORTER=${var.custom_metrics_enabled ? "otlp" : "none"}
173+
export OTEL_METRICS_EXPORTER=otlp
174+
export OTEL_EXPORTER_OTLP_METRICS_ENDPOINT=http://localhost:4318/v1/metrics
174175
export OTEL_TRACES_EXPORTER=otlp
175176
export OTEL_AWS_APPLICATION_SIGNALS_ENABLED=true
176177
export OTEL_AWS_APPLICATION_SIGNALS_EXPORTER_ENDPOINT=http://localhost:4315
@@ -179,8 +180,7 @@ resource "null_resource" "main_service_setup" {
179180
export OTEL_EXPORTER_OTLP_METRICS_PROTOCOL=grpc
180181
export OTEL_SERVICE_NAME=python-sample-application-${var.test_id}
181182
export OTEL_TRACES_SAMPLER=always_on
182-
export OTEL_RESOURCE_ATTRIBUTES="service.name=python-sample-application-${var.test_id},deployment.environment.name=ec2:default"
183-
${var.custom_metrics_enabled ? "export OTEL_EXPORTER_OTLP_METRICS_ENDPOINT=http://localhost:4317" : "# Custom metrics disabled"}
183+
export OTEL_RESOURCE_ATTRIBUTES="service.name=GOAT_Service,deployment.environment.name=GOAT_Pen"
184184
export AWS_REGION='${var.aws_region}'
185185
export CUSTOM_METRICS_ENABLED='${var.custom_metrics_enabled}'
186186
export RDS_MYSQL_CLUSTER_ENDPOINT='dummy-endpoint'
Lines changed: 25 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,40 @@
11
# OpenTelemetry Custom Metrics Validation Templates - AWS SDK Call Only
22
-
3-
metricName: cloud_watch_counter
3+
metricName: custom_export_counter
44
namespace: {{customMetricNamespace}}
55
dimensions:
6+
-
7+
name: deployment.environment.name
8+
value: custom_export
9+
-
10+
name: telemetry.sdk.language
11+
value: python
612
-
713
name: operation.type
8-
value: aws_sdk_call
14+
value: custom_export_1
915
-
10-
name: Service
11-
value: {{serviceName}}
16+
name: telemetry.sdk.version
17+
value: 1.33.1
1218
-
13-
name: Environment
14-
value: {{testingId}}
19+
name: telemetry.sdk.name
20+
value: opentelemetry
1521
-
16-
metricName: http_counter
22+
metricName: agent_export_counter
1723
namespace: {{customMetricNamespace}}
1824
dimensions:
25+
26+
-
27+
name: deployment.environment.name
28+
value: agent_export
29+
-
30+
name: telemetry.sdk.language
31+
value: python
1932
-
2033
name: operation.type
21-
value: aws_sdk_call
34+
value: agent_export_1
2235
-
23-
name: Service
24-
value: {{serviceName}}
36+
name: telemetry.sdk.version
37+
value: 1.33.1
2538
-
26-
name: Environment
27-
value: {{testingId}}
39+
name: telemetry.sdk.name
40+
value: opentelemetry

0 commit comments

Comments
 (0)