Skip to content

Commit 44ece5a

Browse files
authored
Update trace validation to handle multiple ? (#419)
*Issue description:* For EKS Dotnet tests, there is currently a known issue where there is two `??` in the http url instead of the expected one. Temporarily updating the validation tests to be able to handle 0 to 2 questions marks until the issue is fixed. *Test* https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/16010052322/job/45165626309 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 9baec9a commit 44ece5a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

validator/src/main/resources/expected-data-template/dotnet/eks/linux/aws-sdk-call-trace.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "^{{serviceName}}$",
33
"http": {
44
"request": {
5-
"url": "^{{endpoint}}/aws-sdk-call(?:\\?ip=Redacted&testingId=Redacted)?$",
5+
"url": "^{{endpoint}}/aws-sdk-call(?:\\?{1,2}ip=Redacted&testingId=Redacted)?$",
66
"method": "^GET$"
77
}
88
},

validator/src/main/resources/expected-data-template/dotnet/eks/linux/remote-service-trace.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "^{{serviceName}}$",
33
"http": {
44
"request": {
5-
"url": "^{{endpoint}}/remote-service$",
5+
"url": "^{{endpoint}}/remote-service(?:\\?{1,2}ip=Redacted&testingId=Redacted)?$",
66
"method": "^GET$"
77
}
88
},

0 commit comments

Comments
 (0)