@@ -194,7 +194,9 @@ jobs:
194194 - name : Install OTel Collector
195195 uses : ./.github/workflows/actions/execute_and_retry
196196 with :
197- command : " cd ${{ env.TEST_RESOURCES_FOLDER }}/terraform/java/eks-otlp-ocb/util && kubectl apply -f ./appsignals-collector.yaml -n ${{ env.SAMPLE_APP_NAMESPACE }}"
197+ command : " cd ${{ env.TEST_RESOURCES_FOLDER }}/terraform/java/eks-otlp-ocb/util && \
198+ sed -i -e 's/${E2E_TEST_AWS_REGION}/${{ env.E2E_TEST_AWS_REGION }}/g' ./appsignals-collector.yaml && \
199+ kubectl apply -f ./appsignals-collector.yaml -n ${{ env.SAMPLE_APP_NAMESPACE }}"
198200 cleanup : " kubectl delete -f ./appsignals-collector.yaml -n ${{ env.SAMPLE_APP_NAMESPACE }} && \
199201 aws eks update-kubeconfig --name ${{ env.CLUSTER_NAME }} --region ${{ env.E2E_TEST_AWS_REGION }}"
200202 max_retry : 3
@@ -263,7 +265,7 @@ jobs:
263265 run : ./gradlew validator:run --args='-c java/eks-otlp-ocb/log-validation.yml
264266 --testing-id ${{ env.TESTING_ID }}
265267 --endpoint http://${{ env.APP_ENDPOINT }}
266- --region us-east-1
268+ --region ${{ env.E2E_TEST_AWS_REGION }}
267269 --account-id ${{ env.ACCOUNT_ID }}
268270 --metric-namespace ${{ env.METRIC_NAMESPACE }}
269271 --log-group ${{ env.LOG_GROUP_NAME }}
@@ -274,16 +276,14 @@ jobs:
274276 --remote-service-ip ${{ env.REMOTE_SERVICE_POD_IP }}
275277 --query-string ip=${{ env.REMOTE_SERVICE_POD_IP }}&testingId=${{ env.TESTING_ID }}
276278 --rollup'
277- # TODO: Undo hardcode
278- # --region ${{ env.E2E_TEST_AWS_REGION }}
279279
280280 - name : Call endpoints and validate generated metrics
281281 id : metric-validation
282282 if : (steps.deploy-sample-app.outcome == 'success' || steps.log-validation.outcome == 'failure') && !cancelled()
283283 run : ./gradlew validator:run --args='-c java/eks-otlp-ocb/metric-validation.yml
284284 --testing-id ${{ env.TESTING_ID }}
285285 --endpoint http://${{ env.APP_ENDPOINT }}
286- --region us-east-1
286+ --region ${{ env.E2E_TEST_AWS_REGION }}
287287 --account-id ${{ env.ACCOUNT_ID }}
288288 --metric-namespace ${{ env.METRIC_NAMESPACE }}
289289 --log-group ${{ env.LOG_GROUP_NAME }}
@@ -295,16 +295,14 @@ jobs:
295295 --remote-service-ip ${{ env.REMOTE_SERVICE_POD_IP }}
296296 --query-string ip=${{ env.REMOTE_SERVICE_POD_IP }}&testingId=${{ env.TESTING_ID }}
297297 --rollup'
298- # TODO: Undo hardcodes:
299- # --region ${{ env.E2E_TEST_AWS_REGION }}
300298
301299 - name : Call endpoints and validate generated traces
302300 id : trace-validation
303301 if : (steps.deploy-sample-app.outcome == 'success' || steps.log-validation.outcome == 'failure' || steps.metric-validation.outcome == 'failure') && !cancelled()
304302 run : ./gradlew validator:run --args='-c java/eks-otlp-ocb/trace-validation.yml
305303 --testing-id ${{ env.TESTING_ID }}
306304 --endpoint http://${{ env.APP_ENDPOINT }}
307- --region us-east-1
305+ --region ${{ env.E2E_TEST_AWS_REGION }}
308306 --account-id ${{ env.ACCOUNT_ID }}
309307 --metric-namespace ${{ env.METRIC_NAMESPACE }}
310308 --log-group ${{ env.LOG_GROUP_NAME }}
@@ -315,8 +313,6 @@ jobs:
315313 --remote-service-ip ${{ env.REMOTE_SERVICE_POD_IP }}
316314 --query-string ip=${{ env.REMOTE_SERVICE_POD_IP }}&testingId=${{ env.TESTING_ID }}
317315 --rollup'
318- # TODO: Undo hardcode
319- # --region ${{ env.E2E_TEST_AWS_REGION }}
320316
321317 - name : Refresh AWS Credentials
322318 if : ${{ github.event.repository.name == 'aws-application-signals-test-framework' }}
0 commit comments