Skip to content

Commit 6d346b3

Browse files
committed
TEST
1 parent 35c260c commit 6d346b3

File tree

2 files changed

+20
-5
lines changed

2 files changed

+20
-5
lines changed

.github/workflows/python-ec2-genai-test.yml

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ env:
1818
E2E_TEST_ACCOUNT_ID: 571600841604
1919
E2E_TEST_ROLE_NAME: github
2020
METRIC_NAMESPACE: genesis
21-
SPANS_LOG_GROUP: aws/spans
2221
LOG_GROUP_NAME: test/genesis
2322
TEST_RESOURCES_FOLDER: ${GITHUB_WORKSPACE}
2423
SAMPLE_APP_ZIP: s3://sigv4perfresults/langchain-service.zip
@@ -30,6 +29,20 @@ jobs:
3029
steps:
3130
- uses: actions/checkout@v4
3231

32+
# - name: Set Get ADOT Wheel command environment variable
33+
# run: |
34+
# if [ "${{ github.event.repository.name }}" = "aws-otel-python-instrumentation" ]; then
35+
# # Reusing the adot-main-build-staging-jar bucket to store the python wheel file
36+
# echo GET_ADOT_WHEEL_COMMAND="aws s3 cp s3://adot-main-build-staging-jar/${{ env.ADOT_WHEEL_NAME }} ./${{ env.ADOT_WHEEL_NAME }} && sudo python${{ env.PYTHON_VERSION }} -m pip install ${{ env.ADOT_WHEEL_NAME }}" >> $GITHUB_ENV
37+
# elif [ "${{ env.OTEL_SOURCE }}" == "pypi" ]; then
38+
# echo GET_ADOT_WHEEL_COMMAND="sudo python${{ env.PYTHON_VERSION }} -m pip install ${{ env.ADOT_WHEEL_NAME }}" >> $GITHUB_ENV
39+
# else
40+
# latest_release_version=$(curl -sL https://github.com/aws-observability/aws-otel-python-instrumentation/releases/latest | grep -oP '/releases/tag/v\K[0-9]+\.[0-9]+\.[0-9]+' | head -n 1)
41+
# echo "The latest version is $latest_release_version"
42+
# echo GET_ADOT_WHEEL_COMMAND="wget -O ${{ env.ADOT_WHEEL_NAME }} https://github.com/aws-observability/aws-otel-python-instrumentation/releases/latest/download/aws_opentelemetry_distro-$latest_release_version-py3-none-any.whl \
43+
# && sudo python${{ env.PYTHON_VERSION }} -m pip install ${{ env.ADOT_WHEEL_NAME }}" >> $GITHUB_ENV
44+
# fi
45+
3346
- name: Initiate Gradlew Daemon
3447
uses: ./.github/workflows/actions/execute_and_retry
3548
continue-on-error: true
@@ -134,7 +147,6 @@ jobs:
134147
--endpoint http://${{ env.INSTANCE_IP }}:8000
135148
--region ${{ env.E2E_TEST_AWS_REGION }}
136149
--metric-namespace ${{ env.METRIC_NAMESPACE }}
137-
--log-group ${{ env.SPANS_LOG_GROUP }}
138150
--service-name langchain-traceloop-app
139151
--instance-id ${{ env.INSTANCE_ID }}
140152
--trace-id ${{ env.XRAY_TRACE_ID }}'

validator/src/main/java/com/amazon/aoc/validators/CWLogValidator.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -171,9 +171,12 @@ private JsonifyArrayList<Map<String, Object>> getExpectedAttributes() throws Exc
171171

172172
private boolean isAwsOtlpLog(Map<String, Object> expectedAttributes) {
173173
// OTLP SigV4 logs have 'body' as a top-level attribute
174-
return expectedAttributes.containsKey("body") &&
175-
expectedAttributes.containsKey("severityNumber") &&
176-
expectedAttributes.containsKey("severityText");
174+
boolean hasBodyKey = expectedAttributes.keySet().stream()
175+
.anyMatch(key -> key.startsWith("body"));
176+
177+
return expectedAttributes.containsKey("severityNumber") &&
178+
expectedAttributes.containsKey("severityText") &&
179+
hasBodyKey;
177180
}
178181

179182
private Map<String, Object> getActualLog(

0 commit comments

Comments
 (0)