Skip to content

Commit 7599169

Browse files
Jeel-mehtaJeel Mehta
andauthored
[Node] Fix sig v4 test (#404)
*Issue description:* The ADOT Node Sigv4 test was failing because the Xray backend team changed the value of the dimensions of Metric validator. *Description of changes:* The dimension values were updated to be consistent with the changes from the backend. Test run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/14939073485 *Rollback procedure:* <Can we safely revert this commit if needed? If not, detail what must be done to safely revert and why it is needed.> *Ensure you've run the following tests on your changes and include the link below:* To do so, create a `test.yml` file with `name: Test` and workflow description to test your changes, then remove the file for your PR. Link your test run in your PR description. This process is a short term solution while we work on creating a staging environment for testing. NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the [needs](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idneeds) keyword to run tests in succession. - Run Java EKS on `e2e-playground` in us-east-1 and eu-central-2 - Run Python EKS on `e2e-playground` in us-east-1 and eu-central-2 - Run metric limiter on EKS cluster `e2e-playground` in us-east-1 and eu-central-2 - Run EC2 tests in all regions - Run K8s on a separate K8s cluster (check IAD test account for master node endpoints; these will change as we create and destroy clusters for OS patching) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Jeel Mehta <[email protected]>
1 parent 71a884f commit 7599169

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

.github/workflows/node-ec2-adot-sigv4-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ jobs:
192192
run: ./gradlew validator:run --args='-c node/ec2/adot-sigv4/metric-validation.yml
193193
--testing-id ${{ env.TESTING_ID }}
194194
--endpoint http://${{ env.MAIN_SERVICE_ENDPOINT }}
195-
--remote-service-deployment-name ${{ env.REMOTE_SERVICE_IP }}:8001
195+
--remote-service-deployment-name node-sample-remote-application-${{ env.TESTING_ID }}
196196
--region ${{ env.E2E_TEST_AWS_REGION }}
197197
--account-id ${{ env.E2E_TEST_ACCOUNT_ID }}
198198
--metric-namespace ${{ env.METRIC_NAMESPACE }}

validator/src/main/resources/expected-data-template/node/ec2/adot-sigv4/aws-sdk-call-metric.mustache

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
dimensions:
1919
-
2020
name: Operation
21-
value: UnmappedOperation
21+
value: GET /aws-sdk-call
2222
-
2323
name: Service
2424
value: {{serviceName}}
@@ -94,7 +94,7 @@
9494
dimensions:
9595
-
9696
name: Operation
97-
value: UnmappedOperation
97+
value: GET /aws-sdk-call
9898
-
9999
name: Service
100100
value: {{serviceName}}
@@ -170,7 +170,7 @@
170170
dimensions:
171171
-
172172
name: Operation
173-
value: UnmappedOperation
173+
value: GET /aws-sdk-call
174174
-
175175
name: Service
176176
value: {{serviceName}}

validator/src/main/resources/expected-data-template/node/ec2/adot-sigv4/outgoing-http-call-metric.mustache

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
dimensions:
1919
-
2020
name: Operation
21-
value: UnmappedOperation
21+
value: GET /outgoing-http-call
2222
-
2323
name: Service
2424
value: {{serviceName}}
@@ -94,7 +94,7 @@
9494
dimensions:
9595
-
9696
name: Operation
97-
value: UnmappedOperation
97+
value: GET /outgoing-http-call
9898
-
9999
name: Service
100100
value: {{serviceName}}
@@ -170,7 +170,7 @@
170170
dimensions:
171171
-
172172
name: Operation
173-
value: UnmappedOperation
173+
value: GET /outgoing-http-call
174174
-
175175
name: Service
176176
value: {{serviceName}}

validator/src/main/resources/expected-data-template/node/ec2/adot-sigv4/remote-service-metric.mustache

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
dimensions:
1919
-
2020
name: Operation
21-
value: UnmappedOperation
21+
value: GET /remote-service
2222
-
2323
name: Service
2424
value: {{serviceName}}
@@ -127,7 +127,7 @@
127127
dimensions:
128128
-
129129
name: Operation
130-
value: UnmappedOperation
130+
value: GET /remote-service
131131
-
132132
name: Service
133133
value: {{serviceName}}
@@ -236,7 +236,7 @@
236236
dimensions:
237237
-
238238
name: Operation
239-
value: UnmappedOperation
239+
value: GET /remote-service
240240
-
241241
name: Service
242242
value: {{serviceName}}

0 commit comments

Comments
 (0)