Skip to content

Commit 87a11c0

Browse files
authored
Temporarily use Java K8s Canary Infrastructure for Node.js K8s e2e tests (#427)
*Issue description:* - Node.js K8s infrastructure is blocked for reasons that will be investigated further. As a short term solution, use the unused Java K8s infrastructure for testing Node.js e2e tests. *Description of changes:* - Use the unused Java K8s infrastructure for testing Node.js e2e tests. *Rollback procedure:* <Can we safely revert this commit if needed? If not, detail what must be done to safely revert and why it is needed.> Yes. *Testing:* Only test Node.js K8s test because this change only affects Node.js K8s test. https://github.com/aws-observability/aws-otel-js-instrumentation/actions/runs/16207143847/job/45760224845 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 7b03654 commit 87a11c0

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

.github/workflows/node-k8s-test.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,13 +94,17 @@ jobs:
9494
NODE_REMOTE_SAMPLE_APP_IMAGE, e2e-test/node-remote-sample-app-image
9595
RELEASE_TESTING_ECR_ACCOUNT, e2e-test/${{ github.event.repository.name }}/node-k8s-release-testing-account
9696
97+
# Temporarily use Java K8s Canary Cluster for Node.js e2e tests
9798
- name: Retrieve K8s EC2 Secrets
9899
if: ${{ env.CALLER_WORKFLOW_NAME != 'k8s-os-patching' }}
99100
uses: aws-actions/aws-secretsmanager-get-secrets@v1
100101
with:
102+
# secret-ids: |
103+
# MAIN_SERVICE_ENDPOINT, e2e-test/${{ github.event.repository.name }}/node-k8s-master-node-endpoint
104+
# MASTER_NODE_SSH_KEY, e2e-test/${{ github.event.repository.name }}/node-k8s-ssh-key
101105
secret-ids: |
102-
MAIN_SERVICE_ENDPOINT, e2e-test/${{ github.event.repository.name }}/node-k8s-master-node-endpoint
103-
MASTER_NODE_SSH_KEY, e2e-test/${{ github.event.repository.name }}/node-k8s-ssh-key
106+
MAIN_SERVICE_ENDPOINT, e2e-test/aws-application-signals-test-framework/java-k8s-master-node-endpoint
107+
MASTER_NODE_SSH_KEY, e2e-test/aws-application-signals-test-framework/java-k8s-ssh-key
104108
105109
- name: Retrieve K8s EC2 OS Patching Secrets
106110
if: ${{ env.CALLER_WORKFLOW_NAME == 'k8s-os-patching' }}

0 commit comments

Comments
 (0)