Skip to content

Commit dc59ca4

Browse files
authored
Update validation result success condition for OTLP/OCB (#329)
*Issue description:* *Description of changes:* - In `"Save test results"` of OCB+OTLP EKS workflow, update logic for setting `"validation-result=success"` to be more similar to other workflows. - [Current OTLP Java EKS test ](https://github.com/aws-observability/aws-application-signals-test-framework/blob/3a14868c977cdad993100ed03a5f365ff0751bbb/.github/workflows/java-eks-otlp-ocb-test.yml#L339) - [Compared to regular Java EKS](https://github.com/aws-observability/aws-application-signals-test-framework/blob/3a14868c977cdad993100ed03a5f365ff0751bbb/.github/workflows/java-eks-test.yml#L455) *Rollback procedure:* N/A *Ensure you've run the following tests on your changes and include the link below:* https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/12188286530/job/34000954449#step:31:1 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 3a14868 commit dc59ca4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/java-eks-otlp-ocb-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ jobs:
336336
if: always()
337337
id: validation-result
338338
run: |
339-
if [ "${{ steps.trace-validation.outcome }}" = "success" ]; then
339+
if [ "${{ steps.log-validation.outcome }}" = "success" ] && [ "${{ steps.metric-validation.outcome }}" = "success" ] && [ "${{ steps.trace-validation.outcome }}" = "success" ]; then
340340
echo "validation-result=success" >> $GITHUB_OUTPUT
341341
else
342342
echo "validation-result=failure" >> $GITHUB_OUTPUT

0 commit comments

Comments
 (0)