Skip to content

Commit 5472edd

Browse files
authored
Added back quotes in hourly resource cleaner. (#805)
1 parent 4fbae1b commit 5472edd

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

tools/workflow/clean-terraform-resources.sh

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ terraform_destroy() {
2323
key_name=${1}
2424
echo "destroy the terraform resource"
2525
echo "download s3 object: ${bucket_name}/${key_name}"
26-
aws s3 cp s3://${bucket_name}/${key_name} downloaded_terraform/${key_name}
27-
tar xvf downloaded_terraform/${key_name}
26+
aws s3 cp "s3://${bucket_name}/${key_name}" "downloaded_terraform/${key_name}"
27+
tar xvf "downloaded_terraform/${key_name}"
2828
if [ -d testing-framework/terraform/soaking ]; then
2929
cd testing-framework/terraform/soaking
3030
terraform init
@@ -37,11 +37,9 @@ terraform_destroy() {
3737
rm -rf testing-framework
3838
}
3939

40+
s3_keys=$(aws s3api list-objects-v2 --bucket ${bucket_name} --query "Contents[?LastModified < '${yesterday}'].Key")
4041

41-
s3_keys=$(aws s3api list-objects-v2 --bucket ${bucket_name} --query "Contents[?LastModified < ${yesterday}].Key")
42-
43-
44-
echo "${s3_keys}" | docker run --rm -i stedolan/jq -c '.[]' | while read i; do
42+
echo "${s3_keys}" | docker run --rm -i stedolan/jq -c '.[]' | while read -r i; do
4543
key_name=${i:1:$((${#i}-2))}
4644
terraform_destroy "${key_name}"
4745
done

0 commit comments

Comments
 (0)