fix build warnings

ezhang6811 · ezhang6811 · commit 79486b9ee6d7 · 2024-12-12T20:35:15.000Z
diff --git a/src/AWS.Distro.OpenTelemetry.AutoInstrumentation/AwsMetricAttributeGenerator.cs b/src/AWS.Distro.OpenTelemetry.AutoInstrumentation/AwsMetricAttributeGenerator.cs
@@ -423,13 +423,13 @@ private static void SetRemoteResourceTypeAndIdentifier(Activity span, ActivityTa
             else if (IsKeyPresent(span, AttributeAWSSecretsManagerSecretArn))
             {
                 remoteResourceType = NormalizedSecretsManagerServiceName + "::Secret";
-                remoteResourceIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSSecretsManagerSecretArn)).Split(':').Last();
+                remoteResourceIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSSecretsManagerSecretArn))?.Split(':').Last();
                 cloudformationPrimaryIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSSecretsManagerSecretArn));
             }
             else if (IsKeyPresent(span, AttributeAWSSNSTopicArn))
             {
                 remoteResourceType = NormalizedSNSServiceName + "::Topic";
-                remoteResourceIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSSNSTopicArn)).Split(':').Last();
+                remoteResourceIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSSNSTopicArn))?.Split(':').Last();
                 cloudformationPrimaryIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSSNSTopicArn));
             }
             else if (IsKeyPresent(span, AttributeAWSSQSQueueName))
@@ -447,13 +447,13 @@ private static void SetRemoteResourceTypeAndIdentifier(Activity span, ActivityTa
             else if (IsKeyPresent(span, AttributeAWSStepFunctionsActivityArn))
             {
                 remoteResourceType = NormalizedStepFunctionsName + "::Activity";
-                remoteResourceIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSStepFunctionsActivityArn)).Split(':').Last();
+                remoteResourceIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSStepFunctionsActivityArn))?.Split(':').Last();
                 cloudformationPrimaryIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSStepFunctionsActivityArn));
             }
             else if (IsKeyPresent(span, AttributeAWSStepFunctionsStateMachineArn))
             {
                 remoteResourceType = NormalizedStepFunctionsName + "::StateMachine";
-                remoteResourceIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSStepFunctionsStateMachineArn)).Split(':').Last();
+                remoteResourceIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSStepFunctionsStateMachineArn))?.Split(':').Last();
                 cloudformationPrimaryIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSStepFunctionsStateMachineArn));
             }
             else if (IsKeyPresent(span, AttributeAWSBedrockGuardrailId))

Original file line number	Diff line number	Diff line change
`@@ -423,13 +423,13 @@ private static void SetRemoteResourceTypeAndIdentifier(Activity span, ActivityTa`
`423`	`423`	`else if (IsKeyPresent(span, AttributeAWSSecretsManagerSecretArn))`
`424`	`424`	`{`
`425`	`425`	`remoteResourceType = NormalizedSecretsManagerServiceName + "::Secret";`
`426`		`- remoteResourceIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSSecretsManagerSecretArn)).Split(':').Last();`
	`426`	`+ remoteResourceIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSSecretsManagerSecretArn))?.Split(':').Last();`
`427`	`427`	`cloudformationPrimaryIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSSecretsManagerSecretArn));`
`428`	`428`	`}`
`429`	`429`	`else if (IsKeyPresent(span, AttributeAWSSNSTopicArn))`
`430`	`430`	`{`
`431`	`431`	`remoteResourceType = NormalizedSNSServiceName + "::Topic";`
`432`		`- remoteResourceIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSSNSTopicArn)).Split(':').Last();`
	`432`	`+ remoteResourceIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSSNSTopicArn))?.Split(':').Last();`
`433`	`433`	`cloudformationPrimaryIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSSNSTopicArn));`
`434`	`434`	`}`
`435`	`435`	`else if (IsKeyPresent(span, AttributeAWSSQSQueueName))`
`@@ -447,13 +447,13 @@ private static void SetRemoteResourceTypeAndIdentifier(Activity span, ActivityTa`
`447`	`447`	`else if (IsKeyPresent(span, AttributeAWSStepFunctionsActivityArn))`
`448`	`448`	`{`
`449`	`449`	`remoteResourceType = NormalizedStepFunctionsName + "::Activity";`
`450`		`- remoteResourceIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSStepFunctionsActivityArn)).Split(':').Last();`
	`450`	`+ remoteResourceIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSStepFunctionsActivityArn))?.Split(':').Last();`
`451`	`451`	`cloudformationPrimaryIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSStepFunctionsActivityArn));`
`452`	`452`	`}`
`453`	`453`	`else if (IsKeyPresent(span, AttributeAWSStepFunctionsStateMachineArn))`
`454`	`454`	`{`
`455`	`455`	`remoteResourceType = NormalizedStepFunctionsName + "::StateMachine";`
`456`		`- remoteResourceIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSStepFunctionsStateMachineArn)).Split(':').Last();`
	`456`	`+ remoteResourceIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSStepFunctionsStateMachineArn))?.Split(':').Last();`
`457`	`457`	`cloudformationPrimaryIdentifier = EscapeDelimiters((string?)span.GetTagItem(AttributeAWSStepFunctionsStateMachineArn));`
`458`	`458`	`}`
`459`	`459`	`else if (IsKeyPresent(span, AttributeAWSBedrockGuardrailId))`