Skip to content

Commit cd614f0

Browse files
committed
minor attribute name fixes
1 parent 415bf1d commit cd614f0

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

src/OpenTelemetry.Instrumentation.AWS/Implementation/AWSSemanticConventions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ internal static class AWSSemanticConventions
1616
public const string AttributeAWSS3BucketName = "aws.s3.bucket";
1717
public const string AttributeAWSKinesisStreamName = "aws.kinesis.stream_name";
1818
public const string AttributeAWSSecretsManagerSecretArn = "aws.secretsmanager.secret.arn";
19-
public const string AttributeAWSSnsTopicArn = "aws.sns.topic.arn";
19+
public const string AttributeAWSSNSTopicArn = "aws.sns.topic.arn";
2020
public const string AttributeAWSStepFunctionsActivityArn = "aws.stepfunctions.activity.arn";
2121
public const string AttributeAWSStepFunctionsStateMachineArn = "aws.stepfunctions.state_machine.arn";
2222

src/OpenTelemetry.Instrumentation.AWS/Implementation/AWSServiceHelper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ internal class AWSServiceHelper
3434
{ "QueueName", AWSSemanticConventions.AttributeAWSSQSQueueName },
3535
{ "BucketName", AWSSemanticConventions.AttributeAWSS3BucketName },
3636
{ "StreamName", AWSSemanticConventions.AttributeAWSKinesisStreamName },
37-
{ "TopicArn", AWSSemanticConventions.AttributeAWSSnsTopicArn },
37+
{ "TopicArn", AWSSemanticConventions.AttributeAWSSNSTopicArn },
3838
{ "ARN", AWSSemanticConventions.AttributeAWSSecretsManagerSecretArn },
3939
{ "ActivityArn", AWSSemanticConventions.AttributeAWSStepFunctionsActivityArn },
4040
{ "StateMachineArn", AWSSemanticConventions.AttributeAWSStepFunctionsStateMachineArn },

src/OpenTelemetry.Instrumentation.AWS/Implementation/AWSServiceType.cs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ namespace OpenTelemetry.Instrumentation.AWS.Implementation;
66
internal class AWSServiceType
77
{
88
internal const string DynamoDbService = "DynamoDB";
9-
internal const string SecretsManagerService = "Secrets Manager";
10-
internal const string StepFunctionsService = "SFN";
119
internal const string SQSService = "SQS";
1210
internal const string SNSService = "SNS";
1311
internal const string S3Service = "S3";
1412
internal const string KinesisService = "Kinesis";
13+
internal const string SecretsManagerService = "Secrets Manager";
14+
internal const string StepFunctionsService = "SFN";
1515
internal const string BedrockService = "Bedrock";
1616
internal const string BedrockRuntimeService = "Bedrock Runtime";
1717
internal const string BedrockAgentService = "Bedrock Agent";
@@ -32,6 +32,12 @@ internal static bool IsS3Service(string service)
3232
internal static bool IsKinesisService(string service)
3333
=> KinesisService.Equals(service, StringComparison.OrdinalIgnoreCase);
3434

35+
internal static bool IsSecretsManagerService(string service)
36+
=> SecretsManagerService.Equals(service, StringComparison.OrdinalIgnoreCase);
37+
38+
internal static bool IsStepFunctionsService(string service)
39+
=> StepFunctionsService.Equals(service, StringComparison.OrdinalIgnoreCase);
40+
3541
internal static bool IsBedrockService(string service)
3642
=> BedrockService.Equals(service, StringComparison.OrdinalIgnoreCase);
3743

0 commit comments

Comments
 (0)