Skip to content

Commit 014554d

Browse files
committed
Add log message wait for smoke test servers
1 parent 9ed0417 commit 014554d

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

smoke-tests/runner/src/test/java/io/awsobservability/instrumentation/smoketests/runner/LogInjectionTest.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import org.testcontainers.containers.GenericContainer;
2525
import org.testcontainers.containers.output.Slf4jLogConsumer;
2626
import org.testcontainers.containers.output.ToStringConsumer;
27+
import org.testcontainers.containers.wait.strategy.Wait;
2728
import org.testcontainers.junit.jupiter.Container;
2829
import org.testcontainers.junit.jupiter.Testcontainers;
2930
import org.testcontainers.utility.MountableFile;
@@ -39,11 +40,11 @@ class LogInjectionTest {
3940

4041
@Container
4142
private static final GenericContainer<?> log4jApp =
42-
new GenericContainer<>(
43-
"public.ecr.aws/aws-otel-test/aws-otel-java-spark:ae69a3fef3274282bc4e125d12e874d9330085d4")
43+
new GenericContainer<>("public.ecr.aws/aws-otel-test/aws-otel-java-spark:latest")
4444
.withExposedPorts(4567)
4545
.withLogConsumer(new Slf4jLogConsumer(LoggerFactory.getLogger("log4j")))
4646
.withLogConsumer(log4jString)
47+
.waitingFor(Wait.forLogMessage(".*Started.*", 1))
4748
.withCopyFileToContainer(
4849
MountableFile.forHostPath(AGENT_PATH), "/opentelemetry-javaagent-all.jar")
4950
.withEnv("JAVA_TOOL_OPTIONS", "-javaagent:/opentelemetry-javaagent-all.jar")
@@ -53,11 +54,11 @@ class LogInjectionTest {
5354

5455
@Container
5556
private static final GenericContainer<?> logbackApp =
56-
new GenericContainer<>(
57-
"public.ecr.aws/aws-otel-test/aws-otel-java-springboot:ae69a3fef3274282bc4e125d12e874d9330085d4")
57+
new GenericContainer<>("public.ecr.aws/aws-otel-test/aws-otel-java-springboot:latest")
5858
.withExposedPorts(8080)
5959
.withLogConsumer(new Slf4jLogConsumer(LoggerFactory.getLogger("logback")))
6060
.withLogConsumer(logbackString)
61+
.waitingFor(Wait.forLogMessage(".*Started DemoApplication.*", 1))
6162
.withCopyFileToContainer(
6263
MountableFile.forHostPath(AGENT_PATH), "/opentelemetry-javaagent-all.jar")
6364
.withEnv("JAVA_TOOL_OPTIONS", "-javaagent:/opentelemetry-javaagent-all.jar")

smoke-tests/runner/src/test/java/io/awsobservability/instrumentation/smoketests/runner/SpringBootSmokeTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ public ExportTraceServiceRequest deserialize(
114114
.withLogConsumer(new Slf4jLogConsumer(applicationLogger))
115115
.withCopyFileToContainer(
116116
MountableFile.forHostPath(AGENT_PATH), "/opentelemetry-javaagent-all.jar")
117+
.waitingFor(Wait.forLogMessage(".*Started Application.*", 1))
117118
.withEnv("JAVA_TOOL_OPTIONS", "-javaagent:/opentelemetry-javaagent-all.jar")
118119
.withEnv("OTEL_BSP_MAX_EXPORT_BATCH", "1")
119120
.withEnv("OTEL_BSP_SCHEDULE_DELAY", "10")
@@ -128,6 +129,8 @@ public ExportTraceServiceRequest deserialize(
128129
.withLogConsumer(new Slf4jLogConsumer(applicationLogger))
129130
.withCopyFileToContainer(
130131
MountableFile.forHostPath(AGENT_PATH), "/opentelemetry-javaagent-all.jar")
132+
.waitingFor(Wait.forLogMessage(".*Started Application.*", 1))
133+
.withEnv("OTEL_JAVAAGENT_DEBUG", "true")
131134
.withEnv("JAVA_TOOL_OPTIONS", "-javaagent:/opentelemetry-javaagent-all.jar")
132135
.withEnv("OTEL_BSP_MAX_EXPORT_BATCH", "1")
133136
.withEnv("OTEL_BSP_SCHEDULE_DELAY", "10")

0 commit comments

Comments
 (0)