Skip to content

Commit 0838340

Browse files
committed
Upgrade smoke tests to use JDK version 21.
1 parent cd53443 commit 0838340

File tree

10 files changed

+30
-23
lines changed

10 files changed

+30
-23
lines changed

.github/workflows/main-build.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ on:
44
branches:
55
- main
66
- "release/v*"
7+
- version-upgrade-v1
78
env:
89
AWS_DEFAULT_REGION: us-east-1
910
STAGING_ECR_REGISTRY: 611364707713.dkr.ecr.us-west-2.amazonaws.com

instrumentation/logback-1.0/src/main/java/software/amazon/opentelemetry/javaagent/instrumentation/logback_1_0/AwsXrayLoggingEventInstrumentation.java

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -79,14 +79,19 @@ public static void onExit(
7979

8080
SpanContext spanContext = Java8BytecodeBridge.spanFromContext(context).getSpanContext();
8181

82+
// Using StringBuilder instead of + for string concatenation avoids generating invokedynamic
83+
// instructions introduced in Java 9+, ensuring compatibility with Java 6 class files.
84+
// This approach explicitly constructs the string, producing bytecode compatible with older
85+
// versions.
8286
if (spanContext.isValid()) {
83-
String value =
84-
"1-"
85-
+ spanContext.getTraceId().substring(0, 8)
86-
+ "-"
87-
+ spanContext.getTraceId().substring(8)
88-
+ "@"
89-
+ spanContext.getSpanId();
87+
StringBuilder valueBuilder = new StringBuilder("1-");
88+
valueBuilder
89+
.append(spanContext.getTraceId().substring(0, 8))
90+
.append("-")
91+
.append(spanContext.getTraceId().substring(8))
92+
.append("@")
93+
.append(spanContext.getSpanId());
94+
String value = valueBuilder.toString();
9095
spanContextData.put(TRACE_ID_KEY, value);
9196
}
9297

otelagent/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,8 @@ tasks {
136136

137137
jib {
138138
configureImages(
139-
"gcr.io/distroless/java17-debian11:debug",
140-
"public.ecr.aws/aws-otel-test/aws-opentelemetry-java-base:alpha",
139+
"gcr.io/distroless/java21-debian12:debug",
140+
"public.ecr.aws/u8q5x3l1/aws-otel-test/aws-opentelemetry-java-base:alpha",
141141
localDocker = false,
142142
multiPlatform = !rootProject.property("localDocker")!!.equals("true"),
143143
)

sample-apps/spark-awssdkv1/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ application {
2222

2323
jib {
2424
configureImages(
25-
"public.ecr.aws/aws-otel-test/aws-opentelemetry-java-base:alpha",
26-
"public.ecr.aws/aws-otel-test/aws-otel-java-spark-awssdkv1",
25+
"public.ecr.aws/u8q5x3l1/aws-otel-test/aws-opentelemetry-java-base:alpha",
26+
"public.ecr.aws/u8q5x3l1/aws-otel-test/aws-otel-java-spark-awssdkv1",
2727
localDocker = rootProject.property("localDocker")!!.equals("true"),
2828
multiPlatform = !rootProject.property("localDocker")!!.equals("true"),
2929
tags = setOf("latest", "${System.getenv("COMMIT_HASH")}"),

sample-apps/spark/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ application {
2828
jib {
2929

3030
configureImages(
31-
"public.ecr.aws/aws-otel-test/aws-opentelemetry-java-base:alpha",
32-
"public.ecr.aws/aws-otel-test/aws-otel-java-spark",
31+
"public.ecr.aws/u8q5x3l1/aws-otel-test/aws-opentelemetry-java-base:alpha",
32+
"public.ecr.aws/u8q5x3l1/aws-otel-test/aws-otel-java-spark",
3333
localDocker = rootProject.property("localDocker")!!.equals("true"),
3434
multiPlatform = !rootProject.property("localDocker")!!.equals("true"),
3535
tags = setOf("latest", "${System.getenv("COMMIT_HASH")}"),

sample-apps/springboot/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ dependencies {
1717

1818
jib {
1919
configureImages(
20-
"public.ecr.aws/aws-otel-test/aws-opentelemetry-java-base:alpha",
21-
"public.ecr.aws/aws-otel-test/aws-otel-java-springboot",
20+
"public.ecr.aws/u8q5x3l1/aws-otel-test/aws-opentelemetry-java-base:alpha",
21+
"public.ecr.aws/u8q5x3l1/aws-otel-test/aws-otel-java-springboot",
2222
rootProject.property("localDocker")!!.equals("true"),
2323
!rootProject.property("localDocker")!!.equals("true"),
2424
tags = setOf("latest", "${System.getenv("COMMIT_HASH")}"),

smoke-tests/fakebackend/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ dependencies {
3333

3434
jib {
3535
to {
36-
image = "public.ecr.aws/u0d6r4y4/aws-otel-java-test-fakebackend:alpha"
36+
image = "public.ecr.aws/u8q5x3l1/aws-otel-test/aws-otel-java-test-fakebackend:alpha"
3737
}
3838
from {
3939
image = "gcr.io/distroless/java17-debian11:debug"

smoke-tests/runner/src/test/java/io/awsobservability/instrumentation/smoketests/runner/LogInjectionTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class LogInjectionTest {
4040

4141
@Container
4242
private static final GenericContainer<?> log4jApp =
43-
new GenericContainer<>("public.ecr.aws/aws-otel-test/aws-otel-java-spark:latest")
43+
new GenericContainer<>("public.ecr.aws/u8q5x3l1/aws-otel-test/aws-otel-java-spark:latest")
4444
.withExposedPorts(4567)
4545
.withLogConsumer(new Slf4jLogConsumer(LoggerFactory.getLogger("log4j")))
4646
.withLogConsumer(log4jString)
@@ -54,7 +54,8 @@ class LogInjectionTest {
5454

5555
@Container
5656
private static final GenericContainer<?> logbackApp =
57-
new GenericContainer<>("public.ecr.aws/aws-otel-test/aws-otel-java-springboot:latest")
57+
new GenericContainer<>(
58+
"public.ecr.aws/u8q5x3l1/aws-otel-test/aws-otel-java-springboot:latest")
5859
.withExposedPorts(8080)
5960
.withLogConsumer(new Slf4jLogConsumer(LoggerFactory.getLogger("logback")))
6061
.withLogConsumer(logbackString)

smoke-tests/runner/src/test/java/io/awsobservability/instrumentation/smoketests/runner/SpringBootSmokeTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ public ExportTraceServiceRequest deserialize(
108108
@Container
109109
private static final GenericContainer<?> application =
110110
new GenericContainer<>(
111-
"public.ecr.aws/aws-otel-test/aws-otel-java-smoketests-springboot:latest")
111+
"public.ecr.aws/u8q5x3l1/aws-otel-test/aws-otel-java-smoketests-springboot:latest")
112112
.dependsOn(backend)
113113
.withExposedPorts(8080)
114114
.withNetwork(network)
@@ -124,7 +124,7 @@ public ExportTraceServiceRequest deserialize(
124124
@Container
125125
private static final GenericContainer<?> applicationXraySampler =
126126
new GenericContainer<>(
127-
"public.ecr.aws/aws-otel-test/aws-otel-java-smoketests-springboot:latest")
127+
"public.ecr.aws/u8q5x3l1/aws-otel-test/aws-otel-java-smoketests-springboot:latest")
128128
.dependsOn(backend)
129129
.withExposedPorts(8080)
130130
.withNetwork(network)

smoke-tests/spring-boot/build.gradle.kts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@ dependencies {
4747

4848
jib {
4949
configureImages(
50-
"public.ecr.aws/aws-otel-test/aws-opentelemetry-java-base:alpha",
51-
"public.ecr.aws/aws-otel-test/aws-otel-java-smoketests-springboot",
52-
localDocker = rootProject.property("localDocker")!!.equals("true"),
50+
"public.ecr.aws/u8q5x3l1/aws-otel-test/aws-opentelemetry-java-base:alpha",
51+
"public.ecr.aws/u8q5x3l1/aws-otel-test/aws-otel-java-smoketests-springboot",
52+
localDocker = false,
5353
multiPlatform = false,
5454
)
5555
}

0 commit comments

Comments
 (0)