try adding error paths for sfn describe activity

Author: yiyuan-he

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/awssdk/base/AwsSdkBaseTest.java

@@ -2418,4 +2418,39 @@ protected void doTestStepFunctionsDescribeActivity() throws Exception {
                 "arn:aws:states:us-west-2:000000000000:activity:test-activity")));
 
   }
+
+  protected void dotestStepFunctionsDescribeActivityError() throws Exception {
+    appClient.get("/sfn/describeactivity/error").aggregate().join();
+    var traces = mockCollectorClient.getTraces();
+    var metrics = mockCollectorClient.getMetrics(
+        Set.of(
+            AppSignalsConstants.ERROR_METRIC,
+            AppSignalsConstants.FAULT_METRIC,
+            AppSignalsConstants.LATENCY_METRIC));
+
+    var localService = getApplicationOtelServiceName();
+    var localOperation = "GET /sfn/describeactivity/error";
+    var type = "AWS::StepFunctions::Activity";
+    var identifier = "nonexistant-activity";
+    var cloudformationIdentifier = "arn:aws:states:us-west-2:000000000000:activity:nonexistent-activity";
+
+    assertSpanClientAttributes(
+        traces,
+        stepFunctionsSpanName("DescribeActivity"),
+        getStepFunctionsRpcServiceName(),
+        localService,
+        localOperation,
+        getStepFunctionsServiceName(),
+        "DescribeActivity",
+        type,
+        identifier,
+        cloudformationIdentifier,
+        "error.test",
+        8080,
+        "http://error.test:8080",
+        400,
+        List.of(
+            assertAttribute(
+                SemanticConventionsConstants.AWS_ACTIVITY_ARN, "arn:aws:states:us-west-2:000000000000:activity:nonexistent-activity")));
+  }
 }

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/awssdk/v1/AwsSdkV1Test.java

@@ -270,4 +270,9 @@ void testStepFunctionsDescribeStateMachine() throws Exception {
   void testStepFunctionsDescribeActivity() throws Exception {
     doTestStepFunctionsDescribeActivity();
   }
+
+  @Test
+  void testStepFunctionsDescribeActivityError() throws Exception {
+    dotestStepFunctionsDescribeActivityError();
+  }
 }

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/awssdk/v2/AwsSdkV2Test.java

@@ -275,4 +275,9 @@ void testStepFunctionsDescribeStateMachine() throws Exception {
   void testStepFunctionsDescribeActivity() throws Exception {
     doTestStepFunctionsDescribeActivity();
   }
+
+  @Test
+  void testStepFunctionsDescribeActivityError() throws Exception {
+    dotestStepFunctionsDescribeActivityError();
+  }
 }

appsignals-tests/images/aws-sdk/aws-sdk-v1/src/main/java/com/amazon/sampleapp/App.java

@@ -821,5 +821,21 @@ private static void setupStepFunctions() {
           stepFunctionsClient.describeActivity(describeRequest);
           return "";
         });
+
+    get(
+        "/sfn/describeactivity/error",
+        (req, res) -> {
+          setMainStatus(400);
+          var errorClient = AWSStepFunctionsClient.builder().withCredentials(CREDENTIALS_PROVIDER)
+              .withEndpointConfiguration(new EndpointConfiguration("http://error.test:8080", Regions.US_WEST_2.getName()))
+              .build();
+          try {
+            var describeRequest = new DescribeActivityRequest().withActivityArn("arn:aws:states:us-west-2:000000000000:activity:nonexistent-activity");
+            errorClient.describeActivity(describeRequest);
+          } catch (Exception e) {
+            logger.info("Error caught in Sample App", e);
+          }
+          return "";
+        });
   }
 }

appsignals-tests/images/aws-sdk/aws-sdk-v2/src/main/java/com/amazon/sampleapp/App.java

@@ -852,5 +852,25 @@ private static void setupStepFunctions() {
           sfnClient.describeActivity(describeRequest);
           return "";
         });
+
+    get(
+        "/sfn/describeactivity/error",
+        (req, res) -> {
+          setMainStatus(400);
+          var errorClient = SfnClient.builder()
+              .endpointOverride(URI.create("http://error.test:8080"))
+              .credentialsProvider(CREDENTIALS_PROVIDER)
+              .build();
+
+          try {
+            var describeRequest = DescribeActivityRequest.builder()
+                .activityArn("arn:aws:states:us-west-2:000000000000:activity:nonexistent-activity")
+                .build();
+            errorClient.describeActivity(describeRequest);
+          } catch (Exception e) {
+            logger.error("Error caught in Sample App", e);
+          }
+          return "";
+        });
   }
 }