add contract tests for describe secret calls

Author: yiyuan-he

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/awssdk/base/AwsSdkBaseTest.java

@@ -2292,4 +2292,38 @@ protected void doTestSecretsManagerCreateSecret() throws Exception {
         cloudformationIdentifier,
         0.0);
   }
+
+  protected void doTestSecretsManagerDescribeSecret() throws Exception {
+    appClient.get("/secretsmanager/describe/test-secret-id").aggregate().join();
+    var traces = mockCollectorClient.getTraces();
+    var metrics = mockCollectorClient.getMetrics(
+        Set.of(
+            AppSignalsConstants.ERROR_METRIC,
+            AppSignalsConstants.FAULT_METRIC,
+            AppSignalsConstants.LATENCY_METRIC
+        )
+    );
+    var localService = getApplicationOtelServiceName();
+    var localOperation = "GET /secretsmanager/describe/:secretId";
+    var type = "AWS::SecretsManager::Secret";
+    var identifier = "test-secret-id";
+    var cloudformationIdentifier = "arn:aws:secretsmanager:us-west-2:000000000000:secret:test-secret-id";
+
+    assertSpanClientAttributes(
+        traces,
+        secretsManagerSpanName("DescribeSecret"),
+        getSecretsManagerRpcServiceName(),
+        localService,
+        localOperation,
+        getSecretsManagerServiceName(),
+        "DescribeSecret",
+        type,
+        identifier,
+        cloudformationIdentifier,
+        "localstack",
+        4566,
+        "http://localstack:4566",
+        200,
+        List.of(assertAttribute(SemanticConventionsConstants.AWS_SECRET_ARN, "arn:aws:secretsmanager:us-west-2:000000000000:secret:test-secret-id")));
+  }
 }

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/awssdk/v1/AwsSdkV1Test.java

@@ -248,4 +248,7 @@ void testBedrockAgentRuntimeKnowledgeBaseId() {
 
   @Test
   void testSecretsManagerCreateSecret() throws Exception { doTestSecretsManagerCreateSecret(); }
+
+  @Test
+  void testSecretsManagerDescribeSecret() throws Exception { doTestSecretsManagerDescribeSecret(); }
 }

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/awssdk/v2/AwsSdkV2Test.java

@@ -249,4 +249,7 @@ void testBedrockAgentRuntimeAgentId() {
 
   @Test
   void testSecretsManagerCreateSecret() throws Exception { doTestSecretsManagerCreateSecret(); }
+
+  @Test
+  void testSecretsManagerDescribeSecret() throws Exception { doTestSecretsManagerDescribeSecret(); }
 }

appsignals-tests/images/aws-sdk/aws-sdk-v1/src/main/java/com/amazon/sampleapp/App.java

@@ -638,13 +638,23 @@ private static void setupBedrock() {
 
   private static void setupSecretsManager() {
       var secretsManagerClient = AWSSecretsManagerClient.builder().withCredentials(CREDENTIALS_PROVIDER).withEndpointConfiguration(endpointConfiguration).build();
+      var createSecretRequest = new CreateSecretRequest().withName("test-secret-id");
+      var response = secretsManagerClient.createSecret(createSecretRequest);
+      var testSecretId = response.getARN();
 
       get (
           "/secretsmanager/createsecret/:secretId",
           (req, res) -> {
             var secretId = req.params(":secretId");
-            var createSecretRequest = new CreateSecretRequest().withName(secretId);
-            secretsManagerClient.createSecret(createSecretRequest);
+            var testCreateSecretRequest = new CreateSecretRequest().withName(secretId);
+            secretsManagerClient.createSecret(testCreateSecretRequest);
+            return "";
+          });
+      get (
+          "/secretsmanager/describesecret/:secretId",
+          (req, res) -> {
+            var describeSecretRequest = new DescribeSecretRequest().withSecretId(testSecretId);
+            secretsManagerClient.describeSecret(describeSecretRequest);
             return "";
           });
   }

appsignals-tests/images/aws-sdk/aws-sdk-v2/src/main/java/com/amazon/sampleapp/App.java

@@ -666,13 +666,23 @@ private static void setupBedrock() {
 
   private static void setupSecretsManager() {
     var secretsManagerClient = SecretsManagerClient.builder().endpointOverride(endpoint).credentialsProvider(CREDENTIALS_PROVIDER).build();
+    var createSecretRequest = CreateSecretRequest.builder().name("test-secret-id").build();
+    var response = secretsManagerClient.createSecret(createSecretRequest);
+    var testSecretId = response.arn();
 
     get(
         "/secretsmanager/createsecret/:secretId",
         (req, res) -> {
           var secretId = req.params(":secretId");
-          var createSecretRequest = CreateSecretRequest.builder().name(secretId).build();
-          secretsManagerClient.createSecret(createSecretRequest);
+          var testCreateSecretRequest = CreateSecretRequest.builder().name(secretId).build();
+          secretsManagerClient.createSecret(testCreateSecretRequest);
+          return "";
+        });
+    get(
+        "/secretsmanager/describesecret/test-secret-id",
+        (req, res) -> {
+          var testDescribeSecretRequest = DescribeSecretRequest.builder().secretId(testSecretId).build();
+          secretsManagerClient.describeSecret(testDescribeSecretRequest);
           return "";
         });
   }