Skip to content

Commit 1ed4c72

Browse files
authored
Update to upstream 0.15.0 (#39)
1 parent 496b76a commit 1ed4c72

File tree

7 files changed

+25
-66
lines changed

7 files changed

+25
-66
lines changed

awsagentprovider/build.gradle.kts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,14 @@ base {
2323
}
2424

2525
dependencies {
26-
compileOnly("io.opentelemetry:opentelemetry-sdk")
2726
compileOnly("io.opentelemetry.javaagent:opentelemetry-javaagent-spi")
27+
compileOnly("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure")
2828
compileOnly("org.slf4j:slf4j-api")
2929

3030
implementation("io.opentelemetry:opentelemetry-sdk-extension-aws")
3131

32+
testImplementation("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure")
33+
3234
testImplementation("com.google.guava:guava")
3335

3436
compileOnly("com.google.code.findbugs:jsr305:3.0.2")

awsagentprovider/src/main/java/io/opentelemetry/sdk/trace/RandomIdGenerator.java

Lines changed: 0 additions & 46 deletions
This file was deleted.
Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,11 @@
1515

1616
package software.amazon.opentelemetry.javaagent.providers;
1717

18-
import io.opentelemetry.api.trace.TracerProvider;
18+
import io.opentelemetry.sdk.autoconfigure.spi.SdkTracerProviderConfigurer;
1919
import io.opentelemetry.sdk.extension.aws.trace.AwsXrayIdGenerator;
20-
import io.opentelemetry.sdk.trace.SdkTracerProvider;
21-
import io.opentelemetry.spi.trace.TracerProviderFactory;
20+
import io.opentelemetry.sdk.trace.SdkTracerProviderBuilder;
2221

23-
public class AwsTracerProviderFactory implements TracerProviderFactory {
24-
25-
private static final SdkTracerProvider TRACER_PROVIDER;
22+
public class AwsTracerConfigurer implements SdkTracerProviderConfigurer {
2623

2724
static {
2825
if (System.getProperty("otel.aws.imds.endpointOverride") == null) {
@@ -31,13 +28,10 @@ public class AwsTracerProviderFactory implements TracerProviderFactory {
3128
System.setProperty("otel.aws.imds.endpointOverride", overrideFromEnv);
3229
}
3330
}
34-
35-
TRACER_PROVIDER =
36-
SdkTracerProvider.builder().setIdGenerator(AwsXrayIdGenerator.getInstance()).build();
3731
}
3832

3933
@Override
40-
public TracerProvider create() {
41-
return TRACER_PROVIDER;
34+
public void configure(SdkTracerProviderBuilder sdkTracerProviderBuilder) {
35+
sdkTracerProviderBuilder.setIdGenerator(AwsXrayIdGenerator.getInstance());
4236
}
4337
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@
1313
# permissions and limitations under the License.
1414
#
1515

16-
software.amazon.opentelemetry.javaagent.providers.AwsTracerProviderFactory
16+
software.amazon.opentelemetry.javaagent.providers.AwsTracerConfigurer
Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,20 @@
1919

2020
import com.google.common.primitives.Ints;
2121
import io.opentelemetry.api.trace.TracerProvider;
22+
import io.opentelemetry.sdk.trace.SdkTracerProvider;
23+
import io.opentelemetry.sdk.trace.SdkTracerProviderBuilder;
2224
import java.util.concurrent.TimeUnit;
2325
import org.junit.jupiter.api.RepeatedTest;
2426

25-
class AwsTracerProviderFactoryTest {
27+
class AwsTracerConfigurerTest {
2628

27-
private static final TracerProvider tracerProvider = new AwsTracerProviderFactory().create();
29+
private static final TracerProvider tracerProvider;
30+
31+
static {
32+
SdkTracerProviderBuilder builder = SdkTracerProvider.builder();
33+
new AwsTracerConfigurer().configure(builder);
34+
tracerProvider = builder.build();
35+
}
2836

2937
// The probability of this passing once without correct IDs is low, 20 times is inconceivable.
3038
@RepeatedTest(20)

dependencyManagement/build.gradle.kts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ val DEPENDENCY_BOMS = listOf(
3030
"com.google.protobuf:protobuf-bom:3.14.0",
3131
"com.linecorp.armeria:armeria-bom:1.4.0",
3232
"io.grpc:grpc-bom:1.35.0",
33-
"io.opentelemetry:opentelemetry-bom:0.14.1",
33+
"io.opentelemetry:opentelemetry-bom:0.15.0",
3434
"org.apache.logging.log4j:log4j-bom:2.14.0",
3535
"org.junit:junit-bom:5.7.0",
3636
"org.springframework.boot:spring-boot-dependencies:2.4.2",
@@ -41,14 +41,15 @@ val DEPENDENCY_BOMS = listOf(
4141
val DEPENDENCY_SETS = listOf(
4242
DependencySet(
4343
"io.opentelemetry",
44-
"0.14.1-alpha",
44+
"0.15.0-alpha",
4545
listOf(
46-
"opentelemetry-api-metrics"
46+
"opentelemetry-api-metrics",
47+
"opentelemetry-sdk-extension-autoconfigure"
4748
)
4849
),
4950
DependencySet(
5051
"io.opentelemetry.javaagent",
51-
"0.14.0",
52+
"0.15.0",
5253
listOf(
5354
"opentelemetry-javaagent",
5455
"opentelemetry-javaagent-spi"

smoke-tests/runner/src/test/java/io/awsobservability/instrumentation/smoketests/runner/SpringBootSmokeTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ public ExportTraceServiceRequest deserialize(
117117
.withEnv("JAVA_TOOL_OPTIONS", "-javaagent:/opentelemetry-javaagent-all.jar")
118118
.withEnv("OTEL_BSP_MAX_EXPORT_BATCH", "1")
119119
.withEnv("OTEL_BSP_SCHEDULE_DELAY", "10")
120-
.withEnv("OTEL_EXPORTER_OTLP_SPAN_ENDPOINT", "backend:8080");
120+
.withEnv("OTEL_EXPORTER_OTLP_ENDPOINT", "http://backend:8080");
121121

122122
private static final TypeReference<List<ExportTraceServiceRequest>>
123123
EXPORT_TRACE_SERVICE_REQUEST_LIST = new TypeReference<>() {};

0 commit comments

Comments
 (0)