Skip to content

Commit 36bb681

Browse files
committed
Test on main build.
1 parent 3558887 commit 36bb681

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

.github/workflows/main-build.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ on:
44
branches:
55
- main
66
- "release/v*"
7+
- test_upgrade_only_v2
78
env:
89
AWS_DEFAULT_REGION: us-east-1
910
STAGING_ECR_REGISTRY: 611364707713.dkr.ecr.us-west-2.amazonaws.com

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/base/JMXMetricsContractTestBase.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,8 @@ protected long getThreshold(String metricName) {
8383
switch (metricName) {
8484
// If maximum memory size is undefined, then value is -1
8585
// https://docs.oracle.com/en/java/javase/17/docs/api/java.management/java/lang/management/MemoryUsage.html#getMax()
86+
case JMXMetricsConstants.TOMCAT_THREADS:
87+
threshold = -3;
8688
case JMXMetricsConstants.JVM_HEAP_MAX:
8789
case JMXMetricsConstants.JVM_NON_HEAP_MAX:
8890
case JMXMetricsConstants.JVM_POOL_MAX:

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/utils/JMXMetricsConstants.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,8 @@ public class JMXMetricsConstants {
9191
TOMCAT_REQUEST_COUNT,
9292
TOMCAT_MAX_TIME,
9393
TOMCAT_PROCESSING_TIME,
94-
// TODO: Pending on root cause why tomcat.threads can be negative
95-
// TOMCAT_THREADS,
96-
TOMCAT_TRAFFIC);
94+
TOMCAT_TRAFFIC,
95+
TOMCAT_THREADS);
9796

9897
// Kafka Metrics
9998
public static final String KAFKA_MESSAGE_COUNT = "kafka.message.count";

0 commit comments

Comments
 (0)