add error path tests for secrets manager

Author: yiyuan-he

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/awssdk/base/AwsSdkBaseTest.java

@@ -2311,6 +2311,41 @@ protected void doTestSecretsManagerDescribeSecret() throws Exception {
         0.0);
   }
 
+  protected void doTestSecretsManagerError() throws Exception {
+    appClient.get("/secretsmanager/error").aggregate().join();
+    var traces = mockCollectorClient.getTraces();
+    var metrics = mockCollectorClient.getMetrics(
+        Set.of(
+            AppSignalsConstants.ERROR_METRIC,
+            AppSignalsConstants.FAULT_METRIC,
+            AppSignalsConstants.LATENCY_METRIC
+        ));
+
+    var localService = getApplicationOtelServiceName();
+    var localOperation = "GET /secretsmanager/error/";
+    var type = "AWS::SecretsManager::Secret";
+    var identifier = "nonexistent-secret-id";
+    var cloudformationIdentifier = "arn:aws:secretsmanager:us-west-2:000000000000:secret:nonexistent-secret-id";
+
+    assertSpanClientAttributes(
+        traces,
+        secretsManagerSpanName("DescribeSecret"),
+        getSecretsManagerRpcServiceName(),
+        localService,
+        localOperation,
+        getSecretsManagerServiceName(),
+        "DescribeSecret",
+        type,
+        identifier,
+        cloudformationIdentifier,
+        "error.test",
+        8080,
+        "http://error.test:8080",
+        400,
+        List.of(
+            assertAttribute(SemanticConventionsConstants.AWS_SECRET_ARN, "arn:aws:secretsmanager:us-west-2:000000000000:secret:nonexistent-secret-id")));
+  }
+
   protected void doTestStepFunctionsDescribeStateMachine() throws Exception {
     appClient.get("/sfn/describestatemachine/test-state-machine").aggregate().join();
     var traces = mockCollectorClient.getTraces();

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/awssdk/v1/AwsSdkV1Test.java

@@ -261,6 +261,11 @@ void testSecretsManagerDescribeSecret() throws Exception {
     doTestSecretsManagerDescribeSecret();
   }
 
+  @Test
+  void testSecretsManagerError() throws Exception {
+    doTestSecretsManagerError();
+  }
+
   @Test
   void testStepFunctionsDescribeStateMachine() throws Exception {
     doTestStepFunctionsDescribeStateMachine();

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/awssdk/v2/AwsSdkV2Test.java

@@ -266,6 +266,11 @@ void testSecretsManagerDescribeSecret() throws Exception {
     doTestSecretsManagerDescribeSecret();
   }
 
+  @Test
+  void testSecretsManagerError() throws Exception {
+    doTestSecretsManagerError();
+  }
+
   @Test
   void testStepFunctionsDescribeStateMachine() throws Exception {
     doTestStepFunctionsDescribeStateMachine();

appsignals-tests/images/aws-sdk/aws-sdk-v1/src/main/java/com/amazon/sampleapp/App.java

@@ -684,6 +684,23 @@ private static void setupSecretsManager() {
           secretsManagerClient.describeSecret(describeRequest);
           return "";
         });
+
+    get(
+        "/secretsmanager/error",
+        (req, res) -> {
+          setMainStatus(400);
+          var errorClient = AWSSecretsManagerClient.builder().withCredentials(CREDENTIALS_PROVIDER)
+              .withEndpointConfiguration(new EndpointConfiguration("http://error.test;8080", Regions.US_WEST_2.getName()))
+              .build();
+
+          try {
+            var describeRequest = new DescribeSecretRequest().withSecretId("nonexistent-secret-id");
+            errorClient.describeSecret(describeRequest);
+          } catch (Exception e) {
+            logger.error("Error describing secret", e);
+          }
+          return "";
+        });
   }
 
   private static void setupStepFunctions() {

appsignals-tests/images/aws-sdk/aws-sdk-v2/src/main/java/com/amazon/sampleapp/App.java

@@ -711,6 +711,25 @@ private static void setupSecretsManager() {
           secretsManagerClient.describeSecret(describeRequest);
           return "";
         });
+    get(
+        "/secretsmanager/error",
+        (req, res) -> {
+          setMainStatus(400);
+          var errorClient = SecretsManagerClient.builder()
+              .endpointOverride(URI.create("http://error.test:8080"))
+              .credentialsProvider(CREDENTIALS_PROVIDER)
+              .build();
+
+          try {
+            var describeRequest = DescribeSecretRequest.builder()
+                .secretId("nonexistent-secret-id")
+                .build();
+            errorClient.describeSecret(describeRequest);
+          } catch (Exception e) {
+            logger.error("Error describing secret", e);
+          }
+          return "";
+        });
   }
 
   private static void setupStepFunctions() {